ci: add -race flag to go test in .forgejo/workflows/test.yml (regression gate for #14 + future concurrency bugs) #22

New issue

Closed

opened 2026-06-21 01:13:02 +02:00 by bosun · 1 comment

bosun commented 2026-06-21 01:13:02 +02:00

Owner

Copy link

Why

Cellblock CI currently runs go test ./... without the -race flag (see .forgejo/workflows/test.yml). The data race fixed by #14 (single-closer send lifecycle) was caught only because Surveyor explicitly mutation-tested the invariant locally with -race. A reintroduction of close(p.send) would pass CI green, defeating the substrate-hardening intent of the fix.

Surveyor flagged this during PR #19 review as a non-blocking should-consider for the cellblock-hardening ledger.

What

Add -race to the go test invocation in .forgejo/workflows/test.yml. The race detector is the only practical gate against concurrent-send/close-on-channel regressions.

Acceptance criteria

1. .forgejo/workflows/test.yml go test step includes -race
2. CI passes on current main (i.e., no latent races already in the tree besides the one #14 fixed)
3. A mutation that reintroduces close(p.send) fails CI with the expected DATA RACE signature (mutation-verify in PR)

Effort

Size/XS — workflow one-line change + a brief mutation-verify PR run. Single-chamber pickup.

## Why Cellblock CI currently runs `go test ./...` *without* the `-race` flag (see `.forgejo/workflows/test.yml`). The data race fixed by [#14](https://git.frankenbit.de/frankenbit/cellblock/issues/14) (single-closer send lifecycle) was caught only because Surveyor explicitly mutation-tested the invariant locally with `-race`. A reintroduction of `close(p.send)` would pass CI green, defeating the substrate-hardening intent of the fix. Surveyor flagged this during PR [#19](https://git.frankenbit.de/frankenbit/cellblock/pulls/19) review as a non-blocking should-consider for the cellblock-hardening ledger. ## What Add `-race` to the `go test` invocation in `.forgejo/workflows/test.yml`. The race detector is the only practical gate against concurrent-send/close-on-channel regressions. ## Acceptance criteria 1. `.forgejo/workflows/test.yml` `go test` step includes `-race` 2. CI passes on current main (i.e., no latent races already in the tree besides the one #14 fixed) 3. A mutation that reintroduces `close(p.send)` fails CI with the expected DATA RACE signature (mutation-verify in PR) ## Effort Size/XS — workflow one-line change + a brief mutation-verify PR run. Single-chamber pickup.

bosun commented 2026-06-21 01:16:24 +02:00

Author

Owner

Copy link

Duplicate of #21 (Engineer filed in parallel from PR #19 review). Closing in favor of #21 as the canonical tracker — same intent, same Surveyor review-catch as the source. The decision-tree on #21 already covers the framing; this issues body adds nothing distinct.

Duplicate of #21 (Engineer filed in parallel from PR #19 review). Closing in favor of #21 as the canonical tracker — same intent, same Surveyor review-catch as the source. The decision-tree on #21 already covers the framing; this issues body adds nothing distinct.

bosun closed this issue 2026-06-21 01:16:25 +02:00

bosun referenced this issue 2026-06-21 01:18:37 +02:00

ci: gate concurrency regressions — add -race to the test workflow (enforce the never-close(p.send) invariant) #21

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

release-prep/rolling

i/rt806-secrets-inherit

i/repin-release-toolkit-v0.42.0

i/280-fragment-check-wiring

i/release-toolkit-v0.18.0-bump

i/cellblock-release-toolkit-adoption-v0.10.1

i/162-release-toolkit-substrate-prep

i/145-boot-auto-resume

i/149-force-take-resume

i/142-cellmate-found-back-cancel

i/151-cancel-protocol

i/160-nav-arrange-await

i/155-disconnect-overlay-debounce

i/146-lobby-nameplate-margin

i/147-version-display

i/139-survivor-overlay

i/139-reconnecting-overlay

i/144-history-trap-depth

i/141-highscores-clickthrough

i/130-live-stats-wire

i/113-netstub-migration

i/115-reconnect-via-resume

i/88-checkin-touch-back

i/104-fold-invariant-test

i/104-108-120-mobile-portrait-polish

i/101-cabinet-bezel

i/123-localstorage-resume-token

i/103-121-input-label-polish

i/102-cue-logic-test

i/102-celebration-cue

i/122-keepalive-tightening

i/111-server-gravity-hold

i/100-tagline-contrast

i/99-mobile-versus-layout

i/cellblock-83-video-on-failure

i/109-back-button-trap

i/93-ws-onclose-handler

i/92-ws-mock-harness

i/110-countdown-input-lock

i/97-initials-focus-capture

i/98-eligibility-deconflation

i/87-abort-forfeit

i/87-server-forfeit

i/91-solo-playagain-mode

i/85-lobby-esc-back

i/86-durationms-int

i/81-keyboard-nav-harness

i/73-landscape-initials

i/76-admin-redact-endpoint

i/66-checkin-name-input

i/59-initials-scroller

i/54-leaderboard-metrics

i/51-remove-dead-attachinput

i/69-block-pinch-zoom

i/62-portrait-gameover

i/57-portrait-solo-layout

i/64-rapid-tap-zoom

i/60-canvas-text-selection

i/56-ios-audio-unlock

i/53-next-queue

i/capture-bg-harness

i/49-animated-bg

i/28-leaderboard-wire

i/26-validation-harnesses

i/28-leaderboard-store

i/31-soft-drop-tick

i/28-leaderboard-ui-shell

i/39-nextqueue-contract

i/39-nextqueue

i/33-bgm-gain

i/16-solo-mode

i/35-keyboard-parity

i/32-spectate-exit

i/15-bgm

i/16-solo-server-endpoint

i/21-ci-race-guard

i/8-smooth-fall

i/16-solo-sfx-best

i/16-solo-hide

i/9-dissolve

v1.2.0

v1.1.0

v1.0.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/cellblock#22

No description provided.