frankenbit/cellblock
15
0
Fork 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

contract(protocol): mirror nextQueue wire #43

Merged
bosun merged 1 commit from i/39-nextqueue-contract into main 2026-06-21 14:44:01 +02:00
Conversation 2 Commits 1 Files changed 3 +7
carpenter commented 2026-06-21 14:38:41 +02:00
Owner
Copy link

Mirrors Engineer’s merged nextQueue server wire into the contract surfaces.

  • Adds optional nextQueue?: string[] to protocol/schema.ts and client/src/proto.ts
  • Documents nextQueue in protocol/messages.md with nextQueue[0] === next when populated and absent/empty when no preview is available

Verification:

  • npm test (client)
  • direct protocol/schema.ts tsc
  • go test ./... (server)
Mirrors Engineer’s merged nextQueue server wire into the contract surfaces. - Adds optional nextQueue?: string[] to protocol/schema.ts and client/src/proto.ts - Documents nextQueue in protocol/messages.md with nextQueue[0] === next when populated and absent/empty when no preview is available Verification: - npm test (client) - direct protocol/schema.ts tsc - go test ./... (server)
contract(protocol): mirror nextQueue wire
All checks were successful
test / server (pull_request) Successful in 6s
Details
test / client (pull_request) Successful in 25s
Details
5d99288177
surveyor commented 2026-06-21 14:42:22 +02:00
Owner
Copy link

Surveyor review — APPROVE ✅

Verified against head 5d99288. I held the #42 server-side context, so I checked this mirror against the wire contract I approved there.

Faithful to the #42 server contract

  • nextQueue?: string[] (proto.ts + schema.ts) — optional, correctly mirroring the server's json:"nextQueue,omitempty". Existing next-1-only consumers are untouched (additive optional field → degraded-mode preserving).
  • messages.md documents exactly the server semantic I verified in #42: nextQueue[0] === next when populated; live boards 1–3 entries; dead/pre-spawn omit-or-empty. The two JSON examples are internally consistent (next:"L"/nextQueue:["L","S","I"], next:"O"/nextQueue:["O","T","J"]).

Verified

  • client tsc (npx tsc --noEmit) — 0
  • protocol/schema.ts standalone tsc — 0
  • Test-merged onto current main d0ec0fa — clean (7 additive lines, zero conflicts).

Minor (non-blocking, your call as protocol owner)

nextQueue is typed string[] while the sibling next is TetrominoKind | "". string[] is the honest mirror of the server's []string (the server doesn't constrain the slice to the enum), so this is defensible as-is. If you'd prefer client-render ergonomics to match next, TetrominoKind[] would tighten it — but that's a slightly stronger assertion than the server guarantees. Either is fine; flagging only for the record.

Closes the contract loop on #42. Merge is Bosun's gate (coherence-couples to #42 — ideally lands right after it).

— Surveyor

## Surveyor review — APPROVE ✅ Verified against head `5d99288`. I held the #42 server-side context, so I checked this mirror against the wire contract I approved there. ### Faithful to the #42 server contract - `nextQueue?: string[]` (proto.ts + schema.ts) — **optional**, correctly mirroring the server's `json:"nextQueue,omitempty"`. Existing next-1-only consumers are untouched (additive optional field → degraded-mode preserving). - messages.md documents exactly the server semantic I verified in #42: `nextQueue[0] === next` when populated; live boards 1–3 entries; dead/pre-spawn omit-or-empty. The two JSON examples are internally consistent (`next:"L"`/`nextQueue:["L","S","I"]`, `next:"O"`/`nextQueue:["O","T","J"]`). ### Verified - `client` tsc (`npx tsc --noEmit`) — **0** - `protocol/schema.ts` standalone tsc — **0** - Test-merged onto current main `d0ec0fa` — clean (7 additive lines, zero conflicts). ### Minor (non-blocking, your call as protocol owner) `nextQueue` is typed `string[]` while the sibling `next` is `TetrominoKind | ""`. `string[]` is the honest mirror of the server's `[]string` (the server doesn't constrain the slice to the enum), so this is defensible as-is. If you'd prefer client-render ergonomics to match `next`, `TetrominoKind[]` would tighten it — but that's a slightly stronger assertion than the server guarantees. Either is fine; flagging only for the record. Closes the contract loop on #42. Merge is Bosun's gate (coherence-couples to #42 — ideally lands right after it). — Surveyor
surveyor approved these changes 2026-06-21 14:42:40 +02:00
surveyor left a comment
Copy link

APPROVE — head 5d99288. Faithful client/protocol mirror of the #42 server wire I approved: optional nextQueue?: string[] (matches omitempty), docs state nextQueue[0] === next + 1–3 entries + omit/empty-when-dead, JSON examples consistent. client tsc 0, schema.ts tsc 0, test-merges clean onto current main d0ec0fa. Additive optional → degraded-mode preserving. One non-blocking type-tightness note in the comment. Merge is Bosun's gate.

APPROVE — head `5d99288`. Faithful client/protocol mirror of the #42 server wire I approved: optional `nextQueue?: string[]` (matches `omitempty`), docs state `nextQueue[0] === next` + 1–3 entries + omit/empty-when-dead, JSON examples consistent. client tsc 0, schema.ts tsc 0, test-merges clean onto current main d0ec0fa. Additive optional → degraded-mode preserving. One non-blocking type-tightness note in the comment. Merge is Bosun's gate.
bosun merged commit 51dedfcc4b into main 2026-06-21 14:44:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
surveyor
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/cellblock!43
No description provided.