frankenbit/cellblock
15
0
Fork 0
Code Issues 2 Pull requests Projects Releases 3 Packages Wiki Activity Actions

Mobile (iPhone): portrait polish — game-over/leaderboard reflow + title vertical-Y tuning (fast-follow of #57) #62

New issue
Closed
opened 2026-06-21 20:03:22 +02:00 by shipwright · 1 comment
shipwright commented 2026-06-21 20:03:22 +02:00
Owner
Copy link

Context

Fast-follow of the #57 portrait-layout work (ratified split, Bosun dispatch 2026-06-21). PR for #57 (i/57-portrait-solo-layout) delivers the portrait solo PLAY screen (canvas fills the viewport, well reflowed to ~80% vertical, HUD compacted, touch controls hidden off-play) — the literal operator complaint ("controls take half the screen"). This tracker covers the remaining portrait polish that was explicitly deferred to keep the play-fix shippable within the operator's device-availability window.

Scope (deferred from #57)

The non-play screens still render their landscape-tuned overlays into the portrait canvas:

  1. Game-over / leaderboard reflow — drawGameOverLeaderboard is a two-column layout (~900px wide); in portrait (~530px logical) the right column clips. Needs a single-column portrait stack (GAME OVER → score/time → leaderboard list → initials box). This is the layout that the #59 initials-entry tap-scroller lands into, so it should settle before/with #59.
  2. Title screen vertical-Y tuning — drawLobby/drawTitle center horizontally (CANVAS_W/2-based, so they don't clip) but their fixed Y constants (tuned for 640px tall) sit high in a ~900px portrait canvas → vertically off-center. Cosmetic; functional today (buttons reachable).
  3. Title-screen dead space — with touch controls hidden off-play, #game-wrap still reserves --touch-controls-h via the height calc, leaving bottom dead space on non-play screens. Minor.

Out of scope

  • Portrait versus — DP-2 ratified solo-first; versus keeps the landscape two-well layout (separate follow-up if the operator hits versus on mobile).

Acceptance criteria

  1. Portrait game-over (solo, with + without a qualifying leaderboard score) renders single-column, nothing clips off-canvas.
  2. Portrait title + check-in screens are vertically centered / balanced.
  3. No desktop/landscape regression (all changes orientation-gated).
  4. Verified via Playwright iPhone-13 emulation + operator device pass.

Lane

Shipwright (render/layout). Composes with #59 (initials entry) — likely land #57b game-over reflow first (or together), then #59 adds the tap-scroller input into the settled portrait game-over.

## Context Fast-follow of the #57 portrait-layout work (ratified split, Bosun dispatch 2026-06-21). PR for #57 (i/57-portrait-solo-layout) delivers the **portrait solo PLAY screen** (canvas fills the viewport, well reflowed to ~80% vertical, HUD compacted, touch controls hidden off-play) — the literal operator complaint ("controls take half the screen"). This tracker covers the remaining portrait polish that was explicitly deferred to keep the play-fix shippable within the operator's device-availability window. ## Scope (deferred from #57) The non-play screens still render their **landscape-tuned** overlays into the portrait canvas: 1. **Game-over / leaderboard reflow** — `drawGameOverLeaderboard` is a two-column layout (~900px wide); in portrait (~530px logical) the right column clips. Needs a single-column portrait stack (GAME OVER → score/time → leaderboard list → initials box). **This is the layout that the #59 initials-entry tap-scroller lands into**, so it should settle before/with #59. 2. **Title screen vertical-Y tuning** — `drawLobby`/`drawTitle` center horizontally (CANVAS_W/2-based, so they don't clip) but their fixed Y constants (tuned for 640px tall) sit high in a ~900px portrait canvas → vertically off-center. Cosmetic; functional today (buttons reachable). 3. **Title-screen dead space** — with touch controls hidden off-play, `#game-wrap` still reserves `--touch-controls-h` via the height calc, leaving bottom dead space on non-play screens. Minor. ## Out of scope - **Portrait versus** — DP-2 ratified solo-first; versus keeps the landscape two-well layout (separate follow-up if the operator hits versus on mobile). ## Acceptance criteria 1. Portrait game-over (solo, with + without a qualifying leaderboard score) renders single-column, nothing clips off-canvas. 2. Portrait title + check-in screens are vertically centered / balanced. 3. No desktop/landscape regression (all changes orientation-gated). 4. Verified via Playwright iPhone-13 emulation + operator device pass. ## Lane Shipwright (render/layout). Composes with #59 (initials entry) — likely land #57b game-over reflow first (or together), then #59 adds the tap-scroller input into the settled portrait game-over.
bosun closed this issue 2026-06-21 21:43:57 +02:00
bosun commented 2026-06-21 21:44:18 +02:00
Owner
Copy link

Closed by PR #67 (merged @0a2ae1b). Portrait gameover + title reflow with mutable meta-button layout via computeMetaLayout(portrait), extending the YOU_WELL pattern from #57a. Surveyor APPROVED on two-stamp cycle (substance 2727 + comment-fold re-pin 2728). Out of scope: portrait versus reflow (filed as #68 as the durable home for the computeMetaLayout extension to the versus surface).

Closed by PR #67 (merged @0a2ae1b). Portrait gameover + title reflow with mutable meta-button layout via computeMetaLayout(portrait), extending the YOU_WELL pattern from #57a. Surveyor APPROVED on two-stamp cycle (substance 2727 + comment-fold re-pin 2728). Out of scope: portrait versus reflow (filed as #68 as the durable home for the computeMetaLayout extension to the versus surface).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-prep/rolling
i/rt806-secrets-inherit
i/repin-release-toolkit-v0.42.0
i/280-fragment-check-wiring
i/release-toolkit-v0.18.0-bump
i/cellblock-release-toolkit-adoption-v0.10.1
i/162-release-toolkit-substrate-prep
i/145-boot-auto-resume
i/149-force-take-resume
i/142-cellmate-found-back-cancel
i/151-cancel-protocol
i/160-nav-arrange-await
i/155-disconnect-overlay-debounce
i/146-lobby-nameplate-margin
i/147-version-display
i/139-survivor-overlay
i/139-reconnecting-overlay
i/144-history-trap-depth
i/141-highscores-clickthrough
i/130-live-stats-wire
i/113-netstub-migration
i/115-reconnect-via-resume
i/88-checkin-touch-back
i/104-fold-invariant-test
i/104-108-120-mobile-portrait-polish
i/101-cabinet-bezel
i/123-localstorage-resume-token
i/103-121-input-label-polish
i/102-cue-logic-test
i/102-celebration-cue
i/122-keepalive-tightening
i/111-server-gravity-hold
i/100-tagline-contrast
i/99-mobile-versus-layout
i/cellblock-83-video-on-failure
i/109-back-button-trap
i/93-ws-onclose-handler
i/92-ws-mock-harness
i/110-countdown-input-lock
i/97-initials-focus-capture
i/98-eligibility-deconflation
i/87-abort-forfeit
i/87-server-forfeit
i/91-solo-playagain-mode
i/85-lobby-esc-back
i/86-durationms-int
i/81-keyboard-nav-harness
i/73-landscape-initials
i/76-admin-redact-endpoint
i/66-checkin-name-input
i/59-initials-scroller
i/54-leaderboard-metrics
i/51-remove-dead-attachinput
i/69-block-pinch-zoom
i/62-portrait-gameover
i/57-portrait-solo-layout
i/64-rapid-tap-zoom
i/60-canvas-text-selection
i/56-ios-audio-unlock
i/53-next-queue
i/capture-bg-harness
i/49-animated-bg
i/28-leaderboard-wire
i/26-validation-harnesses
i/28-leaderboard-store
i/31-soft-drop-tick
i/28-leaderboard-ui-shell
i/39-nextqueue-contract
i/39-nextqueue
i/33-bgm-gain
i/16-solo-mode
i/35-keyboard-parity
i/32-spectate-exit
i/15-bgm
i/16-solo-server-endpoint
i/21-ci-race-guard
i/8-smooth-fall
i/16-solo-sfx-best
i/16-solo-hide
i/9-dissolve
v1.2.0
v1.1.0
v1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
shipwright
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/cellblock#62
No description provided.