frankenbit/purser
15
0
Fork 0
Code Issues 6 Pull requests Projects Releases 4 Packages Wiki Activity Actions

Wire binary release asset build + version ldflags injection #16

New issue
Closed
opened 2026-08-05 19:30:11 +02:00 by pilot · 0 comments
pilot commented 2026-08-05 19:30:11 +02:00
Owner
Copy link

The internal/version package accepts a Tag variable injected via -ldflags at build time, but the release workflow (reusable-release.yml@v0.35.0) has no build_command/asset_paths input and produces no binary artifact.

To complete the version-stamp feature:

  1. Add a go build -ldflags "-X .../version.Tag=${VERSION}" step to the release workflow (either via a release-toolkit input when one is added, or a separate consumer job)
  2. Add a VERSION build-arg to the Dockerfile so image builds can also inject the version
  3. Publish the binary as a release asset on Forgejo

Until this lands, deployed images show the VCS commit hash (from debug.ReadBuildInfo) rather than the release tag.

Filed from purser#7 (PR#14) per Lookout review id=4857.

The `internal/version` package accepts a `Tag` variable injected via `-ldflags` at build time, but the release workflow (`reusable-release.yml@v0.35.0`) has no `build_command`/`asset_paths` input and produces no binary artifact. To complete the version-stamp feature: 1. Add a `go build -ldflags "-X .../version.Tag=${VERSION}"` step to the release workflow (either via a release-toolkit input when one is added, or a separate consumer job) 2. Add a `VERSION` build-arg to the Dockerfile so image builds can also inject the version 3. Publish the binary as a release asset on Forgejo Until this lands, deployed images show the VCS commit hash (from `debug.ReadBuildInfo`) rather than the release tag. Filed from purser#7 (PR#14) per Lookout review id=4857.
pilot self-assigned this 2026-08-05 22:40:04 +02:00
pilot closed this issue 2026-08-06 15:03:32 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/attach-release-asset-draft-checkout
i/bump-rt-v0.36.0
release-prep/rolling
i/41-v040-changelog-density
i/18-per-issuance-lifetime
i/44-password-rotation-docs
i/16-binary-release-asset
i/29-version-fallback-test
i/41-changelog-body-check-pr-gate
i/39-publish-mode-draft
i/32-rollback-on-failed-probe
chore/unwind-v0.2.0-prep
i/16-arm5-coupling-comment
i/16-segment3-version-passthrough
i/4-record-the-lifetime-reasoning
i/2-profile-gate-ac-closure
i/3-backup-alone-premise-and-expired-bundle-purge
i/16-version-ldflags
i/12-13-post-sign-revoke-and-ca-root-tests
i/19-deploy-on-release
fix/changelog-forward-ref-gate
i/5-download-token-only
i/mac-substitution
i/implementation
i/scaffold-go-layout
parked/main-bosun-seed
i/purser-implementation-wip
v0.4.0
v0.3.0
v0.2.0
v0.1.0
Labels
Clear labels   
kind/bug

   
kind/chore

   
kind/docs

   
kind/feature

   
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

  
status/deferred
Deferred — not in active sprint scope; recorded for future consideration

No labels
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
status/deferred
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
pilot
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/purser#16
No description provided.