test(version): add arm for empty vcs.revision guard #53

New issue

Closed

opened 2026-08-06 14:46:30 +02:00 by pilot · 0 comments

pilot commented

2026-08-06 14:46:30 +02:00

Owner

Surveyor found this during PR#51 review (review 4983, approved).

The s.Value != "" guard in String() has no dedicated test. Removing it makes all five existing arms still pass — because the arms that inject a non-empty vcs.revision don't exercise the empty case, and the dev-fallback arm injects no vcs.revision at all.

Missing arm: inject vcs.revision = "" (key present, value empty) and verify String() returns "dev", not "".

func TestString_VCSRevision_EmptyValue(t *testing.T) {
    defer resetTag("")()
    defer injectBuildInfo(func() (*debug.BuildInfo, bool) {
        return &debug.BuildInfo{Settings: []debug.BuildSetting{{Key: "vcs.revision", Value: ""}}}, true
    })()
    if got := String(); got != "dev" {
        t.Errorf("String() = %q, want %q (empty vcs.revision must fall through to dev)", got, "dev")
    }
}

Proof that this arm catches the mutation: removing s.Value != "" makes the empty-value case return "", which fails this test.

Surveyor provided the fix; carry-forward from PR#51 per "freeze on first approval" discipline.

Surveyor found this during PR#51 review (review 4983, approved). The `s.Value != ""` guard in `String()` has no dedicated test. Removing it makes all five existing arms still pass — because the arms that inject a non-empty `vcs.revision` don't exercise the empty case, and the dev-fallback arm injects no `vcs.revision` at all. **Missing arm**: inject `vcs.revision = ""` (key present, value empty) and verify `String()` returns `"dev"`, not `""`. ```go func TestString_VCSRevision_EmptyValue(t *testing.T) { defer resetTag("")() defer injectBuildInfo(func() (*debug.BuildInfo, bool) { return &debug.BuildInfo{Settings: []debug.BuildSetting{{Key: "vcs.revision", Value: ""}}}, true })() if got := String(); got != "dev" { t.Errorf("String() = %q, want %q (empty vcs.revision must fall through to dev)", got, "dev") } } ``` Proof that this arm catches the mutation: removing `s.Value != ""` makes the empty-value case return `""`, which fails this test. Surveyor provided the fix; carry-forward from PR#51 per "freeze on first approval" discipline.

pilot referenced this issue from a commit

2026-08-06 14:50:06 +02:00

test(version): add arm for empty vcs.revision guard (purser#53)

pilot closed this issue

2026-08-06 14:51:23 +02:00

pilot referenced this issue from a commit

2026-08-06 14:56:02 +02:00

test(version): add arm for empty vcs.revision guard (purser#53)