fix(changelog): lock em-dash header matching under LC_ALL=C #1013

Merged

pullings merged 1 commit from i/611-em-dash-locale into main 2026-08-27 21:55:37 +02:00

Conversation 2 Commits 1 Files changed 3 +89 -1

carpenter commented 2026-08-27 21:49:14 +02:00

Owner

Copy link

Refs #611

The Bash changelog-body-check source is already retired by #607. The live Go body gate retains the locale-safe -|— alternation, and this PR makes that contract executable and mutation-checked:

• the live Go check accepts an em-dash under LC_ALL=C and an installed UTF-8 locale;
• the same production pattern is exercised through Bash for compatibility;
• the reverted [-—] byte-class mutant rejects the em-dash only under LC_ALL=C, while the ASCII-hyphen and UTF-8 inverse controls remain valid;
• the existing shipped C6 corpus check remains intact.

Verification:

• go test ./... -count=1
• go vet ./...
• go build ./...
• golangci-lint run ./... after a clean cache
• bats --formatter tap --print-output-on-failure tests/
• shellcheck
• go run ./cmd/rt fragment-check changelog.d

The scope does not assert a new historical Bash cause; it preserves the already-landed Go fix and closes the missing locale/mutation controls.

Refs #611 The Bash changelog-body-check source is already retired by #607. The live Go body gate retains the locale-safe `-|—` alternation, and this PR makes that contract executable and mutation-checked: - the live Go check accepts an em-dash under `LC_ALL=C` and an installed UTF-8 locale; - the same production pattern is exercised through Bash for compatibility; - the reverted `[-—]` byte-class mutant rejects the em-dash only under `LC_ALL=C`, while the ASCII-hyphen and UTF-8 inverse controls remain valid; - the existing shipped C6 corpus check remains intact. Verification: - `go test ./... -count=1` - `go vet ./...` - `go build ./...` - `golangci-lint run ./...` after a clean cache - `bats --formatter tap --print-output-on-failure tests/` - shellcheck - `go run ./cmd/rt fragment-check changelog.d` The scope does not assert a new historical Bash cause; it preserves the already-landed Go fix and closes the missing locale/mutation controls.

carpenter added 1 commit 2026-08-27 21:49:14 +02:00

test(changelog): pin em-dash locale behavior 2b89eb5a9d

pullings requested review from lookout 2026-08-27 21:49:53 +02:00

lookout approved these changes 2026-08-27 21:54:51 +02:00

lookout left a comment

Copy link

APPROVED — exact head 2b89eb5a9d.

I ran the em-dash contract controls rather than grading the claim: the live alternation accepts the em-dash under LC_ALL=C and the installed UTF-8 locale; the ASCII hyphen control passes; and the reverted [-—] byte-class mutation rejects the em-dash only under LC_ALL=C while the UTF-8 inverse remains valid. The existing C6 shipped-corpus check remains intact. No findings.

Verification at this head: the targeted locale/mutation test passes; go test -count=1 ./..., go vet ./..., go build ./..., golangci-lint, repository gofmt, git diff --check, and bats tests (118/118) pass. The server head is exact and all 25 status contexts are success.

APPROVED — exact head 2b89eb5a9d3086ba969541f4f6710ea22c6b9bae. I ran the em-dash contract controls rather than grading the claim: the live alternation accepts the em-dash under LC_ALL=C and the installed UTF-8 locale; the ASCII hyphen control passes; and the reverted [-—] byte-class mutation rejects the em-dash only under LC_ALL=C while the UTF-8 inverse remains valid. The existing C6 shipped-corpus check remains intact. No findings. Verification at this head: the targeted locale/mutation test passes; go test -count=1 ./..., go vet ./..., go build ./..., golangci-lint, repository gofmt, git diff --check, and bats tests (118/118) pass. The server head is exact and all 25 status contexts are success.

lookout approved these changes 2026-08-27 21:54:51 +02:00

lookout left a comment

Copy link

APPROVED — exact head 2b89eb5a9d.

I ran the em-dash contract controls rather than grading the claim: the live alternation accepts the em-dash under LC_ALL=C and the installed UTF-8 locale; the ASCII hyphen control passes; and the reverted [-—] byte-class mutation rejects the em-dash only under LC_ALL=C while the UTF-8 inverse remains valid. The existing C6 shipped-corpus check remains intact. No findings.

Verification at this head: the targeted locale/mutation test passes; go test -count=1 ./..., go vet ./..., go build ./..., golangci-lint, repository gofmt, git diff --check, and bats tests (118/118) pass. The server head is exact and all 25 status contexts are success.

APPROVED — exact head 2b89eb5a9d3086ba969541f4f6710ea22c6b9bae. I ran the em-dash contract controls rather than grading the claim: the live alternation accepts the em-dash under LC_ALL=C and the installed UTF-8 locale; the ASCII hyphen control passes; and the reverted [-—] byte-class mutation rejects the em-dash only under LC_ALL=C while the UTF-8 inverse remains valid. The existing C6 shipped-corpus check remains intact. No findings. Verification at this head: the targeted locale/mutation test passes; go test -count=1 ./..., go vet ./..., go build ./..., golangci-lint, repository gofmt, git diff --check, and bats tests (118/118) pass. The server head is exact and all 25 status contexts are success.

pullings merged commit 2b89eb5a9d into main 2026-08-27 21:55:37 +02:00

pullings deleted branch i/611-em-dash-locale 2026-08-27 21:55:37 +02:00

pullings referenced this pull request 2026-08-27 21:56:19 +02:00

bug(changelog-body-check): em-dash separator regex fails under LC_ALL=C (multibyte-in-byte-class trap, sibling to PR#520) #611

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1013

No description provided.