test(register-check): pin compact option controls #1017

Merged

pullings merged 1 commit from i/897-register-controls into main 2026-08-28 00:12:31 +02:00

Conversation 1 Commits 1 Files changed 1 +30

carpenter commented 2026-08-27 23:54:41 +02:00

Owner

Copy link

Summary

• Measured current main at 5192ba9e75ff5616f11358b354c40d31bdaf8c7a: the register-check scanned surface contains zero compact git commit -qm literals and six separated git commit -q -m references.
• Kept the scrub-first remedy from the earlier change; the register matcher is unchanged.
• Added CLI-level controls for the compact option cluster, separated options, real QM vocabulary, and the equomatic near miss.

The compact form remains a register-check hit in synthetic input so callers cannot solve the false positive by weakening or allow-listing the matcher. The repository callers use the separated form.

Verification

• go test ./... -count=1
• go vet ./...
• go build ./...
• bats tests (118/118)
• warning-level ShellCheck over scripts/
• go run ./cmd/rt register-check (0 hits)
• git diff --check

Mutation evidence is preserved in the handoff:

• Reintroducing git commit -qm base in a scanned test file made register-check exit 1.
• Removing the QM pattern made the compact and real-vocabulary controls fail.
• Broadening the pattern branch made the separated-options inverse control fail.

No-Changelog: test-only regression controls; the caller scrub is already shipped.

Refs #897

## Summary - Measured current `main` at `5192ba9e75ff5616f11358b354c40d31bdaf8c7a`: the register-check scanned surface contains zero compact `git commit -qm` literals and six separated `git commit -q -m` references. - Kept the scrub-first remedy from the earlier change; the register matcher is unchanged. - Added CLI-level controls for the compact option cluster, separated options, real `QM` vocabulary, and the `equomatic` near miss. The compact form remains a register-check hit in synthetic input so callers cannot solve the false positive by weakening or allow-listing the matcher. The repository callers use the separated form. ## Verification - `go test ./... -count=1` - `go vet ./...` - `go build ./...` - `bats tests` (118/118) - warning-level ShellCheck over `scripts/` - `go run ./cmd/rt register-check` (0 hits) - `git diff --check` Mutation evidence is preserved in the handoff: - Reintroducing `git commit -qm base` in a scanned test file made register-check exit 1. - Removing the `QM` pattern made the compact and real-vocabulary controls fail. - Broadening the pattern branch made the separated-options inverse control fail. No-Changelog: test-only regression controls; the caller scrub is already shipped. Refs #897

carpenter added 1 commit 2026-08-27 23:54:41 +02:00

test(register-check): pin compact option controls e0c68bce3e

pullings requested review from sentry 2026-08-27 23:55:14 +02:00

pullings referenced this pull request 2026-08-27 23:55:26 +02:00

bug(register-check): git commit -qm false-positives on the QM vocabulary entry #897

sentry approved these changes 2026-08-28 00:07:15 +02:00

sentry left a comment

Copy link

Reviewed exact head e0c68bce3e. The added test constructs the compact -qm token by concatenation, so it exercises the live matcher without introducing a production scanned literal; it covers compact and QM positive controls plus separated-options and equomatic boundary negatives, and asserts the drift sentinel/output. The current base advanced to 59dc767229; an independent scan there remains 0 compact and 6 separated references. Local Go tests, vet, build, Bats 118/118, ShellCheck, register-check, and diff-check pass; Forgejo CI is 25/25 success.

Reviewed exact head e0c68bce3eae62526a0af9be5c2f8136c3d25962. The added test constructs the compact -qm token by concatenation, so it exercises the live matcher without introducing a production scanned literal; it covers compact and QM positive controls plus separated-options and equomatic boundary negatives, and asserts the drift sentinel/output. The current base advanced to 59dc767229ac0712188130128691ef2ea0c403d6; an independent scan there remains 0 compact and 6 separated references. Local Go tests, vet, build, Bats 118/118, ShellCheck, register-check, and diff-check pass; Forgejo CI is 25/25 success.

pullings merged commit 3d7951139e into main 2026-08-28 00:12:31 +02:00

pullings deleted branch i/897-register-controls 2026-08-28 00:12:32 +02:00

pullings referenced this pull request 2026-08-28 10:13:08 +02:00

bug(register-check): git commit -qm false-positives on the QM vocabulary entry #897

Sign in to join this conversation.

Reviewers

No reviewers

sentry

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1017

No description provided.