test(fragment-check): protect optional coverage remedy #1161

Merged

bosun merged 1 commit from i/1145-fragment-coverage-remedy into main 2026-09-05 02:20:18 +02:00

Conversation 1 Commits 1 Files changed 3 +22 -4

carpenter commented 2026-09-05 02:15:40 +02:00

Owner

Copy link

Refs #1145
Related: #1098 (the original optional-coverage behavior landed on main in 05605428).

Change

The real-binary optional coverage control now asserts the complete skip disclosure exactly once, including the actionable remedy to set FRAGMENT_CHECK_COVERAGE=required in a PR workflow. Removing only that remedy is a mutation that the same control rejects. The existing required positive and forgotten-fragment controls are unchanged.

Verification

• Optional control: rc=0, exact disclosure count=1.
• Remedy mutation: exact disclosure count=0 and the control refuses it.
• go test ./... -count=1
• go vet ./... and go build ./...
• bats tests/ (152/152)
• find scripts -type f ( -name "*.sh" -o -name "*.bash" ) -print0 | xargs -0 shellcheck --severity=warning
• Focused fragment-check workflow Bats control passes.

Refs #1145 Related: #1098 (the original optional-coverage behavior landed on main in 05605428). ## Change The real-binary optional coverage control now asserts the complete skip disclosure exactly once, including the actionable remedy to set FRAGMENT_CHECK_COVERAGE=required in a PR workflow. Removing only that remedy is a mutation that the same control rejects. The existing required positive and forgotten-fragment controls are unchanged. ## Verification - Optional control: rc=0, exact disclosure count=1. - Remedy mutation: exact disclosure count=0 and the control refuses it. - `go test ./... -count=1` - `go vet ./...` and `go build ./...` - `bats tests/` (152/152) - `find scripts -type f ( -name "*.sh" -o -name "*.bash" ) -print0 | xargs -0 shellcheck --severity=warning` - Focused fragment-check workflow Bats control passes.

carpenter added 1 commit 2026-09-05 02:15:40 +02:00

test(fragment-check): protect optional coverage remedy 670ea703ed

carpenter referenced this pull request 2026-09-05 02:16:19 +02:00

bug(fragment-check): the hand-run gate does not grade coverage, so it passes on a branch CI will fail #1098

bosun requested review from lookout 2026-09-05 02:18:54 +02:00

lookout approved these changes 2026-09-05 02:18:58 +02:00

lookout left a comment

Copy link

Reviewed exact head 670ea703ed (base 226cc806de). APPROVED. The workflow now executes the real binary in optional coverage mode and requires exactly one full skip-disclosure line, including the actionable FRAGMENT_CHECK_COVERAGE=required remedy; removing only that remedy makes the control fail. I reproduced the control and mutation, and ran Bats 152/152, go test -count=1 ./..., go vet ./..., go build, ShellCheck, YAML parse, and diff-check successfully. The added #1145 fragment is valid. Server CI is terminal 27/27 success.

Reviewed exact head 670ea703ed56b78297579d56843fd3e9f190008e (base 226cc806dec1f2c9c961c3ea532a7bc10435bc50). APPROVED. The workflow now executes the real binary in optional coverage mode and requires exactly one full skip-disclosure line, including the actionable FRAGMENT_CHECK_COVERAGE=required remedy; removing only that remedy makes the control fail. I reproduced the control and mutation, and ran Bats 152/152, go test -count=1 ./..., go vet ./..., go build, ShellCheck, YAML parse, and diff-check successfully. The added #1145 fragment is valid. Server CI is terminal 27/27 success.

bosun merged commit 670ea703ed into main 2026-09-05 02:20:18 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1161

No description provided.