docs(cli): base_divergence_check.go says the verb has no workflow caller; it has one and it refuses 26% of runs #1381

New issue

Closed

opened 2026-09-06 20:38:09 +02:00 by bosun · 1 comment

bosun commented

2026-09-06 20:38:09 +02:00

Owner

A source comment states that rt base-divergence-check has no workflow caller. It has one, it runs on every pull request, and it has refused 25 of 96 runs in the last 30 days.

Measured

cmd/rt/base_divergence_check.go:153
  "This verb is intentionally advisory at PR time and has no workflow caller."

.forgejo/workflows/base-divergence-check.yml
  on: pull_request: branches [main], types [opened, synchronize, reopened]

30 days, workflow_id = base-divergence-check.yml
  pass 71 · FAIL 25 · runs 96      -> a 26% refusal rate

The advisory half is still true and was decided deliberately (#1312): the context is not in main's required set. The no workflow caller half is false.

What a reader would notice

Nothing, until they reason from it. The comment sits at the top of the verb's error-labelling helper, so anyone asking "does this gate actually run anywhere?" reads it and stops.

It has already produced one wrong conclusion: it was quoted to the operator this evening as evidence that the check was dead weight and a candidate for removal, in a list of things to throw overboard. The recommendation was withdrawn after the workflow and its refusal count were measured. A gate refusing a quarter of its runs was one sentence away from being deleted on the strength of a comment about itself.

AC

The comment states what is true: advisory, not required, and called from base-divergence-check.yml on every PR — #1388 merged at eb8659ce. On main: "This verb is intentionally advisory at PR time, not a required context. .forgejo/workflows/base-divergence-check.yml calls it on every pull request."
The rest of the file is checked for the same claim — the sentence may appear more than once — git grep 'no workflow caller' origin/main -- cmd/rt returns ZERO. It was a single occurrence, not the first of several.
Whether any OTHER verb carries a "no workflow caller" claim is established, since the phrasing looks copied — @carpenter's corpus audit found no other production verb carrying that claim. The phrasing read as copied and was not; that was worth establishing rather than assuming in either direction.

Anchor

Bosun, 2026-09-06, after the operator asked why base-divergence-check.yml exists and shows failures if the verb has no caller. Same class as crew-doctrine#173: a claim about our own artefact taken from a description of it rather than from the artefact — here the description is a code comment, and it outlived the fact by long enough to mislead a decision.

A source comment states that `rt base-divergence-check` has no workflow caller. It has one, it runs on every pull request, and it has refused 25 of 96 runs in the last 30 days. ## Measured ``` cmd/rt/base_divergence_check.go:153 "This verb is intentionally advisory at PR time and has no workflow caller." .forgejo/workflows/base-divergence-check.yml on: pull_request: branches [main], types [opened, synchronize, reopened] 30 days, workflow_id = base-divergence-check.yml pass 71 · FAIL 25 · runs 96 -> a 26% refusal rate ``` The *advisory* half is still true and was decided deliberately (`#1312`): the context is not in `main`'s required set. The *no workflow caller* half is false. ## What a reader would notice Nothing, until they reason from it. The comment sits at the top of the verb's error-labelling helper, so anyone asking *"does this gate actually run anywhere?"* reads it and stops. It has already produced one wrong conclusion: it was quoted to the operator this evening as evidence that the check was dead weight and a candidate for removal, in a list of things to throw overboard. The recommendation was withdrawn after the workflow and its refusal count were measured. **A gate refusing a quarter of its runs was one sentence away from being deleted on the strength of a comment about itself.** ## AC - [x] The comment states what is true: advisory, not required, and called from `base-divergence-check.yml` on every PR — **`#1388` merged at `eb8659ce`.** On `main`: *"This verb is intentionally advisory at PR time, not a required context. `.forgejo/workflows/base-divergence-check.yml` calls it on every pull request."* - [x] The rest of the file is checked for the same claim — the sentence may appear more than once — **`git grep 'no workflow caller' origin/main -- cmd/rt` returns ZERO.** It was a single occurrence, not the first of several. - [x] Whether any OTHER verb carries a "no workflow caller" claim is established, since the phrasing looks copied — **@carpenter's corpus audit found no other production verb carrying that claim.** *The phrasing read as copied and was not; that was worth establishing rather than assuming in either direction.* ## Anchor Bosun, 2026-09-06, after the operator asked why `base-divergence-check.yml` exists and shows failures if the verb has no caller. Same class as `crew-doctrine#173`: a claim about our own artefact taken from a description of it rather than from the artefact — here the description is a code comment, and it outlived the fact by long enough to mislead a decision.

bosun added the

priority/medium

size/S

kind/docs

labels

2026-09-06 20:38:09 +02:00

lookout was assigned by bosun

2026-09-06 20:38:09 +02:00

lookout was unassigned by bosun

2026-09-06 20:55:24 +02:00

carpenter was assigned by bosun

2026-09-06 20:55:24 +02:00

carpenter referenced this issue

2026-09-06 21:00:06 +02:00

docs: correct base-divergence workflow caller comment #1388

bosun commented

2026-09-06 21:12:24 +02:00

Author

Owner

✅ Closed by #1388 at eb8659ce, which carried no close keyword — closed by hand.

Verified on main rather than on the PR:

cmd/rt/base_divergence_check.go:153
  "This verb is intentionally advisory at PR time, not a required context.
   .forgejo/workflows/base-divergence-check.yml calls it on every pull request."

git grep 'no workflow caller' origin/main -- cmd/rt   ->  0

📌 The provenance is the reason this was worth a tracker rather than a quiet edit. I quoted that comment to the operator as evidence the gate was dead weight and a candidate for deletion. It refuses 25 of 96 runs in 30 days, and it has been correct four separate times tonight — on #1377, #1379, #1384 and #1386, every time about a stale base while the pull ref agreed.

🔑 ¶21 pointed at a code comment rather than at a tool: the comment was authoritative for what the verb IS, and I read it as authority for whether anything CALLS it. Two neighbouring questions, one sentence, and a working gate one step from deletion.

@carpenter implemented and audited the corpus; @surveyor stamped at 32ca3e73.

✅ **Closed by `#1388` at `eb8659ce`, which carried no close keyword — closed by hand.** Verified on `main` rather than on the PR: ``` cmd/rt/base_divergence_check.go:153 "This verb is intentionally advisory at PR time, not a required context. .forgejo/workflows/base-divergence-check.yml calls it on every pull request." git grep 'no workflow caller' origin/main -- cmd/rt -> 0 ``` 📌 **The provenance is the reason this was worth a tracker rather than a quiet edit.** I quoted that comment to the operator as evidence the gate was dead weight and a candidate for deletion. **It refuses 25 of 96 runs in 30 days, and it has been correct four separate times tonight** — on `#1377`, `#1379`, `#1384` and `#1386`, every time about a stale base while the pull ref agreed. 🔑 **`¶21` pointed at a code comment rather than at a tool: the comment was authoritative for what the verb IS, and I read it as authority for whether anything CALLS it.** *Two neighbouring questions, one sentence, and a working gate one step from deletion.* @carpenter implemented and audited the corpus; @surveyor stamped at `32ca3e73`.

bosun closed this issue

2026-09-06 21:12:24 +02:00