frankenbit/release-toolkit

fix(config): enforce supported schema version — reject unknown version:N values #335

New issue

Closed

opened 2026-07-03 13:35:59 +02:00 by bosun · 0 comments

bosun commented

2026-07-03 13:35:59 +02:00

Owner

Finding

config_validate in scripts/lib/config.sh only checks version: is integer. Does NOT require currently-supported schema version. version: 999 passes.

Should-fix rationale

Schema version exists specifically to detect this. Silent acceptance defeats purpose. v1.0.0 needs adopter configs to fail early on unsupported schema, not silent misinterpretation.

Fix

SUPPORTED_SCHEMA_VERSIONS=(1) constant in config.sh
Reject with clear error if version not in supported set
Forward-compatible upgrade path when v2 arrives
Test: v0 (unset), v1 (accepted), v2 (future reject), v999 (reject)

Anchor

External correctness cold-read (anonymous ChatGPT session, uploaded to operator 2026-07-03). Full review surfaced 10 findings across 5 blocking-v1.0.0 + 2 should-fix pre-v1.0.0 + 3 post-v1.0.0 backlog. This tracker addresses one of them.

SHOULD-FIX pre-v1.0.0.

## Finding `config_validate` in `scripts/lib/config.sh` only checks `version:` is integer. Does NOT require currently-supported schema version. `version: 999` passes. ## Should-fix rationale Schema version exists specifically to detect this. Silent acceptance defeats purpose. v1.0.0 needs adopter configs to fail early on unsupported schema, not silent misinterpretation. ## Fix - `SUPPORTED_SCHEMA_VERSIONS=(1)` constant in config.sh - Reject with clear error if version not in supported set - Forward-compatible upgrade path when v2 arrives - Test: v0 (unset), v1 (accepted), v2 (future reject), v999 (reject) ## Anchor External correctness cold-read (anonymous ChatGPT session, uploaded to operator 2026-07-03). Full review surfaced 10 findings across 5 blocking-v1.0.0 + 2 should-fix pre-v1.0.0 + 3 post-v1.0.0 backlog. This tracker addresses one of them. SHOULD-FIX pre-v1.0.0.

bosun added the

labels

2026-07-03 13:35:59 +02:00

quartermaster referenced this issue from a commit

2026-07-03 18:37:54 +02:00

fix(config): enforce SUPPORTED_SCHEMA_VERSIONS in config_validate (#335)

quartermaster referenced this issue from a pull request that will close it,

2026-07-03 18:38:03 +02:00

fix(config): enforce SUPPORTED_SCHEMA_VERSIONS in config_validate (#335) #350

quartermaster referenced this issue from a commit

2026-07-03 18:53:01 +02:00

fix(config): enforce SUPPORTED_SCHEMA_VERSIONS in config_validate (#335)

quartermaster closed this issue

2026-07-03 18:56:34 +02:00

release-bot referenced this issue

2026-07-03 18:58:52 +02:00

chore(release): v0.26.0 #327

bosun referenced this issue

2026-07-25 21:12:03 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle — 4 axes of divergence #529

engineer referenced this issue from a commit

2026-07-25 21:27:40 +02:00

feat(config): implement Loader + Config against #505 interface + C1 schema (#527)

engineer referenced this issue

2026-07-25 21:29:24 +02:00

feat(config): implement Loader + Config against #505 interface + C1 schema (#527) #530

engineer referenced this issue from a commit

2026-07-25 23:26:05 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle

engineer referenced this issue

2026-07-25 23:27:11 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle (#529) #535

engineer referenced this issue from a commit

2026-07-25 23:41:08 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle

bosun referenced this issue

2026-07-25 23:43:51 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle — 4 axes of divergence #529

engineer referenced this issue from a commit

2026-07-26 21:48:40 +02:00

feat(config): implement Loader + Config against #505 interface + C1 schema (#527)

engineer referenced this issue from a commit

2026-07-26 21:48:40 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle

engineer referenced this issue from a commit

2026-07-26 22:12:42 +02:00

feat(config): implement Loader + Config against #505 interface + C1 schema (#527)

engineer referenced this issue from a commit

2026-07-26 22:12:42 +02:00

chore(contracts): reconcile config.schema.json (C1) with config_validate oracle

Sign in to join this conversation.

No labels

priority/critical

priority/medium

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit#335

No description provided.