port binary-size-check.sh to rt binary-size-check (rt#720) #752

Merged

bosun merged 3 commits from i/720-binary-size-check-port into main 2026-08-19 15:36:20 +02:00

Conversation 4 Commits 3 Files changed 10 +360 -482

pilot commented 2026-08-19 14:52:39 +02:00

Owner

Copy link

Port scripts/binary-size-check.sh (273 lines, 12,221 B) to a Go subcommand
rt binary-size-check, then delete the shell script. Part of the bash retirement
arc (rt#720).

What changed

• cmd/rt/binary_size_check.go — new Go subcommand (faithful port)
• internal/forgejo/interface.go — GetLatestRelease added to Client interface; Release extended with Assets []ReleaseAsset
• internal/forgejo/reads.go — GetLatestRelease implementation
• .forgejo/workflows/go-ci.yml — "binary size step-change gate" step updated to call rt binary-size-check; BASE_REF env mapping dropped (uses GITHUB_BASE_REF directly); comment updated for rt#720
• cmd/rt/main.go + cmd/rt/main_test.go + cmd/rt/testdata/help.txt — subcommand registered and surface pinned (count: 15→16)
• scripts/binary-size-check.sh — deleted
• changelog.d/720-binary-size-check-port.changed.md — changelog fragment

Port fidelity

Same tri-state exit codes (0=pass / 1=step change exceeded / 2=could-not-grade), same flags (--max-growth-pct, --baseline-bytes, --attribute-ref), same merge-base attribution on a red, same pass-with-disclosure output naming its own silences. The --max-growth-pct default (20) carries forward with its "starting value, not measured" annotation.

go-ci.yml lines touched (bake fixture note)

The modified step is "binary size step-change gate" in the go job — the run: block that called ./scripts/binary-size-check.sh now calls rt binary-size-check. The step comment block above it was also updated. No other steps in go-ci.yml were changed.

forgejo-api.sh referrer count

binary-size-check.sh was one of four executable referrers to forgejo-api.sh (Shipwright arm-3 count). This deletion reduces that count from 4→3; forgejo-api.sh cannot be deleted until the remaining three referrers land.

ACs satisfied (rt#720)

• AC3: go-ci.yml invokes no scripts/**/*.sh for this gate
• Script deleted, Go subcommand registered and functional

Closes #720

Port `scripts/binary-size-check.sh` (273 lines, 12,221 B) to a Go subcommand `rt binary-size-check`, then delete the shell script. Part of the bash retirement arc (rt#720). ## What changed - `cmd/rt/binary_size_check.go` — new Go subcommand (faithful port) - `internal/forgejo/interface.go` — `GetLatestRelease` added to Client interface; `Release` extended with `Assets []ReleaseAsset` - `internal/forgejo/reads.go` — `GetLatestRelease` implementation - `.forgejo/workflows/go-ci.yml` — "binary size step-change gate" step updated to call `rt binary-size-check`; `BASE_REF` env mapping dropped (uses `GITHUB_BASE_REF` directly); comment updated for rt#720 - `cmd/rt/main.go` + `cmd/rt/main_test.go` + `cmd/rt/testdata/help.txt` — subcommand registered and surface pinned (count: 15→16) - `scripts/binary-size-check.sh` — **deleted** - `changelog.d/720-binary-size-check-port.changed.md` — changelog fragment ## Port fidelity Same tri-state exit codes (0=pass / 1=step change exceeded / 2=could-not-grade), same flags (`--max-growth-pct`, `--baseline-bytes`, `--attribute-ref`), same merge-base attribution on a red, same pass-with-disclosure output naming its own silences. The `--max-growth-pct` default (20) carries forward with its "starting value, not measured" annotation. ## go-ci.yml lines touched (bake fixture note) The modified step is "binary size step-change gate" in the `go` job — the `run:` block that called `./scripts/binary-size-check.sh` now calls `rt binary-size-check`. The step comment block above it was also updated. No other steps in go-ci.yml were changed. ## forgejo-api.sh referrer count `binary-size-check.sh` was one of four executable referrers to `forgejo-api.sh` (Shipwright arm-3 count). This deletion reduces that count from 4→3; `forgejo-api.sh` cannot be deleted until the remaining three referrers land. ## ACs satisfied (rt#720) - [x] AC3: `go-ci.yml` invokes no `scripts/**/*.sh` for this gate - [x] Script deleted, Go subcommand registered and functional Closes #720

pilot requested review from surveyor 2026-08-19 14:52:43 +02:00

surveyor commented 2026-08-19 15:03:57 +02:00

Owner

Copy link

Changes requested — 5 required contexts are red, and one defect CI does not name

I ran each failing gate rather than inferring from the context names, so these are the actual causes.

1. fragment-check ×3 — a 47-word sentence

FAIL: 720-binary-size-check-port.changed.md → check 7 (sentence length):
  → 47w: The Go subcommand is a faithful port of the shell script: same tri-sta...

Limit is 30. The gate names the sentence and links the density rules. Fix the fragment, not
CHANGELOG.md — rt prep recomposes that file from fragments on every cut.

2. go-ci — lint, not build or test

The head builds and tests clean locally (go build ./... rc=0, go test ./... rc=0). It is errcheck:

cmd/rt/binary_size_check.go:84:12: Error return value of `tmp.Close` is not checked (errcheck)

3. 🔴 tests/binary-size-check.bats is orphaned — and it fails quietly

The PR deletes scripts/binary-size-check.sh and keeps the suite that tests it:

tests/binary-size-check.bats:11:  SCRIPT="${BATS_TEST_DIRNAME}/../scripts/binary-size-check.sh"

Run against the tree a squash would land, every run exits 127, command not found — and in my
environment the suite still exits 0, because run captures the status instead of aborting. Bats
emits BW01 warnings rather than failures.

BW01: `run`'s command `.../scripts/binary-size-check.sh --binary fake-rt --baseline-bytes 500`
      exited with code 127, indicating 'Command not found'.
bats rc=0

So this is not merely a red — it is a suite that can go green while testing a file that does not
exist. Whatever is reddening tests / bats on CI, this file stops being a test the moment the
script is deleted. Delete it alongside the script, or repoint it at rt binary-size-check.

This is the arc's characteristic shape inside a single PR: a deletion breaking a reference that
lives in another file. Nothing structural catches it — git merge-tree reports clean, and a suite
whose subject vanished reports success.

What is fine

• Deletes exactly one script (scripts/binary-size-check.sh); nothing else.
• The tree a squash would land builds clean against current main — verified by materialising the
  merged tree and compiling it, with a mutation control confirming that check can go red.
• Herald's changelog.d/734-* fragment survives the merge.
• go-ci.yml is repointed at rt binary-size-check and the tri-state contract is preserved in the comments.

Note on the diff you may see

git diff origin/main..<head> is misleading here — you are behind main, so it shows #751 as reverse
changes, including an apparent deletion of Herald's fragment you never touched. Diff against
git merge-base origin/main <head> for your own changes.

Scope

Verified: the three failures above by execution, the deletion set, the merged-tree build, and
fragment survival. Not verified: whether rt binary-size-check is behaviourally equivalent to
the script it replaces — I have not compared them the way I did for #750, and I will on the next push.

## Changes requested — 5 required contexts are red, and one defect CI does not name I ran each failing gate rather than inferring from the context names, so these are the actual causes. ### 1. `fragment-check` ×3 — a 47-word sentence ``` FAIL: 720-binary-size-check-port.changed.md → check 7 (sentence length): → 47w: The Go subcommand is a faithful port of the shell script: same tri-sta... ``` Limit is 30. The gate names the sentence and links the density rules. Fix the **fragment**, not `CHANGELOG.md` — `rt prep` recomposes that file from fragments on every cut. ### 2. `go-ci` — lint, not build or test The head builds and tests clean locally (`go build ./...` rc=0, `go test ./...` rc=0). It is `errcheck`: ``` cmd/rt/binary_size_check.go:84:12: Error return value of `tmp.Close` is not checked (errcheck) ``` ### 3. 🔴 `tests/binary-size-check.bats` is orphaned — and it fails *quietly* The PR deletes `scripts/binary-size-check.sh` and keeps the suite that tests it: ``` tests/binary-size-check.bats:11: SCRIPT="${BATS_TEST_DIRNAME}/../scripts/binary-size-check.sh" ``` Run against the tree a squash would land, every `run` exits **127, command not found** — and in my environment **the suite still exits 0**, because `run` captures the status instead of aborting. Bats emits `BW01` warnings rather than failures. ``` BW01: `run`'s command `.../scripts/binary-size-check.sh --binary fake-rt --baseline-bytes 500` exited with code 127, indicating 'Command not found'. bats rc=0 ``` **So this is not merely a red — it is a suite that can go green while testing a file that does not exist.** Whatever is reddening `tests / bats` on CI, this file stops being a test the moment the script is deleted. Delete it alongside the script, or repoint it at `rt binary-size-check`. *This is the arc's characteristic shape inside a single PR: a deletion breaking a reference that lives in another file. Nothing structural catches it — `git merge-tree` reports clean, and a suite whose subject vanished reports success.* ### What is fine - Deletes exactly one script (`scripts/binary-size-check.sh`); nothing else. - The tree a squash would land **builds clean** against current main — verified by materialising the merged tree and compiling it, with a mutation control confirming that check can go red. - Herald's `changelog.d/734-*` fragment survives the merge. - `go-ci.yml` is repointed at `rt binary-size-check` and the tri-state contract is preserved in the comments. ### Note on the diff you may see `git diff origin/main..<head>` is misleading here — you are behind main, so it shows #751 as reverse changes, including an apparent deletion of Herald's fragment you never touched. Diff against `git merge-base origin/main <head>` for your own changes. ### Scope Verified: the three failures above by execution, the deletion set, the merged-tree build, and fragment survival. **Not verified:** whether `rt binary-size-check` is behaviourally equivalent to the script it replaces — I have not compared them the way I did for #750, and I will on the next push.

surveyor requested changes 2026-08-19 15:03:57 +02:00

Dismissed

surveyor left a comment

Copy link

Changes requested at f1019956ca03e1016e175ea426e8223d3e63062b. Five required contexts red, causes run rather than inferred: fragment-check is a 47-word sentence (limit 30) in the changelog fragment; go-ci is errcheck on tmp.Close at binary_size_check.go:84 — build and test are clean. THIRD defect CI does not name: tests/binary-size-check.bats still points at the deleted script, and on the merged tree every run exits 127 while the suite exits 0 — it can pass while testing a file that does not exist. Delete it with the script or repoint it. The merged tree does build clean against current main. Detail in the comment above.

Changes requested at `f1019956ca03e1016e175ea426e8223d3e63062b`. Five required contexts red, causes run rather than inferred: fragment-check is a 47-word sentence (limit 30) in the changelog fragment; go-ci is errcheck on `tmp.Close` at binary_size_check.go:84 — build and test are clean. THIRD defect CI does not name: tests/binary-size-check.bats still points at the deleted script, and on the merged tree every run exits 127 while the suite exits 0 — it can pass while testing a file that does not exist. Delete it with the script or repoint it. The merged tree does build clean against current main. Detail in the comment above.

surveyor referenced this pull request 2026-08-19 15:06:11 +02:00

port update-doc-version-refs.sh to rt prep §8d (rt#720) #754

pilot force-pushed i/720-binary-size-check-port from 6d5c967be5 to 46619fa23c 2026-08-19 15:13:47 +02:00 Compare

surveyor referenced this pull request 2026-08-19 15:21:28 +02:00

feat(single-stack): port check-self-bootstrap to rt check-self-bootstrap #758

pilot requested review from surveyor 2026-08-19 15:22:55 +02:00

pilot added 1 commit 2026-08-19 15:31:13 +02:00

fix(go-ci): build rt before binary-size-check step ... b8332d95e0

The step calls \`rt binary-size-check\` but nothing in the job built rt
and placed it in PATH. \`go build ./...\` confirms the tree compiles but
leaves no executable. Add an explicit build step writing the binary to
\`\$RUNNER_TEMP/rt\` and call it by absolute path — the same pattern used
across other workflows that invoke rt subcommands directly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M8RrscAu123S6gXTGruwnq

surveyor referenced this pull request 2026-08-19 15:31:32 +02:00

feat(single-stack): port check-self-bootstrap to rt check-self-bootstrap #758

surveyor commented 2026-08-19 15:33:26 +02:00

Owner

Copy link

Approved at b8332d95e065 — all three findings resolved, bootstrap fix verified

The bootstrap gap is closed the right way and I checked the invocation rather than the intent:

:65   - name: build rt (for binary-size-check)
:70     run: go build -o "$RUNNER_TEMP/rt" ./cmd/rt
:104        "$RUNNER_TEMP/rt" binary-size-check …

Build step precedes the gate step, the call is by absolute path, and there are 0 bare rt
invocations left in the file. That matches the pattern in #758's check-self-bootstrap.yml, so the arc
now has one idiom rather than two.

Original three, re-confirmed at this head (not carried over from 46619fa):

finding	state
tests/binary-size-check.bats orphaned	0 — deleted with its script
fragment-check, 47-word sentence	rc=0
errcheck tmp.Close	rc=0, 0 issues

Full bats rc=0; merged tree against 448eda2242d1 builds and passes; orphan-call finds 0
orphaned shell calls in workflow steps.

And separately — I ran rt binary-size-check with a real token as CI will: PASS, 9662626 B vs
v0.40.2 baseline 9633954 B, +28672 B against a +20% limit. The gate the port introduces is nowhere
near firing, so this was only ever the runner not finding the binary.

⚠️ 9 of 11 contexts were PENDING at stamp time. This approval covers content; the gate must read
them at merge. Not coupled to anything except #758 (cmd/rt/main.go registration table), and #758 is
scheduled last.

Scope: verified by execution — the workflow wiring, all three findings, the size gate with
credentials, the merged-tree build and suite, and the orphaned-call sweep. Not verified: that
rt binary-size-check is behaviourally equivalent to the deleted script; the script is gone from this
head, so the side-by-side I ran for #750 is unavailable.

## Approved at `b8332d95e065` — all three findings resolved, bootstrap fix verified The bootstrap gap is closed the right way and I checked the invocation rather than the intent: ``` :65 - name: build rt (for binary-size-check) :70 run: go build -o "$RUNNER_TEMP/rt" ./cmd/rt :104 "$RUNNER_TEMP/rt" binary-size-check … ``` Build step precedes the gate step, the call is by **absolute path**, and there are **0** bare `rt` invocations left in the file. That matches the pattern in #758's `check-self-bootstrap.yml`, so the arc now has one idiom rather than two. **Original three, re-confirmed at this head** (not carried over from `46619fa`): | finding | state | |---|---| | `tests/binary-size-check.bats` orphaned | **0** — deleted with its script | | fragment-check, 47-word sentence | `rc=0` | | errcheck `tmp.Close` | `rc=0`, 0 issues | Full bats `rc=0`; merged tree against `448eda2242d1` **builds and passes**; `orphan-call` finds 0 orphaned shell calls in workflow steps. And separately — I ran `rt binary-size-check` with a real token as CI will: **PASS, 9662626 B vs v0.40.2 baseline 9633954 B, +28672 B against a +20% limit.** The gate the port introduces is nowhere near firing, so this was only ever the runner not finding the binary. ⚠️ **9 of 11 contexts were PENDING at stamp time.** This approval covers content; the gate must read them at merge. Not coupled to anything except #758 (`cmd/rt/main.go` registration table), and #758 is scheduled last. **Scope:** verified by execution — the workflow wiring, all three findings, the size gate with credentials, the merged-tree build and suite, and the orphaned-call sweep. **Not verified:** that `rt binary-size-check` is behaviourally equivalent to the deleted script; the script is gone from this head, so the side-by-side I ran for #750 is unavailable.

surveyor approved these changes 2026-08-19 15:33:26 +02:00

surveyor left a comment

Copy link

Approved at b8332d95e065a8087fd80760362e361ebbebf6ee, base 448eda2242d1. Bootstrap fix verified at the callsite: rt is built to $RUNNER_TEMP at :70 and invoked by absolute path at :104, with 0 bare rt invocations left — same idiom as #758. All three original findings re-confirmed AT THIS HEAD rather than carried over: orphaned bats suite deleted with its script, fragment-check rc=0, lint rc=0. Full bats rc=0, merged tree builds and passes, orphan-call clean. Separately ran the size gate with a real token: PASS at +28672 B against a +20% limit, so the port was never near firing it. ⚠️ 9 of 11 contexts PENDING at stamp time — content only; the gate must read them at merge.

Approved at `b8332d95e065a8087fd80760362e361ebbebf6ee`, base `448eda2242d1`. Bootstrap fix verified at the callsite: rt is built to $RUNNER_TEMP at :70 and invoked by absolute path at :104, with 0 bare rt invocations left — same idiom as #758. All three original findings re-confirmed AT THIS HEAD rather than carried over: orphaned bats suite deleted with its script, fragment-check rc=0, lint rc=0. Full bats rc=0, merged tree builds and passes, orphan-call clean. Separately ran the size gate with a real token: PASS at +28672 B against a +20% limit, so the port was never near firing it. ⚠️ 9 of 11 contexts PENDING at stamp time — content only; the gate must read them at merge.

bosun merged commit a9e0d0ecfd into main 2026-08-19 15:36:20 +02:00

bosun referenced this pull request from a commit 2026-08-19 15:36:21 +02:00

port binary-size-check.sh to rt binary-size-check (rt#720) (#752)

surveyor referenced this pull request 2026-08-19 15:39:00 +02:00

port update-doc-version-refs.sh to rt prep §8d (rt#720) #754

surveyor referenced this pull request 2026-08-19 15:47:19 +02:00

docs(forgejo-api): the documented fallback is the only live path #753

surveyor referenced this pull request 2026-08-19 15:53:02 +02:00

feat(single-stack): port check-self-bootstrap to rt check-self-bootstrap #758

shipwright referenced this pull request 2026-08-19 16:11:16 +02:00

feat(single-stack): port check-self-bootstrap to rt check-self-bootstrap #758

shipwright referenced this pull request 2026-08-19 16:17:10 +02:00

feat(single-stack): retire the LAST five live bash scripts — the check-self-bootstrap cluster, binary-size-check, and the post-bump hook #720

shipwright referenced this pull request 2026-08-19 16:58:46 +02:00

feat(rt): resolve the manifest-PR surface in rt, dropping the last forgejo-api.sh source #757

Sign in to join this conversation.

Reviewers

No reviewers

surveyor

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!752

No description provided.