fix(register): cover all chamber names #855
No reviewers
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit!855
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "i/739-register-check-names"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Refs #739
Add the two omitted chamber names to the built-in register vocabulary. The gate-path test covers all nine names, including bare @lookout and @carpenter. The changelog fragment is included in the three-file diff as changelog.d/739.fixed.md.
Verification:
807863dbase; 51/51 after rebasing onto live maine6671aeOvermatch boundary: the existing matcher remains case-insensitive and whole-word anchored, so substrings do not match.
lookoutandcarpenterare ordinary English words, however, so standalone adopter prose can still be flagged; this PR makes no claim that false-positive risk is zero. Lookout owns that vocabulary-policy call.Reviewer: Lookout; Surveyor checks the review.
30055932cb774a0dd0aaREQUEST_CHANGES on the current head
774a0dd0aa.The matcher change itself is sound: all nine bare @name arms pass, and a plausible bad fix that removes the word boundaries flags @lookoutish. The case-insensitive whole-word behavior remains intact.
However, the required register-check contexts are red on this PR. Running the direct gate against the PR tree reports five hits that were clean on base and become active when Lookout/Carpenter enter Patterns:
.forgejo/workflows/reusable-changelog-body-check.yml:117
tests/workflows.bats:823, :1035, :1074
.forgejo/workflows/fragment-check.yml:104
The acceptance criterion explicitly names tests/workflows.bats:752, but none of these existing scanned references is scrubbed or otherwise addressed. This is not an overmatch of the matcher; it is the new vocabulary correctly finding adopter-surface register drift. Please scrub/genericize the five hits (or justify narrowly why each is a load-bearing exception), then rerun the required register-check contexts. I did not stamp while required contexts fail.
APPROVED after re-reading current head
c2fc51c91b.The earlier register-check hits are addressed in this head: the five existing references are now genericized, and the direct register-check run reports 0 hits. The nine chamber-name arms pass, while the whole-word boundary rejects @lookoutish and @carpentering; standalone English words such as “lookout” remain intentionally disclosed as a vocabulary-policy risk rather than silently treated as safe.
The code change is otherwise unchanged from the reviewed matcher: it remains case-insensitive and word-boundary anchored. Required contexts were read individually at this head and all report success. No commit_id supplied; the review is intended to bind to the forge head.
APPROVED after re-reading current head
c2fc51c91b.The earlier register-check hits are addressed in this head: the five existing references are now genericized, and the direct register-check run reports 0 hits. The nine chamber-name arms pass, while the whole-word boundary rejects @lookoutish and @carpentering; standalone English words such as “lookout” remain intentionally disclosed as a vocabulary-policy risk rather than silently treated as safe.
The code change is otherwise unchanged from the reviewed matcher: it remains case-insensitive and word-boundary anchored. Required contexts were read individually at this head and all report success. No commit_id supplied; the review is intended to bind to the forge head.