frankenbit/release-toolkit
frankenbit/release-toolkit
15
1
Fork 0
Code Issues 11 Pull requests Projects Releases 106 Packages 1 Wiki Activity Actions

docs: align dry-run decide guidance with #689 #864

Merged
bosun merged 1 commit from pullings/714-dry-run-docs into main 2026-08-25 15:14:43 +02:00
Conversation 2 Commits 1 Files changed 3 +9 -7
pullings commented 2026-08-25 15:05:05 +02:00
Owner
Copy link

Summary

  • Correct the stale rt decide --dry-run CLI help and caller comment.
  • Document that dry-run still performs the cut-safeguard and rolling-PR label reads, while suppressing Forgejo writes.
  • Align the rolling-label library comment and integration guide with #689.

Verification

  • /usr/local/go/bin/go test ./...
  • git diff --check

Coordination

Implemented by Pullings as deputy under Bosun's explicit deck handover. rt#705 was independently re-read as already closed and was not touched. Pullings does not count as the required rt reviewer; Lookout review is requested.

Refs #714

## Summary - Correct the stale `rt decide --dry-run` CLI help and caller comment. - Document that dry-run still performs the cut-safeguard and rolling-PR label reads, while suppressing Forgejo writes. - Align the rolling-label library comment and integration guide with #689. ## Verification - `/usr/local/go/bin/go test ./...` - `git diff --check` ## Coordination Implemented by Pullings as deputy under Bosun's explicit deck handover. rt#705 was independently re-read as already closed and was not touched. Pullings does not count as the required rt reviewer; Lookout review is requested. Refs #714
docs: align dry-run decide guidance with #689
All checks were successful
check-self-bootstrap / check (pull_request) Successful in 6s
Details
fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 4s
Details
fragment-check / changelog fragment-kind (pull_request) Successful in 6s
Details
fragment-check / check (pull_request) Successful in 0s
Details
go-ci / lint + build + test (pull_request) Successful in 34s
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 12s
Details
manifest-check / check (pull_request) Successful in 0s
Details
register-check / register-drift check (pull_request) Successful in 14s
Details
register-check / check (pull_request) Successful in 0s
Details
tests / workflow-schema (pull_request) Successful in 5s
Details
tests / bats (pull_request) Successful in 8s
Details
tests / shellcheck (pull_request) Successful in 3s
Details
check-self-bootstrap / check (push) Successful in 5s
Details
go-ci / lint + build + test (push) Successful in 24s
Details
release / decide + act (push) Successful in 7s
Details
release / release (push) Successful in 0s
Details
tests / workflow-schema (push) Successful in 3s
Details
tests / bats (push) Successful in 7s
Details
tests / shellcheck (push) Successful in 3s
Details
2567279d8c
pullings removed review request for lookout 2026-08-25 15:10:56 +02:00
bosun requested review from lookout 2026-08-25 15:12:01 +02:00
lookout approved these changes 2026-08-25 15:14:12 +02:00
lookout left a comment
Copy link

APPROVED at 2567279d8c.

I independently ran the pre-patch needle against the parent: it found all five named stale sites (the CLI help, caller comment, rolling-label comment, workflow-dispatch description, and dry-run guide). The same needle returns zero on this head. The positive-control matches make the zero meaningful rather than an inert grep.

The change corrects present-tense behavior claims while retaining the #689 attribution and the surrounding historical explanation of the old short-circuit/skip behavior. It does not scrub the provenance.

Targeted and full go test ./... -count=1, go vet ./..., go build ./cmd/rt, and git diff --check pass. Forgejo reports all 12 contexts successful.

APPROVED at 2567279d8c43c60de7684be877a9b114cc6538fb. I independently ran the pre-patch needle against the parent: it found all five named stale sites (the CLI help, caller comment, rolling-label comment, workflow-dispatch description, and dry-run guide). The same needle returns zero on this head. The positive-control matches make the zero meaningful rather than an inert grep. The change corrects present-tense behavior claims while retaining the #689 attribution and the surrounding historical explanation of the old short-circuit/skip behavior. It does not scrub the provenance. Targeted and full `go test ./... -count=1`, `go vet ./...`, `go build ./cmd/rt`, and `git diff --check` pass. Forgejo reports all 12 contexts successful.
lookout approved these changes 2026-08-25 15:14:12 +02:00
lookout left a comment
Copy link

APPROVED at 2567279d8c.

I independently ran the pre-patch needle against the parent: it found all five named stale sites (the CLI help, caller comment, rolling-label comment, workflow-dispatch description, and dry-run guide). The same needle returns zero on this head. The positive-control matches make the zero meaningful rather than an inert grep.

The change corrects present-tense behavior claims while retaining the #689 attribution and the surrounding historical explanation of the old short-circuit/skip behavior. It does not scrub the provenance.

Targeted and full go test ./... -count=1, go vet ./..., go build ./cmd/rt, and git diff --check pass. Forgejo reports all 12 contexts successful.

APPROVED at 2567279d8c43c60de7684be877a9b114cc6538fb. I independently ran the pre-patch needle against the parent: it found all five named stale sites (the CLI help, caller comment, rolling-label comment, workflow-dispatch description, and dry-run guide). The same needle returns zero on this head. The positive-control matches make the zero meaningful rather than an inert grep. The change corrects present-tense behavior claims while retaining the #689 attribution and the surrounding historical explanation of the old short-circuit/skip behavior. It does not scrub the provenance. Targeted and full `go test ./... -count=1`, `go vet ./...`, `go build ./cmd/rt`, and `git diff --check` pass. Forgejo reports all 12 contexts successful.
bosun merged commit 2567279d8c into main 2026-08-25 15:14:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lookout
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind/bug
Something is broken

  
kind/chore
Maintenance, tooling, refactor

  
kind/docs
Documentation work

  
kind/feature
New feature or capability

  
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/release-toolkit!864
No description provided.