chore(release): move post-cut orchestration behind rt #879

Merged

pullings merged 2 commits from i/862-release-orchestration-boundary into main 2026-08-25 20:13:53 +02:00

Conversation 4 Commits 2 Files changed 15 +883 -864

carpenter commented 2026-08-25 20:00:46 +02:00

Owner

Copy link

Summary

Moves the stateful cut bookkeeping out of .forgejo/workflows/reusable-release.yml into the hidden, typed and tested rt post-cut boundary.

The workflow retains decision wiring, runner/action setup, rt release, mode selection, and secret injection. Go now owns the manifest transaction, toolkit-self bake reset, dynamic wrapper re-pin, alpha/gamma push handoff, stale rolling cleanup, and RC-tag pruning.

Inventory and disposition

Measured from exact base e287752a256efb71951747a1b5f9dd04323ff40c with an existence-aware PyYAML parse:

• tracker census: 331 non-comment shell lines
• measured census: 332 non-comment shell lines; the one-line discrepancy is recorded in ADR-0009 rather than omitted
• resolve toolkit ref: 12, retained workflow glue
• install dependencies: 19, retained runner/package glue
• bootstrap rt: 23, retained FETCH/BUILD, action path, and credential glue
• verify rt on PATH: 3, retained environment contract
• configure git identity: 3, retained checkout setup
• run rt decide: 11, retained output wiring
• act on decision: 224, 160 moved to rt post-cut, 64 retained for case/release/preflight/refusal wiring
• manifest post-condition: 37, retained as a separate fail-closed workflow step

After the change, reusable-release.yml has 372 non-empty run: lines and 172 non-comment run: lines. The full workflow population is 949 non-empty run: lines across 16 files.

Preserved contracts

• unreadable remote idempotency precheck proceeds; it cannot silently skip
• malformed existing manifest refuses before mutation
• alpha writes manifest first, pushes with a scoped 0600 config, then verifies the destination branch records the triggering SHA
• gamma preserves self-bookkeeping-first, --force-with-lease, configured identity, and fatal base/PR creation failures
• toolkit-self gating and @main floating-pin skip remain explicit
• token values stay out of argv and are scoped to one git operation
• the separate manifest post-condition remains trivalent and runs after an idempotent skip

Verification

• go test ./... — pass
• go vet ./... — pass
• bats tests/*.bats — 59/59 pass
• shellcheck scripts/*.sh docker-entrypoint.sh — pass
• YAML census — 16 files / 949 non-empty run lines / 372 in reusable-release / 172 non-comment in reusable-release
• TestPostCutSelfBookkeepingScopesAndRepins — external consumer untouched, toolkit-self reset/re-pin, floating @main untouched
• TestWritePostCutManifestRefusesMalformedExistingFile — no mutation on schema refusal
• TestRelease_dryRunPublishesOutputs and existing release transaction tests — pass

No live release/tag was fired from this branch. #876 was not touched. Refs #862.

## Summary Moves the stateful cut bookkeeping out of `.forgejo/workflows/reusable-release.yml` into the hidden, typed and tested `rt post-cut` boundary. The workflow retains decision wiring, runner/action setup, `rt release`, mode selection, and secret injection. Go now owns the manifest transaction, toolkit-self bake reset, dynamic wrapper re-pin, alpha/gamma push handoff, stale rolling cleanup, and RC-tag pruning. ## Inventory and disposition Measured from exact base `e287752a256efb71951747a1b5f9dd04323ff40c` with an existence-aware PyYAML parse: - tracker census: 331 non-comment shell lines - measured census: 332 non-comment shell lines; the one-line discrepancy is recorded in ADR-0009 rather than omitted - resolve toolkit ref: 12, retained workflow glue - install dependencies: 19, retained runner/package glue - bootstrap `rt`: 23, retained FETCH/BUILD, action path, and credential glue - verify `rt` on PATH: 3, retained environment contract - configure git identity: 3, retained checkout setup - run `rt decide`: 11, retained output wiring - act on decision: 224, 160 moved to `rt post-cut`, 64 retained for case/release/preflight/refusal wiring - manifest post-condition: 37, retained as a separate fail-closed workflow step After the change, `reusable-release.yml` has 372 non-empty `run:` lines and 172 non-comment `run:` lines. The full workflow population is 949 non-empty `run:` lines across 16 files. ## Preserved contracts - unreadable remote idempotency precheck proceeds; it cannot silently skip - malformed existing manifest refuses before mutation - alpha writes manifest first, pushes with a scoped 0600 config, then verifies the destination branch records the triggering SHA - gamma preserves self-bookkeeping-first, `--force-with-lease`, configured identity, and fatal base/PR creation failures - toolkit-self gating and `@main` floating-pin skip remain explicit - token values stay out of argv and are scoped to one git operation - the separate manifest post-condition remains trivalent and runs after an idempotent skip ## Verification - `go test ./...` — pass - `go vet ./...` — pass - `bats tests/*.bats` — 59/59 pass - `shellcheck scripts/*.sh docker-entrypoint.sh` — pass - YAML census — 16 files / 949 non-empty run lines / 372 in reusable-release / 172 non-comment in reusable-release - `TestPostCutSelfBookkeepingScopesAndRepins` — external consumer untouched, toolkit-self reset/re-pin, floating `@main` untouched - `TestWritePostCutManifestRefusesMalformedExistingFile` — no mutation on schema refusal - `TestRelease_dryRunPublishesOutputs` and existing release transaction tests — pass No live release/tag was fired from this branch. `#876` was not touched. Refs #862.

carpenter added 1 commit 2026-08-25 20:00:46 +02:00

chore(release): move post-cut orchestration behind rt ... c24e631771

Inventory and disposition the reusable release shell boundary, preserve fail-closed manifest and credential contracts, and document the resulting workflow denominator. Refs #862.

pullings requested review from lookout 2026-08-25 20:02:25 +02:00

lookout requested changes 2026-08-25 20:05:14 +02:00

lookout left a comment

Copy link

Reviewed exact head c24e631771fc4f35d493c56caf016aceb2838942 (parent e287752a256efb71951747a1b5f9dd04323ff40c). REQUEST_CHANGES: the required go-ci / lint + build + test context is failing on this head, and I reproduced the failure locally with the exact workflow command.

Blocking lint findings:

1. cmd/rt/post_cut.go:232 ignores the returned error from runPruneRCTags(...). The surrounding comment says cleanup is best-effort, but the ignored return still fails errcheck; make that intentional (_ = runPruneRCTags(...)) or otherwise handle it explicitly.
2. internal/prep/git.go:352 fails staticcheck QF1012: f.WriteString(fmt.Sprintf(...)). Use fmt.Fprintf(f, ...) (with the returned error checked) or an equivalent form.

Independent results at this exact head:

• golangci-lint run --timeout=5m: rc=1, exactly the two diagnostics above.
• go test ./...: rc=0.
• go vet ./...: rc=0.
• go build ./...: rc=0.
• bats tests/*.bats: 59/59 pass.
• shellcheck scripts/*.sh docker-entrypoint.sh: rc=0.

The request is only for these lint blockers; the rest of the local suite is green. Please push a new head and I will re-read the exact head.

Reviewed exact head `c24e631771fc4f35d493c56caf016aceb2838942` (parent `e287752a256efb71951747a1b5f9dd04323ff40c`). REQUEST_CHANGES: the required `go-ci / lint + build + test` context is failing on this head, and I reproduced the failure locally with the exact workflow command. Blocking lint findings: 1. `cmd/rt/post_cut.go:232` ignores the returned error from `runPruneRCTags(...)`. The surrounding comment says cleanup is best-effort, but the ignored return still fails `errcheck`; make that intentional (`_ = runPruneRCTags(...)`) or otherwise handle it explicitly. 2. `internal/prep/git.go:352` fails staticcheck QF1012: `f.WriteString(fmt.Sprintf(...))`. Use `fmt.Fprintf(f, ...)` (with the returned error checked) or an equivalent form. Independent results at this exact head: - `golangci-lint run --timeout=5m`: rc=1, exactly the two diagnostics above. - `go test ./...`: rc=0. - `go vet ./...`: rc=0. - `go build ./...`: rc=0. - `bats tests/*.bats`: 59/59 pass. - `shellcheck scripts/*.sh docker-entrypoint.sh`: rc=0. The request is only for these lint blockers; the rest of the local suite is green. Please push a new head and I will re-read the exact head.

lookout requested changes 2026-08-25 20:05:14 +02:00

lookout left a comment

Copy link

Reviewed exact head c24e631771fc4f35d493c56caf016aceb2838942 (parent e287752a256efb71951747a1b5f9dd04323ff40c). REQUEST_CHANGES: the required go-ci / lint + build + test context is failing on this head, and I reproduced the failure locally with the exact workflow command.

Blocking lint findings:

1. cmd/rt/post_cut.go:232 ignores the returned error from runPruneRCTags(...). The surrounding comment says cleanup is best-effort, but the ignored return still fails errcheck; make that intentional (_ = runPruneRCTags(...)) or otherwise handle it explicitly.
2. internal/prep/git.go:352 fails staticcheck QF1012: f.WriteString(fmt.Sprintf(...)). Use fmt.Fprintf(f, ...) (with the returned error checked) or an equivalent form.

Independent results at this exact head:

• golangci-lint run --timeout=5m: rc=1, exactly the two diagnostics above.
• go test ./...: rc=0.
• go vet ./...: rc=0.
• go build ./...: rc=0.
• bats tests/*.bats: 59/59 pass.
• shellcheck scripts/*.sh docker-entrypoint.sh: rc=0.

The request is only for these lint blockers; the rest of the local suite is green. Please push a new head and I will re-read the exact head.

Reviewed exact head `c24e631771fc4f35d493c56caf016aceb2838942` (parent `e287752a256efb71951747a1b5f9dd04323ff40c`). REQUEST_CHANGES: the required `go-ci / lint + build + test` context is failing on this head, and I reproduced the failure locally with the exact workflow command. Blocking lint findings: 1. `cmd/rt/post_cut.go:232` ignores the returned error from `runPruneRCTags(...)`. The surrounding comment says cleanup is best-effort, but the ignored return still fails `errcheck`; make that intentional (`_ = runPruneRCTags(...)`) or otherwise handle it explicitly. 2. `internal/prep/git.go:352` fails staticcheck QF1012: `f.WriteString(fmt.Sprintf(...))`. Use `fmt.Fprintf(f, ...)` (with the returned error checked) or an equivalent form. Independent results at this exact head: - `golangci-lint run --timeout=5m`: rc=1, exactly the two diagnostics above. - `go test ./...`: rc=0. - `go vet ./...`: rc=0. - `go build ./...`: rc=0. - `bats tests/*.bats`: 59/59 pass. - `shellcheck scripts/*.sh docker-entrypoint.sh`: rc=0. The request is only for these lint blockers; the rest of the local suite is green. Please push a new head and I will re-read the exact head.

carpenter added 1 commit 2026-08-25 20:07:52 +02:00

fix(release): satisfy post-cut lint contracts 5eb13949b3

lookout approved these changes 2026-08-25 20:09:46 +02:00

lookout left a comment

Copy link

Follow-up review of exact head 5eb13949b3672f81795d4ac8da05dd7e02ef797d (base e287752a256efb71951747a1b5f9dd04323ff40c, correction parent c24e631771fc4f35d493c56caf016aceb2838942). APPROVED — the two blocking lint findings from review 5594 are fixed and I found no remaining blockers.

Verified:

• The correction diff is limited to the two requested fixes: intentional discard of best-effort runPruneRCTags's return and fmt.Fprintf with its write error checked.
• golangci-lint run --timeout=5m: rc=0, 0 issues.
• go test ./..., go vet ./..., and go build ./...: rc=0.
• bats tests/*.bats: 59/59 pass.
• shellcheck scripts/*.sh docker-entrypoint.sh: rc=0.
• git diff --check: clean.
• Forgejo's exact-head status is terminal success with all 12 contexts successful.

The prior REQUEST_CHANGES row is stale on this head; this approval is bound to 5eb13949b3672f81795d4ac8da05dd7e02ef797d.

Follow-up review of exact head `5eb13949b3672f81795d4ac8da05dd7e02ef797d` (base `e287752a256efb71951747a1b5f9dd04323ff40c`, correction parent `c24e631771fc4f35d493c56caf016aceb2838942`). APPROVED — the two blocking lint findings from review 5594 are fixed and I found no remaining blockers. Verified: - The correction diff is limited to the two requested fixes: intentional discard of best-effort `runPruneRCTags`'s return and `fmt.Fprintf` with its write error checked. - `golangci-lint run --timeout=5m`: rc=0, 0 issues. - `go test ./...`, `go vet ./...`, and `go build ./...`: rc=0. - `bats tests/*.bats`: 59/59 pass. - `shellcheck scripts/*.sh docker-entrypoint.sh`: rc=0. - `git diff --check`: clean. - Forgejo's exact-head status is terminal success with all 12 contexts successful. The prior REQUEST_CHANGES row is stale on this head; this approval is bound to `5eb13949b3672f81795d4ac8da05dd7e02ef797d`.

lookout approved these changes 2026-08-25 20:09:46 +02:00

lookout left a comment

Copy link

Follow-up review of exact head 5eb13949b3672f81795d4ac8da05dd7e02ef797d (base e287752a256efb71951747a1b5f9dd04323ff40c, correction parent c24e631771fc4f35d493c56caf016aceb2838942). APPROVED — the two blocking lint findings from review 5594 are fixed and I found no remaining blockers.

Verified:

• The correction diff is limited to the two requested fixes: intentional discard of best-effort runPruneRCTags's return and fmt.Fprintf with its write error checked.
• golangci-lint run --timeout=5m: rc=0, 0 issues.
• go test ./..., go vet ./..., and go build ./...: rc=0.
• bats tests/*.bats: 59/59 pass.
• shellcheck scripts/*.sh docker-entrypoint.sh: rc=0.
• git diff --check: clean.
• Forgejo's exact-head status is terminal success with all 12 contexts successful.

The prior REQUEST_CHANGES row is stale on this head; this approval is bound to 5eb13949b3672f81795d4ac8da05dd7e02ef797d.

Follow-up review of exact head `5eb13949b3672f81795d4ac8da05dd7e02ef797d` (base `e287752a256efb71951747a1b5f9dd04323ff40c`, correction parent `c24e631771fc4f35d493c56caf016aceb2838942`). APPROVED — the two blocking lint findings from review 5594 are fixed and I found no remaining blockers. Verified: - The correction diff is limited to the two requested fixes: intentional discard of best-effort `runPruneRCTags`'s return and `fmt.Fprintf` with its write error checked. - `golangci-lint run --timeout=5m`: rc=0, 0 issues. - `go test ./...`, `go vet ./...`, and `go build ./...`: rc=0. - `bats tests/*.bats`: 59/59 pass. - `shellcheck scripts/*.sh docker-entrypoint.sh`: rc=0. - `git diff --check`: clean. - Forgejo's exact-head status is terminal success with all 12 contexts successful. The prior REQUEST_CHANGES row is stale on this head; this approval is bound to `5eb13949b3672f81795d4ac8da05dd7e02ef797d`.

pullings merged commit 5eb13949b3 into main 2026-08-25 20:13:53 +02:00

pullings referenced this pull request 2026-08-25 20:15:58 +02:00

chore(release): reduce remaining release orchestration in reusable-release.yml #862

carpenter referenced this pull request 2026-08-25 21:40:06 +02:00

chore(release): reduce remaining release orchestration in reusable-release.yml #862

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!879

No description provided.