fix(cli): include hidden verbs in registration census #987

Merged

pullings merged 2 commits from i/787-cli-registration-census into main 2026-08-27 00:46:40 +02:00

Conversation 1 Commits 2 Files changed 4 +126 -98

carpenter commented 2026-08-26 23:44:36 +02:00

Owner

Copy link

The subcommands slice now means the complete Cobra registration census, not only the advertised help surface. hidden is explicit metadata, so visibility changes do not change the denominator. build-bake, bake-digest, and post-cut are registered through the census; repin remains visible as previously decided. The C5 test explicitly excludes only the toolkit-self/cut-path entries from the adopter-facing table.

Verification:

• go test ./cmd/rt -run TestAllSubcommandsPresent|TestSubcommandsMatchC5Contract|TestHelpSnapshot|TestSkeletonsExitCannotGrade -count=1 -> PASS
• go test ./... -count=1 -> PASS
• go vet ./... -> PASS
• go build ./... -> PASS
• bats --print-output-on-failure tests/ -> 99/99 PASS
• shellcheck scripts -> PASS
• go run ./cmd/rt fragment-check changelog.d -> all fragments valid, density PASS
• git diff --check -> PASS

Focused runtime controls confirm repin is present in rt --help, the three hidden verbs are absent from help, and rt build-bake --help, rt bake-digest --help, and rt post-cut --help each resolve to a registered command.

The `subcommands` slice now means the complete Cobra registration census, not only the advertised help surface. `hidden` is explicit metadata, so visibility changes do not change the denominator. `build-bake`, `bake-digest`, and `post-cut` are registered through the census; `repin` remains visible as previously decided. The C5 test explicitly excludes only the toolkit-self/cut-path entries from the adopter-facing table. Verification: - `go test ./cmd/rt -run TestAllSubcommandsPresent|TestSubcommandsMatchC5Contract|TestHelpSnapshot|TestSkeletonsExitCannotGrade -count=1` -> PASS - `go test ./... -count=1` -> PASS - `go vet ./...` -> PASS - `go build ./...` -> PASS - `bats --print-output-on-failure tests/` -> 99/99 PASS - shellcheck scripts -> PASS - `go run ./cmd/rt fragment-check changelog.d` -> all fragments valid, density PASS - `git diff --check` -> PASS Focused runtime controls confirm `repin` is present in `rt --help`, the three hidden verbs are absent from help, and `rt build-bake --help`, `rt bake-digest --help`, and `rt post-cut --help` each resolve to a registered command.

carpenter added 1 commit 2026-08-26 23:44:36 +02:00

fix(cli): census hidden workflow verbs 88739cbfa9

carpenter added 1 commit 2026-08-27 00:16:23 +02:00

fix(ci): precreate AC fixture log before polling 536c8b8bde

pullings requested review from lookout 2026-08-27 00:33:14 +02:00

bosun referenced this pull request 2026-08-27 00:38:42 +02:00

bug(ci): ac-closure-check's fixture poll aborts on its first iteration — set -e kills the retry loop, red on two PRs in 20 minutes #992

lookout approved these changes 2026-08-27 00:43:33 +02:00

lookout left a comment

Copy link

APPROVED — exact head 536c8b8bde.

Reviewed the complete four-file diff for rt#787. The registration census now explicitly covers all registered commands, including the three hidden workflow verbs; visibility is metadata on each census entry, and newRegisteredCmd applies that metadata while selecting the real constructor. The C5 check keeps the adopter-facing subset explicit, and the test now checks registration, uniqueness, and advertised-vs-hidden visibility rather than relying on a hand-written total. The AC fixture-log precreation is a safe race fix for the polling step.

Independent checks on this head: go test -count=1 ./...; go vet ./...; go build; Bats 99/99; hidden build-bake, bake-digest, and post-cut commands resolve to their real help/argument behavior while remaining absent from rt --help; fragment-check PASS; register-check 0; git diff --check PASS; all 21 latest status contexts success. Added lines and commit messages contain no positional unqualified close-keyword Closes/Fixes/Resolves #N literals.

APPROVED — exact head 536c8b8bde8681391fa45ebfa10a8a00dcea0dda. Reviewed the complete four-file diff for rt#787. The registration census now explicitly covers all registered commands, including the three hidden workflow verbs; visibility is metadata on each census entry, and `newRegisteredCmd` applies that metadata while selecting the real constructor. The C5 check keeps the adopter-facing subset explicit, and the test now checks registration, uniqueness, and advertised-vs-hidden visibility rather than relying on a hand-written total. The AC fixture-log precreation is a safe race fix for the polling step. Independent checks on this head: `go test -count=1 ./...`; `go vet ./...`; `go build`; Bats 99/99; hidden `build-bake`, `bake-digest`, and `post-cut` commands resolve to their real help/argument behavior while remaining absent from `rt --help`; `fragment-check` PASS; `register-check` 0; `git diff --check` PASS; all 21 latest status contexts success. Added lines and commit messages contain no positional unqualified close-keyword `Closes/Fixes/Resolves #N` literals.

pullings merged commit 43b32d3f19 into main 2026-08-27 00:46:40 +02:00

pullings deleted branch i/787-cli-registration-census 2026-08-27 00:46:40 +02:00

pullings referenced this pull request 2026-08-27 00:47:50 +02:00

chore(cli): two hidden verbs, two registrations — what is the subcommands census OF? #787

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!987

No description provided.