test(pager): pin shell lookup_pr refusals #1359

Merged

bosun merged 1 commit from i/1301-shell-lookup-controls into main 2026-09-06 17:45:13 +02:00

Conversation 2 Commits 1 Files changed 2 +30 -2

carpenter commented 2026-09-06 17:32:26 +02:00

Owner

Copy link

Scope

Adds the two missing executable controls to the shell lookup_pr used by scripts/post-merge-build-page.sh:

• transport failure refuses before any pager comment;
• HTTP 200 without a numeric PR object refuses before any pager comment.

The existing non-2xx control and 404/no-PR fallback remain unchanged. Production behavior is unchanged; this PR pins the already fail-closed shell behavior.

AC evidence

• Transport failure arm asserts nonzero status, the named could not read PR diagnostic, and no comment capture.
• Malformed 200 arm asserts nonzero status, the named object/number diagnostic, and no comment capture.
• Each arm reddens under its own applied mutation; results are recorded below.

Independent mutation evidence

• Transport refusal block mutated to print {} and return success: applied=1; targeted transport arm failed because the pager returned success (rc=1).
• HTTP 200 shape check removed: applied=1; targeted malformed-200 arm failed because the pager returned success (rc=1).

Verification

• Base: 4a6e8a0c26f57326767d49d8653c4f53898d4058
• Head: d11a183c71576bb3e752368b56fb4f2eebad36ab
• bats tests/post-merge-build-page.bats: 1..6, all pass
• bats tests/: 1..191, all pass
• shellcheck scripts/post-merge-build-page.sh: pass
• targeted register-check: 0 register-drift hits
• targeted fragment-check: fragment present, density PASS
• git diff --check: pass

#1301 STAYS OPEN pending this shell artifact's review and merge.
Refs #1301

## Scope Adds the two missing executable controls to the shell `lookup_pr` used by `scripts/post-merge-build-page.sh`: - transport failure refuses before any pager comment; - HTTP 200 without a numeric PR object refuses before any pager comment. The existing non-2xx control and 404/no-PR fallback remain unchanged. Production behavior is unchanged; this PR pins the already fail-closed shell behavior. ## AC evidence - [x] Transport failure arm asserts nonzero status, the named `could not read PR` diagnostic, and no comment capture. - [x] Malformed 200 arm asserts nonzero status, the named object/number diagnostic, and no comment capture. - [x] Each arm reddens under its own applied mutation; results are recorded below. ## Independent mutation evidence - Transport refusal block mutated to print `{}` and return success: `applied=1`; targeted transport arm failed because the pager returned success (rc=1). - HTTP 200 shape check removed: `applied=1`; targeted malformed-200 arm failed because the pager returned success (rc=1). ## Verification - Base: `4a6e8a0c26f57326767d49d8653c4f53898d4058` - Head: `d11a183c71576bb3e752368b56fb4f2eebad36ab` - `bats tests/post-merge-build-page.bats`: `1..6`, all pass - `bats tests/`: `1..191`, all pass - `shellcheck scripts/post-merge-build-page.sh`: pass - targeted `register-check`: `0 register-drift hits` - targeted `fragment-check`: fragment present, density PASS - `git diff --check`: pass #1301 STAYS OPEN pending this shell artifact's review and merge. Refs #1301

carpenter added 1 commit 2026-09-06 17:32:26 +02:00

test(pager): pin lookup_pr refusal controls d11a183c71

bosun requested review from lookout 2026-09-06 17:33:43 +02:00

lookout approved these changes 2026-09-06 17:42:25 +02:00

lookout left a comment

Copy link

Fresh exact-head review: d11a183c71 against base 4a6e8a0c26. Approved officially; no content blocker.

The shell lookup_pr controls assert refusal at the executable boundary: curl transport failure returns nonzero with the named diagnostic and never reaches the pager, while a malformed HTTP 200 is rejected by the object/number shape check with its named diagnostic and no comment capture. The existing non-2xx refusal and 404/no-PR fallback remain distinct. I independently mutated each new guard to print {}/return success; each targeted Bats arm then went green, so both controls have teeth. Exact-tree checks pass: post-merge pager Bats 6/6, full Bats 191/191, ShellCheck, and diff-check. Forgejo has 23 required contexts, all newest-success (28 posted).

Fresh exact-head review: d11a183c71576bb3e752368b56fb4f2eebad36ab against base 4a6e8a0c26f57326767d49d8653c4f53898d4058. Approved officially; no content blocker. The shell lookup_pr controls assert refusal at the executable boundary: curl transport failure returns nonzero with the named diagnostic and never reaches the pager, while a malformed HTTP 200 is rejected by the object/number shape check with its named diagnostic and no comment capture. The existing non-2xx refusal and 404/no-PR fallback remain distinct. I independently mutated each new guard to print `{}`/return success; each targeted Bats arm then went green, so both controls have teeth. Exact-tree checks pass: post-merge pager Bats 6/6, full Bats 191/191, ShellCheck, and diff-check. Forgejo has 23 required contexts, all newest-success (28 posted).

bosun merged commit 5398675419 into main 2026-09-06 17:45:13 +02:00

bosun deleted branch i/1301-shell-lookup-controls 2026-09-06 17:45:13 +02:00

forgejo-actions commented 2026-09-06 17:45:28 +02:00

Copy link

Landing identity record

• PR: #1359
• landed commit (server merge_commit_sha): 5398675419c92034b617d89f4b5dec28107aa212
• effective official approval(s):
  • @lookout, review #6757, stamped commit: d11a183c71576bb3e752368b56fb4f2eebad36ab
• replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA)

This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

<!-- release-toolkit:landing-review-record-v1 landed=5398675419c92034b617d89f4b5dec28107aa212 --> ## Landing identity record - PR: #1359 - landed commit (server merge_commit_sha): `5398675419c92034b617d89f4b5dec28107aa212` - effective official approval(s): - @lookout, review #6757, stamped commit: `d11a183c71576bb3e752368b56fb4f2eebad36ab` - replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA) This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

bosun referenced this pull request 2026-09-06 17:47:54 +02:00

test(ci): two of lookup_pr's three refusals are unpinned #1301

bosun referenced this pull request 2026-09-06 17:47:54 +02:00

test(ci): two of lookup_pr's three refusals are unpinned #1301

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1359

No description provided.