#334 - feat(api): Forgejo API layer resilience — timeouts + retries + backoff + pagination - frankenbit/release-toolkit

bosun commented

2026-07-03 13:35:59 +02:00

Owner

Finding

scripts/lib/forgejo-api.sh has no connection timeout, total timeout, retries, backoff, 429 handling, or 5xx retry.

Pagination-incomplete: open PR lookup (client-side filter, no paginate), rolling PR label discovery, tag listing (limit=50), stale cleanup (fixed limit).

Should-fix rationale

Fine on small repos; breaks on active OSS. v1.0.0 signals broad-adoption readiness.

Fix

api_call_with_retry wrapper (exponential backoff, honor Retry-After)
Connection + total timeouts on curl (5s connect, 30s total, env-tunable)
api_paginate helper for list endpoints
Retrofit list callers to use pagination
Test coverage via mock server

Anchor

External correctness cold-read (anonymous ChatGPT session, uploaded to operator 2026-07-03). Full review surfaced 10 findings across 5 blocking-v1.0.0 + 2 should-fix pre-v1.0.0 + 3 post-v1.0.0 backlog. This tracker addresses one of them.

SHOULD-FIX pre-v1.0.0.

## Finding `scripts/lib/forgejo-api.sh` has no connection timeout, total timeout, retries, backoff, 429 handling, or 5xx retry. Pagination-incomplete: open PR lookup (client-side filter, no paginate), rolling PR label discovery, tag listing (limit=50), stale cleanup (fixed limit). ## Should-fix rationale Fine on small repos; breaks on active OSS. v1.0.0 signals broad-adoption readiness. ## Fix - `api_call_with_retry` wrapper (exponential backoff, honor Retry-After) - Connection + total timeouts on curl (5s connect, 30s total, env-tunable) - `api_paginate` helper for list endpoints - Retrofit list callers to use pagination - Test coverage via mock server ## Anchor External correctness cold-read (anonymous ChatGPT session, uploaded to operator 2026-07-03). Full review surfaced 10 findings across 5 blocking-v1.0.0 + 2 should-fix pre-v1.0.0 + 3 post-v1.0.0 backlog. This tracker addresses one of them. SHOULD-FIX pre-v1.0.0.

bosun added the

priority/high

size/L

kind/feature

labels

2026-07-03 13:35:59 +02:00

quartermaster referenced this issue

2026-07-03 22:47:39 +02:00

docs: v1.0.0 pre-cut Cold-Read delta (#353) #354

bosun referenced this issue

2026-07-04 08:53:27 +02:00

design(v2.0.0): consider Go rewrite for cross-runner + single-binary distribution + refactor-safety #367

bosun added

priority/critical

and removed

priority/high

labels

2026-07-05 11:26:28 +02:00

bosun commented

2026-07-05 11:26:28 +02:00

Author

Owner

Re-elevated to v1.0.0 must-fix per operator 2026-07-05 (post-round-4 sprint state review, decision-option (b)). Round-2 body already said SHOULD-FIX pre-v1.0.0; operator elected to honor that rather than defer to v1.1.0.

Substantive scope per original body: api_call_with_retry wrapper (exponential backoff, honor Retry-After) + connection + total timeouts on curl (5s connect, 30s total, env-tunable) + api_paginate helper for list endpoints + retrofit list callers + test coverage via mock server.

Land after v0.26.0 cut (in flight) so bisectable, before v1.0.0 cut.

Re-elevated to v1.0.0 must-fix per operator 2026-07-05 (post-round-4 sprint state review, decision-option (b)). Round-2 body already said SHOULD-FIX pre-v1.0.0; operator elected to honor that rather than defer to v1.1.0. Substantive scope per original body: api_call_with_retry wrapper (exponential backoff, honor Retry-After) + connection + total timeouts on curl (5s connect, 30s total, env-tunable) + api_paginate helper for list endpoints + retrofit list callers + test coverage via mock server. Land after v0.26.0 cut (in flight) so bisectable, before v1.0.0 cut.

quartermaster self-assigned this

2026-07-05 11:27:43 +02:00

quartermaster referenced this issue from a commit

2026-07-05 11:40:46 +02:00

feat(api): Forgejo API resilience — timeouts + retry + pagination (closes #334)

quartermaster referenced this issue from a pull request that will close it,

2026-07-05 16:49:28 +02:00

feat(api): Forgejo API resilience — timeouts + retry + pagination (#334) #404

quartermaster referenced this issue from a commit

2026-07-05 16:49:29 +02:00

feat(api): Forgejo API resilience — timeouts + retry + pagination (closes #334)

quartermaster closed this issue