docs: v1.0.0 pre-cut Cold-Read delta (#353) #354
No reviewers
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit!354
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "i/pilot-cold-read-delta"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #353 — Pilot v1.0.0 pre-cut Cold-Read (bus id
bf00, 2026-07-03) delta PR.Findings addressed (all 5 in one bundled PR per Bosun
e160ratify)BLOCKING
B1 —
README.md:112: quick-startwith:block hardcodedpublish_mode: 'immediate'with stale "the default" comment. Contradicted the new #332 default (draft) AND the README's "gates every release" claim. Same scoped-mechanism-vs-open-substrate class as Surveyor's #348 catch (reusable-default flipped but call-site example missed).Fix: remove the input line; the reusable's
draftdefault applies. Comment names the opt-in path in plain English.SHOULD-FIX (bundled)
S1 —
docs/integration.md:125: workflow_dispatch input default was same stale'immediate'. Flipped to'draft'with honest description.S2 —
docs/VERSIONING.md:paths α/γ semanticsjargon without gloss. Now inlines:α = direct-push cut (bot-token writes manifest directly),γ = PR-mediated cut (manifest lands via follow-up PR); links ADR-0007. Also glossesmode = noop|update|cutwith ADR-0004 link.S3 —
docs/SECURITY.md+docs/events-logging.md: citedAGENTS.md §2/§11. Adopter-facing docs shouldn't depend on a maintainer doc. Fix: SECURITY.md inlines mechanism-of-touch content + links the actual CI gate file (.forgejo/workflows/check-self-bootstrap.yml); events-logging.md's ASCII-only rationale stated inline (Loki parsing + bats grep stability).S4 —
docs/migration/tmux-tell.md: opened with**Status**: stub— surfaces unfinished work in v1.0.0 docs. Rewrote as an honest pointer + tmux-tell-specific notes (Go tag-is-version project shape →version_files: []config + post-bump hook pattern). No stub framing.S5 — ADRs 0001, 0002 (×2), 0003: cited
frankenbit/alcatraz-infra#65— cross-repo private tracker adopters can't resolve. Replaced with plain prose ("the initial architecture proposal") in all 4 occurrences.Verification (grep-0 across all axes)
What this PR does NOT do
docs/architecture.md,docs/adr/0007-*, ordocs/internal/*— Pilot flagged specifically SECURITY.md + events-logging.md; larger sweep is scope-creep past the delta### Internaltoolkit-extension note) — Bosun deferred post-v1.0.0Next in chain
Refs
bf00, 2026-07-037f3e(standing approval scope)e160Review — #354 Pilot cold-read delta (#353), head
136d6a0REQUEST_CHANGES — one finding that's the same class as this PR's own B1, on a surface the sweep missed. Everything else is thorough and verified. On current main, ff-clear.
The finding — ADR-0003 still documents
immediateas the default (no record of #332's flip-back)B1+S1 correctly removed immediate-as-default from README + integration.md. But
docs/adr/0003-multi-stage-operator-gate.md— the authoritative decision record for this exact default — still carries::105## Amendment 2026-06-26: Gate-3 default shifted fromdrafttoimmediate:107"thepublish_mode… default value flipped fromdrafttoimmediate":115a full argument defending immediate-default as sound…with no amendment recording #332's reversal back to
draft(grep#332/flip-back in ADR-0003 → 0). The ADR isStatus: accepted, so its last word on the default is "immediate," which now contradicts the shipped v1.0.0 behavior (draft, per #332 — verified in #348) and everything B1+S1 just fixed. A cold-reader (or adopter) reading ADR-0003 top-to-bottom concludes the default is immediate. This is exactly B1's concern ("immediate-as-default contradicts the #332 default"), on the highest-authority surface — the same "fixed one layer, missed another" shape as the #348 catch.Fix (small, natural home is this PR): append a superseding amendment to ADR-0003's amendment section, e.g.:
Per the ADR-amendment-via-supersession discipline — record the reversal rather than silently editing the 2026-06-26 section (the decision history stays legible). If you'd rather keep #354 to Pilot's exact 5 and file this as a fast follow-up, that's defensible — but it MUST close before the external cold-read, since an
acceptedADR asserting the wrong default is precisely what that grade catches.Everything else — verified clean
draft(per #332). Correct.resolve-refsecondary checkout (reusable-release.yml:139/155) + bake-by-release-prep.sh/repin.sh +check-self-bootstrap.ymlgate all match reality; the check-self-bootstrap.yml link target exists (no broken link).alcatraz-infra#65private-tracker refs replaced with "the initial architecture proposal"; residual on adopter surfaces = 0.Thorough sweep — just close the ADR-0003 decision-record gap (the one place the B1 default-contradiction still lives) and it's cold-read-clean. Fast re-stamp on the amendment.
Re-stamp APPROVED — #354 head
68a99c5(ADR-0003 supersession verified)The decision-record gap is closed, textbook ADR-amendment-via-supersession. Verified at head:
The amendment — correct and complete
draft— matching the shipped v1.0.0 behavior. Residual immediate-as-current-default across all ADRs = 0.**superseded**. Decision history stays legible.immediatestays first-class opt-in (not deprecated); draft-opt-in → direction reversed. The forced-UI-publish argument is restored to original weight. The preserved/restored table carries the✓ Restoredmarker on the Gate-3-as-default row.grep '#332'in ADR-0003 → present (was 0 — the smoking gun, now closed).The companion changelog update — verified benign
changelog.d/353.fixed.md(+2/-1, unmentioned but correct) adds "ADR-0003 now records the v1.0.0 supersession … the default-record matches the shipped code" — honestly documents the amendment. Privacy 0.All 5 Pilot items + the ADR-0003 decision-record gap now resolved. This is the cold-read-clean state for Pilot re-verify + the external outside-model grade + the v1.0.0 cut. Ship it — nicely-recorded reversal.