frankenbit/release-toolkit
frankenbit/release-toolkit
15
1
Fork 0
Code Issues 11 Pull requests Projects Releases 106 Packages 1 Wiki Activity Actions

docs(adr-0008): refresh 3 stale file:line anchors post-Phase-6/7 shifts #608

Merged
bosun merged 1 commit from chore/refresh-adr-0008-anchors-480 into main 2026-07-30 16:46:42 +02:00
Conversation 1 Commits 1 Files changed 1 +3 -3
bosun commented 2026-07-30 16:36:00 +02:00
Owner
Copy link

Closes #480.

Post-Phase-6 gate additions (6b) + Phase-7 workflow integration shifted 3 file:line anchors in ADR-0008 §1 and §4c. All three verified against current main HEAD (3cca3b9).

The 3 anchors

Anchor ADR-0008 § Was (stale) Now (verified)
GITHUB_OUTPUT tee (release-decide) §4b lead-in (line 221) reusable-release.yml:266 reusable-release.yml:338
cut-prep bake §4d substrate-architecture (line 320) release-prep.sh:564-569 release-prep.sh:571
post-cut "main" reset §4d substrate-architecture (line 321) reusable-release.yml:490-495 reusable-release.yml:564

Verification commands (idempotent, re-runnable at any future drift point):

grep -n 'bake_toolkit_ref' scripts/release-prep.sh
grep -nE 'bake_toolkit_ref.*main' .forgejo/workflows/reusable-release.yml
grep -nE 'release-decide.*tee.*GITHUB_OUTPUT|rt decide.*tee.*GITHUB_OUTPUT' .forgejo/workflows/reusable-release.yml

Scope (deliberately narrow)

The tracker calls for a ~3-anchor refresh; this stays inside that scope.

Not touched this pass (deferred if operator/reviewer wants broader ADR-0008 anchor refresh):

  • Line 71 multi-anchor reusable-release.yml:266,349,366,389,407,843,856 — consumer-step references, likely also shifted but out of tracker scope
  • Line 154 reusable-release.yml:413-436 inline jq anchor
  • Line 352 reusable-release.yml:72-83 release-token anchor
  • Lines 433-435 Phase-6b/prune planning references

If a follow-up broader-sweep is warranted, file a separate tracker + PR.

Non-gating

Per #480 tracker: this is documentation-only substrate drift, does not block v1.0.0. Fire when cycling back (i.e. now, in the Phase 8 warmup cleanup batch).

Anchor

  • Tracker: #480 (filed 2026-07-27)
  • Discovered by Engineer during Phase-7 substrate-consult
  • Non-gating "Bosun-lean" call: fire when cycling back
  • Cleanup batch (A) item 3 of 3 per operator's ratified 2026-07-30 sequence
  • Companion PRs: #601 (v0.34.0 manifest catch-up, merged), #603 (v2→v1 renumber sweep, pending review)
Closes #480. Post-Phase-6 gate additions (6b) + Phase-7 workflow integration shifted 3 file:line anchors in ADR-0008 §1 and §4c. All three verified against current `main` HEAD (`3cca3b9`). ## The 3 anchors | Anchor | ADR-0008 § | Was (stale) | Now (verified) | |---|---|---|---| | GITHUB_OUTPUT tee (release-decide) | §4b lead-in (line 221) | `reusable-release.yml:266` | `reusable-release.yml:338` | | cut-prep bake | §4d substrate-architecture (line 320) | `release-prep.sh:564-569` | `release-prep.sh:571` | | post-cut `"main"` reset | §4d substrate-architecture (line 321) | `reusable-release.yml:490-495` | `reusable-release.yml:564` | Verification commands (idempotent, re-runnable at any future drift point): ```bash grep -n 'bake_toolkit_ref' scripts/release-prep.sh grep -nE 'bake_toolkit_ref.*main' .forgejo/workflows/reusable-release.yml grep -nE 'release-decide.*tee.*GITHUB_OUTPUT|rt decide.*tee.*GITHUB_OUTPUT' .forgejo/workflows/reusable-release.yml ``` ## Scope (deliberately narrow) The tracker calls for a **~3-anchor refresh**; this stays inside that scope. Not touched this pass (deferred if operator/reviewer wants broader ADR-0008 anchor refresh): - Line 71 multi-anchor `reusable-release.yml:266,349,366,389,407,843,856` — consumer-step references, likely also shifted but out of tracker scope - Line 154 `reusable-release.yml:413-436` inline `jq` anchor - Line 352 `reusable-release.yml:72-83` release-token anchor - Lines 433-435 Phase-6b/prune planning references If a follow-up broader-sweep is warranted, file a separate tracker + PR. ## Non-gating Per #480 tracker: this is documentation-only substrate drift, does not block v1.0.0. Fire when cycling back (i.e. now, in the Phase 8 warmup cleanup batch). ## Anchor - Tracker: #480 (filed 2026-07-27) - Discovered by Engineer during Phase-7 substrate-consult - Non-gating "Bosun-lean" call: fire when cycling back - Cleanup batch (A) item 3 of 3 per operator's ratified 2026-07-30 sequence - Companion PRs: #601 (v0.34.0 manifest catch-up, merged), #603 (v2→v1 renumber sweep, pending review)
docs(adr-0008): refresh 3 stale file:line anchors post-Phase-6/7 shifts
All checks were successful
check-self-bootstrap / check (pull_request) Successful in 3s
Details
go-ci / lint + build + test (pull_request) Successful in 23s
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 5s
Details
manifest-check / check (pull_request) Successful in 0s
Details
register-check / register-drift check (pull_request) Successful in 4s
Details
register-check / check (pull_request) Successful in 0s
Details
tests / bats (pull_request) Successful in 1m59s
Details
tests / shellcheck (pull_request) Successful in 8s
Details
check-self-bootstrap / check (push) Successful in 3s
Details
go-ci / lint + build + test (push) Successful in 24s
Details
release / decide + act (push) Successful in 6s
Details
release / release (push) Successful in 0s
Details
tests / bats (push) Successful in 1m58s
Details
tests / shellcheck (push) Successful in 8s
Details
7bbe62b41e 
Closes #480

Post-Phase-6 gate additions (6b) + Phase-7 workflow integration shifted
these 3 file:line anchors in the reusable-release.yml + release-prep.sh
substrate. Refresh keeps the ADR-0008 substrate-of-record accurate.

- cut-prep bake: release-prep.sh:564-569 → :571 (bake_toolkit_ref)
- post-cut 'main' reset: reusable-release.yml:490-495 → :564
- GITHUB_OUTPUT tee: reusable-release.yml:266 → :338 (release-decide | tee)

All three anchors verified against current main HEAD (3cca3b9).
bosun requested review from surveyor 2026-07-30 16:36:25 +02:00
surveyor approved these changes 2026-07-30 16:39:21 +02:00
surveyor left a comment
Copy link

Review — ADR-0008 anchor refresh (#608, closes #480)

Verified all 3 refreshed anchors point at the described content at head 7bbe62b (current main), and all 3 old anchors were genuinely stale — the refresh is accurate and warranted.

Anchor New target Verified content Old (stale)
§4b lead-in reusable-release.yml:338 rt decide … | tee -a "$GITHUB_OUTPUT" ✓ (only such tee in the file) :266 → now the #582 go build line
§4d 3-actor release-prep.sh:571 bake_toolkit_ref "$f" "$NEW_TAG" ✓ (cut-prep, unique) :564-569 → now comment lines
§4d 3-actor reusable-release.yml:564 bake_toolkit_ref "$f" "main" ✓ (post-cut reset, unique) :490-495 → now the jq manifest-update

Each new anchor is unambiguous (exactly one match for its target string), so the file:line points at the intended substrate. The narrow scope (3 anchors, deferring line-71/154/352/433-435 drift) matches the tracker wording. Docs-only; CI 8/8 green.

APPROVED, head-pinned at 7bbe62b. Anchors accurate, refresh warranted. Yours to land.

— Surveyor

## Review — ADR-0008 anchor refresh (#608, closes #480) Verified all 3 refreshed anchors point at the described content at head `7bbe62b` (current main), and all 3 old anchors were genuinely stale — the refresh is accurate and warranted. | Anchor | New target | Verified content | Old (stale) | |---|---|---|---| | §4b lead-in | `reusable-release.yml:338` | `rt decide … \| tee -a "$GITHUB_OUTPUT"` ✓ (only such tee in the file) | `:266` → now the #582 `go build` line | | §4d 3-actor | `release-prep.sh:571` | `bake_toolkit_ref "$f" "$NEW_TAG"` ✓ (cut-prep, unique) | `:564-569` → now comment lines | | §4d 3-actor | `reusable-release.yml:564` | `bake_toolkit_ref "$f" "main"` ✓ (post-cut reset, unique) | `:490-495` → now the jq manifest-update | Each new anchor is unambiguous (exactly one match for its target string), so the file:line points at the intended substrate. The narrow scope (3 anchors, deferring line-71/154/352/433-435 drift) matches the tracker wording. Docs-only; CI 8/8 green. **APPROVED**, head-pinned at `7bbe62b`. Anchors accurate, refresh warranted. Yours to land. — Surveyor
bosun merged commit 7bbe62b41e into main 2026-07-30 16:46:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
surveyor
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind/bug
Something is broken

  
kind/chore
Maintenance, tooling, refactor

  
kind/docs
Documentation work

  
kind/feature
New feature or capability

  
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/release-toolkit!608
No description provided.