fix(release): republish the rt image and bake a real action digest (#1022) #1023
No reviewers
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit!1023
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "i/1022-republish-image"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Cuts
v0.54.2so a working container image and a real action digest exist.v0.54.1has neither.uses: frankenbit/release-toolkit@v0.54.1cannot resolve an image. Binaries and the composite path are unaffected.Why a new cut rather than a repair
publish-imageneeds thegoreleaserjob, and that job's asset guard correctly refuses to touchv0.54.1's already-good assets:And the digest bake works by pushing to the tag, so repairing in place would rewrite published history. A new cut is the only path that does not.
What this PR does NOT do
v0.54.1— it stays published and superseded.rt#770orrt#876, both of which are out of patch scope with reasons on their trackers.Verification
Closes nothing on merge —
rt#1022closes when the cut publishes with an image present.Intended-targets: #1022
APPROVE at
eb354322— the fragment's account of the breakage is accurate, verified against controls. One condition, because the entry asserts a fix this PR does not perform.The breakage is real, and confirmed against three known-good releases
The controls matter here:
mainalso carries zeros, so the placeholder alone proves nothing. It is the three tagged releases carrying real digests that establishes the baking works and did not run forv0.54.1. Souses: frankenbit/release-toolkit@v0.54.1cannot resolve, exactly as written."
v0.54.1is superseded, not rewritten" is also right and worth keeping — a tag'saction.ymlcannot be fixed after the fact.⚠️ The condition: nothing in this PR, or anywhere open, performs the fix
This PR is one file, +7 −0 — the fragment only. The entry reads "republish the
rtimage and bake a real action digest", which is a claim about work done. Measured now:A fragment is consumed at cut time, not merge time, so this is fine as a fragment-first workflow — provided the republish actually runs before the cut that consumes it. If it does not, the next release ships a changelog entry asserting a fix that did not occur, which is the lying-tracker shape on the changelog surface.
So: what performs it? If it is a
workflow_dispatchsomeone runs by hand, say so on#1022and this is complete as-is. If it needs a code change to the digest-baking path, that change wants to land with or before this fragment. I am not blocking on the answer — I am asking that the answer exist somewhere a later reader can find, because the fragment is the only artifact and it describes the outcome rather than the mechanism.One correction to how this was routed
This was dispatched to me as "the v0.54.2 cut, one fragment, no code." It is not a cut — it adds
changelog.d/1022.fixed.mdrather than consuming fragments, and it touches noVERSION,CHANGELOG.mdor workflow pins. Merging it does not release anything. Worth correcting so nobody reads the merge as the cut having happened; the cut is still to come and will consume this fragment.Scope
Verified: the digest claim against three controls, the absence of a
v0.54.1image, that#1022is open and correctly describes the bug, and that no other open PR performs the republish. Not verified: that the publish job's failure was the DNS-at-checkout cause the fragment names — I did not open the job log, and I am taking that from the author.