test(release): guard fire-cut reachability condition #1085

Merged

pullings merged 1 commit from i/1065-fire-cut into main 2026-08-30 01:26:54 +02:00

Conversation 2 Commits 1 Files changed 2 +49

carpenter commented 2026-08-30 01:21:45 +02:00

Owner

Copy link

Refs #1065

Add a static guard for the fire-cut job in .forgejo/workflows/release.yml.

The arm checks that jobs.fire-cut.if gates on needs.release.outputs.mode == 'cut' and contains no cut_gate dependency. Its mutation control adds && inputs.cut_gate == 'execute' and requires the same predicate to fail. The control names the exact file and job scope.

This is deliberately a static reachability guard. It does not claim that a real runner reaches or completes the dispatched release-cut.yml; that live-run boundary remains deferred with #1057 AC2. No release action was fired.

Verification:

• bats --print-output-on-failure tests/workflows.bats -f '#1065' -> 1..1, pass; the mutation is refused.
• bats --print-output-on-failure tests/ -> 1..157, all pass.
• go build ./..., go vet ./..., and go test ./... -> pass.
• go run ./cmd/rt fragment-check changelog.d -> density PASS.
• PyYAML parse -> YAML parsed: 22 workflow files; git diff --check -> pass.

The repository-wide ShellCheck invocation still reports the pre-existing SC2016 info in scripts/contract-paths-check.sh; this PR changes no shell script.

Refs #1065 Add a static guard for the `fire-cut` job in `.forgejo/workflows/release.yml`. The arm checks that `jobs.fire-cut.if` gates on `needs.release.outputs.mode == 'cut'` and contains no `cut_gate` dependency. Its mutation control adds `&& inputs.cut_gate == 'execute'` and requires the same predicate to fail. The control names the exact file and job scope. This is deliberately a static reachability guard. It does not claim that a real runner reaches or completes the dispatched `release-cut.yml`; that live-run boundary remains deferred with #1057 AC2. No release action was fired. Verification: - `bats --print-output-on-failure tests/workflows.bats -f '#1065'` -> `1..1`, pass; the mutation is refused. - `bats --print-output-on-failure tests/` -> `1..157`, all pass. - `go build ./...`, `go vet ./...`, and `go test ./...` -> pass. - `go run ./cmd/rt fragment-check changelog.d` -> density PASS. - PyYAML parse -> `YAML parsed: 22 workflow files`; `git diff --check` -> pass. The repository-wide ShellCheck invocation still reports the pre-existing SC2016 info in `scripts/contract-paths-check.sh`; this PR changes no shell script.

carpenter added 1 commit 2026-08-30 01:21:45 +02:00

test(release): guard fire-cut condition 05605428a0

pullings requested review from sentry 2026-08-30 01:22:20 +02:00

sentry approved these changes 2026-08-30 01:25:42 +02:00

sentry left a comment

Copy link

Exact-head review: APPROVED. The static arm names release.yml and jobs.fire-cut.if, verifies the mode=cut condition is independent of cut_gate, and its mutation appending a cut_gate dependency reddens the arm. The explicit separation from #1057 AC2 is correct: this test does not claim that a live runner dispatch reaches or completes release-cut.yml. Targeted Bats, YAML parsing, and diff checks pass; Forgejo CI is terminal 25/25.

Exact-head review: APPROVED. The static arm names release.yml and jobs.fire-cut.if, verifies the mode=cut condition is independent of cut_gate, and its mutation appending a cut_gate dependency reddens the arm. The explicit separation from #1057 AC2 is correct: this test does not claim that a live runner dispatch reaches or completes release-cut.yml. Targeted Bats, YAML parsing, and diff checks pass; Forgejo CI is terminal 25/25.

sentry approved these changes 2026-08-30 01:26:26 +02:00

sentry left a comment

Copy link

Exact-head review: APPROVED. The static arm names release.yml and jobs.fire-cut.if, verifies the mode=cut condition is independent of cut_gate, and its mutation appending a cut_gate dependency reddens the arm. The explicit separation from #1057 AC2 is correct: this test does not claim that a live runner dispatch reaches or completes release-cut.yml. Targeted Bats, YAML parsing, and diff checks pass; Forgejo CI is terminal 25/25.

Exact-head review: APPROVED. The static arm names release.yml and jobs.fire-cut.if, verifies the mode=cut condition is independent of cut_gate, and its mutation appending a cut_gate dependency reddens the arm. The explicit separation from #1057 AC2 is correct: this test does not claim that a live runner dispatch reaches or completes release-cut.yml. Targeted Bats, YAML parsing, and diff checks pass; Forgejo CI is terminal 25/25.

pullings merged commit 05605428a0 into main 2026-08-30 01:26:54 +02:00

pullings deleted branch i/1065-fire-cut 2026-08-30 01:26:54 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

sentry

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1085

No description provided.