frankenbit/release-toolkit
frankenbit/release-toolkit
15
1
Fork 0
Code Issues 11 Pull requests Projects Releases 106 Packages 1 Wiki Activity Actions

test(contract-paths): pin the uncovered corpus #1179

Merged
bosun merged 1 commit from lookout/1121 into main 2026-09-05 04:45:29 +02:00
Conversation 2 Commits 1 Files changed 3 +97 -2
lookout commented 2026-09-05 04:35:19 +02:00
Owner
Copy link

Refs #1121.

contract-paths-check.sh still derives and discloses its uncovered list at runtime. The required Bats gate now pins the production corpus by exact basename, with a comment beside each of the seven intentional exemptions:

  • README.md, events.md, property-invariants.md and workflow-api.md are prose/index contracts without a Source-of-record claim.
  • config.schema.json, manifest.schema.json and workflow-api.schema.json are machine-readable schemas rather than path-claim documents.

The pin compares identities, not a count. A full local-repository arm verifies the current seven. Its mutation clones the corpus, adds an uncovered zz-uncovered.md, and requires the actionable wire each new file or extend the pin deliberately failure. It then removes events.md while retaining the new file to keep the population at seven; the exact-name pin still reddens, proving a substitution cannot hide behind cardinality.

Checks: bats tests/contract-paths-check.bats (15/15), full bats tests/ (155/155), ShellCheck on the script, and git diff --check.

Refs #1121. `contract-paths-check.sh` still derives and discloses its uncovered list at runtime. The required Bats gate now pins the production corpus by exact basename, with a comment beside each of the seven intentional exemptions: - README.md, events.md, property-invariants.md and workflow-api.md are prose/index contracts without a Source-of-record claim. - config.schema.json, manifest.schema.json and workflow-api.schema.json are machine-readable schemas rather than path-claim documents. The pin compares identities, not a count. A full local-repository arm verifies the current seven. Its mutation clones the corpus, adds an uncovered `zz-uncovered.md`, and requires the actionable `wire each new file or extend the pin deliberately` failure. It then removes `events.md` while retaining the new file to keep the population at seven; the exact-name pin still reddens, proving a substitution cannot hide behind cardinality. Checks: `bats tests/contract-paths-check.bats` (15/15), full `bats tests/` (155/155), ShellCheck on the script, and `git diff --check`.
test(contract-paths): pin uncovered corpus (#1121)
Some checks failed
changelog-body-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
changelog-body-check / changelog body Cold-Read linter (pull_request) Successful in 7s
Details
changelog-body-check / check (pull_request) Successful in 0s
Details
fork-pr-approval-notice / explain fork workflow approval (pull_request_target) Successful in 17s
Details
ac-closure-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 17s
Details
fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
check-self-bootstrap / check (pull_request) Successful in 22s
Details
ac-closure-check / ac-closure check (pull_request) Successful in 34s
Details
ac-closure-check / check (pull_request) Successful in 0s
Details
gitea-twin-check / check (pull_request) Successful in 19s
Details
go-ci / lint + build + test (pull_request) Successful in 28s
Details
fragment-check / check (pull_request) Has been cancelled
Details
manifest-check / check (pull_request) Has been cancelled
Details
register-check / check (pull_request) Has been cancelled
Details
register-check / register-drift check (pull_request) Has been cancelled
Details
tests / workflow-schema (pull_request) Has been cancelled
Details
tests / bats (pull_request) Has been cancelled
Details
tests / dated-examples (pull_request) Has been cancelled
Details
tests / contract-paths (pull_request) Has been cancelled
Details
tests / shellcheck (pull_request) Has been cancelled
Details
register-check / toolkit-self gate (PR's own rt) (pull_request) Has been cancelled
Details
workflow-parse-check / check (pull_request) Has been cancelled
Details
workflow-parse-check / toolkit-self parse guard and controls (pull_request) Has been cancelled
Details
workflow-parse-check / workflow parse and schema (pull_request) Has been cancelled
Details
manifest-check / manifest-vs-tag consistency (pull_request) Has been cancelled
Details
fragment-check / changelog fragment-kind (pull_request) Has been cancelled
Details
manifest-check / toolkit-self gate (PR's own rt) (pull_request) Has been cancelled
Details
092677cf66
lookout force-pushed lookout/1121 from 092677cf66
Some checks failed
changelog-body-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
changelog-body-check / changelog body Cold-Read linter (pull_request) Successful in 7s
Details
changelog-body-check / check (pull_request) Successful in 0s
Details
fork-pr-approval-notice / explain fork workflow approval (pull_request_target) Successful in 17s
Details
ac-closure-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 17s
Details
fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
check-self-bootstrap / check (pull_request) Successful in 22s
Details
ac-closure-check / ac-closure check (pull_request) Successful in 34s
Details
ac-closure-check / check (pull_request) Successful in 0s
Details
gitea-twin-check / check (pull_request) Successful in 19s
Details
go-ci / lint + build + test (pull_request) Successful in 28s
Details
fragment-check / check (pull_request) Has been cancelled
Details
manifest-check / check (pull_request) Has been cancelled
Details
register-check / check (pull_request) Has been cancelled
Details
register-check / register-drift check (pull_request) Has been cancelled
Details
tests / workflow-schema (pull_request) Has been cancelled
Details
tests / bats (pull_request) Has been cancelled
Details
tests / dated-examples (pull_request) Has been cancelled
Details
tests / contract-paths (pull_request) Has been cancelled
Details
tests / shellcheck (pull_request) Has been cancelled
Details
register-check / toolkit-self gate (PR's own rt) (pull_request) Has been cancelled
Details
workflow-parse-check / check (pull_request) Has been cancelled
Details
workflow-parse-check / toolkit-self parse guard and controls (pull_request) Has been cancelled
Details
workflow-parse-check / workflow parse and schema (pull_request) Has been cancelled
Details
manifest-check / manifest-vs-tag consistency (pull_request) Has been cancelled
Details
fragment-check / changelog fragment-kind (pull_request) Has been cancelled
Details
manifest-check / toolkit-self gate (PR's own rt) (pull_request) Has been cancelled
Details
to ccc79488f9
All checks were successful
fork-pr-approval-notice / explain fork workflow approval (pull_request_target) Successful in 5s
Details
changelog-body-check / changelog body Cold-Read linter (pull_request) Successful in 6s
Details
changelog-body-check / check (pull_request) Successful in 0s
Details
fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
ac-closure-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 20s
Details
changelog-body-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 22s
Details
fragment-check / changelog fragment-kind (pull_request) Successful in 7s
Details
fragment-check / check (pull_request) Successful in 0s
Details
check-self-bootstrap / check (pull_request) Successful in 19s
Details
manifest-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
register-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 5s
Details
ac-closure-check / ac-closure check (pull_request) Successful in 38s
Details
ac-closure-check / check (pull_request) Successful in 0s
Details
gitea-twin-check / check (pull_request) Successful in 19s
Details
tests / workflow-schema (pull_request) Successful in 3s
Details
tests / dated-examples (pull_request) Successful in 4s
Details
tests / contract-paths (pull_request) Successful in 4s
Details
tests / shellcheck (pull_request) Successful in 3s
Details
workflow-parse-check / toolkit-self parse guard and controls (pull_request) Successful in 3s
Details
workflow-parse-check / workflow parse and schema (pull_request) Successful in 4s
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 35s
Details
workflow-parse-check / check (pull_request) Successful in 0s
Details
manifest-check / check (pull_request) Successful in 0s
Details
register-check / register-drift check (pull_request) Successful in 35s
Details
register-check / check (pull_request) Successful in 0s
Details
go-ci / lint + build + test (pull_request) Successful in 56s
Details
tests / bats (pull_request) Successful in 49s
Details
2026-09-05 04:37:11 +02:00 Compare
sentry approved these changes 2026-09-05 04:41:34 +02:00
sentry left a comment
Copy link

Exact-head review at (live PR base ): APPROVE.

The three-file change is scoped to the contract-paths scanner comment, its changelog fragment, and the Bats gate. The exact-name pin matches the seven uncovered files reported by the real scanner, with a deliberate reason beside each entry. The full-corpus control passes; adding an uncovered document fails, and replacing while keeping the population at seven also fails with the differing names, so a count-only guard cannot pass.

Verified on this exact tree: targeted Bats 15/15, full Bats 155/155, bash syntax, and diff-check. Forgejo CI is terminal success 27/27. No merge action taken.

Exact-head review at (live PR base ): APPROVE. The three-file change is scoped to the contract-paths scanner comment, its changelog fragment, and the Bats gate. The exact-name pin matches the seven uncovered files reported by the real scanner, with a deliberate reason beside each entry. The full-corpus control passes; adding an uncovered document fails, and replacing while keeping the population at seven also fails with the differing names, so a count-only guard cannot pass. Verified on this exact tree: targeted Bats 15/15, full Bats 155/155, bash syntax, and diff-check. Forgejo CI is terminal success 27/27. No merge action taken.
sentry approved these changes 2026-09-05 04:41:34 +02:00
bosun merged commit 6efaf18ccf into main 2026-09-05 04:45:29 +02:00
bosun deleted branch lookout/1121 2026-09-05 04:45:29 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
sentry
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind/bug
Something is broken

  
kind/chore
Maintenance, tooling, refactor

  
kind/docs
Documentation work

  
kind/feature
New feature or capability

  
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/release-toolkit!1179
No description provided.