chore(release): v0.57.4 #1188

Merged

bosun merged 1 commit from release-prep/rolling into main 2026-09-05 20:37:04 +02:00

Conversation 1 Commits 1 Files changed 24 +62 -43

release-bot commented 2026-09-05 10:52:57 +02:00

Member

Copy link

Changelog density — clean

• PASS — check 7 (sentence length): all sentences ≤ 25 words. Lists, tables and blockquotes are measured too (#632).
• PASS — check 8 (paren nesting): all paragraphs ≤ depth 2
• PASS — check 9 (paragraph length): all paragraphs ≤ 75 words. Lists, tables and blockquotes are measured too (#632).

Advisory mirror of the cut-time gate, computed when this description was written. It carries no authority: the cut re-runs these checks against the section as it stands then, and this branch is recreated from main on every compose.

Added

None.

Changed

None.

Fixed

• release: the release PR is actually routed for review (#620)

Removed

None.

Deprecated

None.

Upgrade

None.

<!-- rt:density-verdict --> ### Changelog density — clean - **PASS** — check 7 (sentence length): all sentences ≤ 25 words. Lists, tables and blockquotes are measured too (#632). - **PASS** — check 8 (paren nesting): all paragraphs ≤ depth 2 - **PASS** — check 9 (paragraph length): all paragraphs ≤ 75 words. Lists, tables and blockquotes are measured too (#632). _Advisory mirror of the cut-time gate, computed when this description was written._ _It carries no authority: the cut re-runs these checks against the section as it stands then, and this branch is recreated from `main` on every compose._ <!-- /rt:density-verdict --> ### Added None. ### Changed None. ### Fixed - **release**: the release PR is actually routed for review (#620) ### Removed None. ### Deprecated None. ### Upgrade None.

release-bot added 1 commit 2026-09-05 10:52:57 +02:00

chore(release): prepare v0.57.4 ... cba3a009d9

Generated by release-toolkit rt prep.

Tracker: frankenbit/release-toolkit#1

surveyor approved these changes 2026-09-05 20:34:58 +02:00

surveyor left a comment

Copy link

APPROVED at cba3a009. A clean cut. Reviewed cold, nine hours after it opened — see the note at the end about why nobody was asked.

Verified

commits        one — chore(release): prepare v0.57.4, AT HEAD
               → nothing release-relevant above the prepare commit, so #417's
                 cut-about-to-fire exemption is reachable on the newest-first walk
files          24 listed, changed_files=24 — the arithmetic matches, so this is the
               whole set and not page 1 of a paginated sample
twins          rt gitea-twin --check → PASS, 10 twins, rc=0
markers        8 pairs, .forgejo == .gitea on every one, all at v0.57.4
VERSION        0.57.3 → 0.57.4
changelog.d    drained; one fragment consumed (620-wire-release-pr-reviewers)
required set   enable_status_check=true · 13 contexts · REQUIRED BUT NOT GREEN → 0 of 13

✅ The fragment's sub-paragraphs are dropped, and that is rt prep's normal composition rather than a loss here. Checked against the earlier released sections instead of against the fragment — a fragment-vs-CHANGELOG comparison would have manufactured a regression:

v0.57.4  1 bullet    v0.57.3  2    v0.57.2  7    v0.57.1  4    v0.57.0  43    v0.56.1  3
indented continuation lines:  0    0    0    0    0    0

Six sections back to v0.56.1, zero continuation lines in any of them. The behaviour is uniform.

✅ #1163's AC2 is discharged in the field, on the path that had no grader

I held this open last night specifically because #1175 fixed the rt prep caller and left the [skip ci] post-cut one armed. All three callers now regenerate, and the ungraded one proved it on a real cut:

cmd/rt/prep.go:345        giteatwin refs 3
cmd/rt/post_cut.go:622    giteatwin refs 4    ← was 0
cmd/rt/build_bake.go:78   giteatwin refs 2    ← was 0

792df7a  "post-cut bookkeeping for v0.57.3 [skip ci]"   7 .forgejo + 7 .gitea
89f9dc8  "post-cut bookkeeping for v0.57.0 [skip ci]"   7 .forgejo + 0 .gitea   ← the defect

Same commit shape, same [skip ci], opposite outcome. That is the AC as written — "discharged when a [skip ci] post-cut bookkeeping commit comes back twin-clean" — satisfied by measurement rather than argument. #1163 can close.

📌 This cut ships the reviewer-routing fix, and it is itself unrouted

The one fragment it consumes is #1186 — "the release PR is actually routed for review (#620)". The release that makes alcatraz-infra#620's mechanism live has zero review rows and sat nine hours.

⚠️ And the jam class is sharper than "a Forgejo review request is not a notification". My cross-repo row sweep — eight repos, newest-per-user, reading rows and not requested_reviewers — returns zero REQUEST_REVIEW rows naming me, anywhere. Nobody was ever asked.

an UNANSWERED request   the reviewer holds it and no one is told   → a notification gap
NO request at all       nobody holds it                            → a dispatch gap

Same appearance on every board view, different remedy — and with required_approvals=1 this PR was mechanically blocked on a stamp that had not been requested. That is worth #1159 carrying as two classes rather than one.

What this approval does not cover

The published artifacts. v0.57.0 reported a green job and published zero assets. Read .assets | length back from the API after the cut; a green job is not a claim about what exists on the release.

gitea-twin --check says its own limit — it compares bytes in this tree and cannot run a workflow on another forge.

📌 reusable-recover-pending-cut.yml is still pinned to v0.57.0 in both trees — consistent, so the gate is right to pass it, and it is rt#1173's known omission (never in canonicalFiles). It is now four releases behind, which is not a blocker and is a widening gap.

**APPROVED at `cba3a009`.** A clean cut. Reviewed cold, nine hours after it opened — see the note at the end about why nobody was asked. ## Verified ``` commits one — chore(release): prepare v0.57.4, AT HEAD → nothing release-relevant above the prepare commit, so #417's cut-about-to-fire exemption is reachable on the newest-first walk files 24 listed, changed_files=24 — the arithmetic matches, so this is the whole set and not page 1 of a paginated sample twins rt gitea-twin --check → PASS, 10 twins, rc=0 markers 8 pairs, .forgejo == .gitea on every one, all at v0.57.4 VERSION 0.57.3 → 0.57.4 changelog.d drained; one fragment consumed (620-wire-release-pr-reviewers) required set enable_status_check=true · 13 contexts · REQUIRED BUT NOT GREEN → 0 of 13 ``` ✅ **The fragment's sub-paragraphs are dropped, and that is `rt prep`'s normal composition rather than a loss here.** Checked against the *earlier released sections* instead of against the fragment — a fragment-vs-CHANGELOG comparison would have manufactured a regression: ``` v0.57.4 1 bullet v0.57.3 2 v0.57.2 7 v0.57.1 4 v0.57.0 43 v0.56.1 3 indented continuation lines: 0 0 0 0 0 0 ``` Six sections back to `v0.56.1`, zero continuation lines in any of them. The behaviour is uniform. ## ✅ `#1163`'s AC2 is discharged in the field, on the path that had no grader I held this open last night specifically because `#1175` fixed the `rt prep` caller and left the `[skip ci]` post-cut one armed. **All three callers now regenerate, and the ungraded one proved it on a real cut:** ``` cmd/rt/prep.go:345 giteatwin refs 3 cmd/rt/post_cut.go:622 giteatwin refs 4 ← was 0 cmd/rt/build_bake.go:78 giteatwin refs 2 ← was 0 792df7a "post-cut bookkeeping for v0.57.3 [skip ci]" 7 .forgejo + 7 .gitea 89f9dc8 "post-cut bookkeeping for v0.57.0 [skip ci]" 7 .forgejo + 0 .gitea ← the defect ``` **Same commit shape, same `[skip ci]`, opposite outcome.** That is the AC as written — *"discharged when a `[skip ci]` post-cut bookkeeping commit comes back twin-clean"* — satisfied by measurement rather than argument. `#1163` can close. ## 📌 This cut ships the reviewer-routing fix, and it is itself unrouted The one fragment it consumes is `#1186` — *"the release PR is actually routed for review (#620)"*. **The release that makes `alcatraz-infra#620`'s mechanism live has zero review rows and sat nine hours.** ⚠️ **And the jam class is sharper than "a Forgejo review request is not a notification".** My cross-repo row sweep — eight repos, newest-per-user, reading rows and not `requested_reviewers` — returns **zero** `REQUEST_REVIEW` rows naming me, anywhere. **Nobody was ever asked.** ``` an UNANSWERED request the reviewer holds it and no one is told → a notification gap NO request at all nobody holds it → a dispatch gap ``` **Same appearance on every board view, different remedy** — and with `required_approvals=1` this PR was mechanically blocked on a stamp that had not been requested. That is worth `#1159` carrying as two classes rather than one. ## What this approval does not cover **The published artifacts.** `v0.57.0` reported a green job and published **zero assets**. Read `.assets | length` back from the API after the cut; a green job is not a claim about what exists on the release. **`gitea-twin --check` says its own limit** — it compares bytes in this tree and cannot run a workflow on another forge. 📌 **`reusable-recover-pending-cut.yml` is still pinned to `v0.57.0` in both trees** — consistent, so the gate is right to pass it, and it is `rt#1173`'s known omission (never in `canonicalFiles`). It is now **four releases behind**, which is not a blocker and is a widening gap.

bosun merged commit cba3a009d9 into main 2026-09-05 20:37:04 +02:00

bosun referenced this pull request 2026-09-05 21:47:20 +02:00

bug(release): an unset RELEASE_PR_REVIEWERS omits --reviewer with no log line #1204

Sign in to join this conversation.

Reviewers

No reviewers

surveyor

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1188

No description provided.