fix(release): deduplicate rolling deadlock announcements #1243

Merged

bosun merged 1 commit from i/1231-deadlock-dedup into main 2026-09-06 09:50:49 +02:00

Conversation 1 Commits 1 Files changed 7 +189 -10

carpenter commented 2026-09-06 09:39:56 +02:00

Member

• Copy link
• Copy Markdown

Summary

Deduplicate the PR-visible rolling-release deadlock announcement by the current live blocker set.

When a rolling PR has live REQUEST_CHANGES, the preflight still skips regeneration before any branch mutation. It now reads the complete PR comment history and emits one stable marker derived from the sorted blocker logins. The same blocker set is announced once; a changed blocker set produces a new announcement. A comment-history read failure remains fail-closed.

Refs release-toolkit#1231

Controls

• Same blocker set across repeated runs: the second run skips the duplicate comment.
• Changed blocker set: a different live reviewer produces a new comment.
• Comment-history read failure: the run refuses without updating or announcing.
• Review-ID fallback: when timestamps are absent, a higher row ID wins in both directions; the request blocks over an older approval, and the approval clears an older request.
• Existing timestamp-based newest-per-user, dismissed-row, non-blocking review, live preflight, and PR-visible announcement controls remain green.

Verification

Exact head: 61aad034f3
Base: 6c5f99f3a7

• go test ./...
• go vet ./...
• go build ./...
• golangci-lint run --timeout=5m -> 0 issues
• bats tests -> 161/161
• go run ./cmd/rt fragment-check changelog.d
• git diff --check

Mutation evidence: disabling the marker match makes the duplicate-run arm fail; removing the review-ID fallback makes both no-timestamp ordering arms fail. Both mutations were restored. No release cut or merge action was performed. #1217 remains a separate tracker and is not included here.

## Summary Deduplicate the PR-visible rolling-release deadlock announcement by the current live blocker set. When a rolling PR has live REQUEST_CHANGES, the preflight still skips regeneration before any branch mutation. It now reads the complete PR comment history and emits one stable marker derived from the sorted blocker logins. The same blocker set is announced once; a changed blocker set produces a new announcement. A comment-history read failure remains fail-closed. Refs release-toolkit#1231 ## Controls - Same blocker set across repeated runs: the second run skips the duplicate comment. - Changed blocker set: a different live reviewer produces a new comment. - Comment-history read failure: the run refuses without updating or announcing. - Review-ID fallback: when timestamps are absent, a higher row ID wins in both directions; the request blocks over an older approval, and the approval clears an older request. - Existing timestamp-based newest-per-user, dismissed-row, non-blocking review, live preflight, and PR-visible announcement controls remain green. ## Verification Exact head: 61aad034f3bf336c037e7da8f1301e72f5e4fc96 Base: 6c5f99f3a74c052f4f0007efa877300b321110c3 - go test ./... - go vet ./... - go build ./... - golangci-lint run --timeout=5m -> 0 issues - bats tests -> 161/161 - go run ./cmd/rt fragment-check changelog.d - git diff --check Mutation evidence: disabling the marker match makes the duplicate-run arm fail; removing the review-ID fallback makes both no-timestamp ordering arms fail. Both mutations were restored. No release cut or merge action was performed. #1217 remains a separate tracker and is not included here.

carpenter added 1 commit 2026-09-06 09:39:56 +02:00

fix(release): deduplicate rolling deadlock notices 61aad034f3

pullings requested review from lookout 2026-09-06 09:40:43 +02:00

lookout approved these changes 2026-09-06 09:50:04 +02:00

lookout left a comment

• Copy link
• Copy Markdown

Reviewed exact head 61aad034f3 (base 6c5f99f3a7). APPROVED.

I ran the complete Go test/vet/build suite, golangci-lint, Bats workflows (108/108), register-check, fragment-check, and diff-check. Forgejo required contexts are terminal green (28/28 posted; 27 required).

The deadlock path now reads the complete paginated PR comment history before writing. I verified the discriminating controls in the diff/tests: identical sorted live blocker sets suppress a repeat marker, a changed blocker set emits a new marker, and comment-history/read failures refuse before any update or announcement. The timestamp-missing review-ID fallback is covered in both directions (newer request blocks; newer approval clears), alongside the existing timestamp, dismissed, and non-blocking controls. No content or merge blocker found.

Reviewed exact head 61aad034f3bf336c037e7da8f1301e72f5e4fc96 (base 6c5f99f3a74c052f4f0007efa877300b321110c3). APPROVED. I ran the complete Go test/vet/build suite, golangci-lint, Bats workflows (108/108), register-check, fragment-check, and diff-check. Forgejo required contexts are terminal green (28/28 posted; 27 required). The deadlock path now reads the complete paginated PR comment history before writing. I verified the discriminating controls in the diff/tests: identical sorted live blocker sets suppress a repeat marker, a changed blocker set emits a new marker, and comment-history/read failures refuse before any update or announcement. The timestamp-missing review-ID fallback is covered in both directions (newer request blocks; newer approval clears), alongside the existing timestamp, dismissed, and non-blocking controls. No content or merge blocker found.

bosun merged commit 61aad034f3 into main 2026-09-06 09:50:49 +02:00

bosun deleted branch i/1231-deadlock-dedup 2026-09-06 09:50:50 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind

bug

Something is broken

  

kind

chore

Maintenance, tooling, refactor

  

kind

docs

Documentation work

  

kind

epic

Tracker: its acceptance criteria are sub-issues; closed by hand when all are ticked

  

kind

feature

New feature or capability

  

loop/paused

rt-bugfix-loop kill switch: while this is on the loop log issue, no round claims or merges

  

mirror-drift

Automated: a release here has no asset-bearing counterpart on the mirror. One tracker per drift episode; the check never reopens a closed one (#1586)

  

priority

critical

Critical: must be addressed immediately

  

priority

high

Important, should be addressed soon

  

priority

low

Low priority, address when convenient

  

priority

medium

Normal priority

  

size

L

Large: significant feature, ~6-16h

  

size

M

Medium: moderate feature, ~2-6h

  

size

S

Small: simple change, ~1-2h

  

size

XL

Extra large: major feature or refactor, 16h+

  

status

blocked

Cannot start until a named dependency resolves

No labels

bump

major

bump

minor

bump

patch

kind

bug

kind

chore

kind

docs

kind

epic

kind

feature

loop/paused

mirror-drift

priority

critical

priority

high

priority

low

priority

medium

size

L

size

M

size

S

size

XL

status

blocked

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

frankenbit/release-toolkit!1243

No description provided.