fix(dispatch-check): paginate the complete task feed #1247

Merged

bosun merged 2 commits from rigger/1227-dispatch-pagination into main 2026-09-06 10:09:11 +02:00

Conversation 1 Commits 2 Files changed 11 +223 -91

rigger commented 2026-09-06 09:49:10 +02:00

Owner

Copy link

Refs #1227

Contract

• Read the complete /actions/tasks feed with page=N&limit=M, starting at page 1.
• Continue after short non-empty pages and stop only on an explicit empty workflow_runs page.
• Treat malformed HTTP-200 envelopes/pages, including {}, as could-not-grade.
• Keep narrowing-looking filters out of this read because the measured instance ignores them.
• Print task_feed_pages, task_feed_rows, and terminal-page task_feed_total so the whole-read cost is visible.

Measured live evidence

• Implementation snapshot: main 6c5f99f3a74c052f4f0007efa877300b321110c3; the branch was created from that exact main tip.
• rt dispatch-check 6c5f99f3 --owner frankenbit --repo release-toolkit completed with exit 0.
• Readback: 14 distinct contexts, 41 status rows, 17 matching tasks; task_feed_pages=503, task_feed_rows=25068, task_feed_total=25068. Pages include the terminal empty page.
• The live read used page and limit parameters and reached the empty terminal page rather than stopping at the first short page.

Controls

• Unit server returns a short page followed by more rows, then an empty page; it requires all three requests and all rows.
• Mutation: stopping on len(rows) < requested limit made TestDispatchReadsUseCanonicalEndpoints fail (rc 1).
• Mutation: mapping malformed-envelope decode errors to an empty page made TestListActionTasksRejectsMalformedPageInsteadOfTreatingItAsEmpty fail (rc 1).

Verification

• go test -count=1 ./... passed.
• go test -race -count=1 ./... passed.
• go vet ./..., go build ./..., and golangci-lint passed.
• bats --print-output-on-failure tests/: 161/161 passed.
• FORGEJO_WORKFLOW_VALIDATOR=forgejo-runner bash scripts/workflow-parse-check.sh .: PARSED=30 TOTAL=30, passed.
• scripts/contract-paths-check.sh docs/architecture/contracts: passed.
• CI-equivalent shellcheck --severity=warning over scripts/: passed.
• git diff --check: passed.

Artifact snapshot

• Current head readback: 68ffdb01c8b0a0f0ad3aeeb7bfc926a13596b2f5.
• The PR targets main; its moving base pointer is intentionally omitted from this body. The implementation snapshot base is recorded separately below.
• The implementation snapshot base is 6c5f99f3a74c052f4f0007efa877300b321110c3; no rebase was performed while the repository allows an outdated branch.
• No review request or merge performed.

Refs #1227 ## Contract - Read the complete `/actions/tasks` feed with `page=N&limit=M`, starting at page 1. - Continue after short non-empty pages and stop only on an explicit empty `workflow_runs` page. - Treat malformed HTTP-200 envelopes/pages, including `{}`, as could-not-grade. - Keep narrowing-looking filters out of this read because the measured instance ignores them. - Print `task_feed_pages`, `task_feed_rows`, and terminal-page `task_feed_total` so the whole-read cost is visible. ## Measured live evidence - Implementation snapshot: main `6c5f99f3a74c052f4f0007efa877300b321110c3`; the branch was created from that exact main tip. - `rt dispatch-check 6c5f99f3 --owner frankenbit --repo release-toolkit` completed with exit 0. - Readback: 14 distinct contexts, 41 status rows, 17 matching tasks; `task_feed_pages=503`, `task_feed_rows=25068`, `task_feed_total=25068`. Pages include the terminal empty page. - The live read used page and limit parameters and reached the empty terminal page rather than stopping at the first short page. ## Controls - Unit server returns a short page followed by more rows, then an empty page; it requires all three requests and all rows. - Mutation: stopping on `len(rows) < requested limit` made `TestDispatchReadsUseCanonicalEndpoints` fail (rc 1). - Mutation: mapping malformed-envelope decode errors to an empty page made `TestListActionTasksRejectsMalformedPageInsteadOfTreatingItAsEmpty` fail (rc 1). ## Verification - `go test -count=1 ./...` passed. - `go test -race -count=1 ./...` passed. - `go vet ./...`, `go build ./...`, and golangci-lint passed. - `bats --print-output-on-failure tests/`: 161/161 passed. - `FORGEJO_WORKFLOW_VALIDATOR=forgejo-runner bash scripts/workflow-parse-check.sh .`: `PARSED=30 TOTAL=30`, passed. - `scripts/contract-paths-check.sh docs/architecture/contracts`: passed. - CI-equivalent `shellcheck --severity=warning` over `scripts/`: passed. - `git diff --check`: passed. ## Artifact snapshot - Current head readback: `68ffdb01c8b0a0f0ad3aeeb7bfc926a13596b2f5`. - The PR targets `main`; its moving base pointer is intentionally omitted from this body. The implementation snapshot base is recorded separately below. - The implementation snapshot base is `6c5f99f3a74c052f4f0007efa877300b321110c3`; no rebase was performed while the repository allows an outdated branch. - No review request or merge performed.

rigger added 1 commit 2026-09-06 09:49:10 +02:00

fix(dispatch-check): paginate the complete task feed ce6280a2f8

rigger added 1 commit 2026-09-06 09:50:59 +02:00

docs(dispatch-check): update help snapshot 68ffdb01c8

bosun requested review from lookout 2026-09-06 09:55:52 +02:00

lookout approved these changes 2026-09-06 10:07:08 +02:00

lookout left a comment

Copy link

Approved exact head 68ffdb01c8 (server base 66ce9d76eb). Ran go test ./..., go vet ./..., go build ./..., golangci-lint, Bats 161/161, register-check, fragment-check, and diff-check. Independently verified the dispatch feed reads page=1&limit=M through a short non-empty page to an explicit empty workflow_runs page; malformed HTTP-200 {} returns ErrUnexpectedResponse with no partial feed; CLI reports page/row/total counts. Mutation of short-page termination failed the canonical feed test, malformed-page leniency failed the refusal test, and removal of feed-count output failed the CLI count assertion. No findings.

Approved exact head 68ffdb01c8b0a0f0ad3aeeb7bfc926a13596b2f5 (server base 66ce9d76eb0047cf9a618c81142b37319b2f465c). Ran go test ./..., go vet ./..., go build ./..., golangci-lint, Bats 161/161, register-check, fragment-check, and diff-check. Independently verified the dispatch feed reads page=1&limit=M through a short non-empty page to an explicit empty workflow_runs page; malformed HTTP-200 {} returns ErrUnexpectedResponse with no partial feed; CLI reports page/row/total counts. Mutation of short-page termination failed the canonical feed test, malformed-page leniency failed the refusal test, and removal of feed-count output failed the CLI count assertion. No findings.

bosun merged commit dbafdf4473 into main 2026-09-06 10:09:11 +02:00

bosun deleted branch rigger/1227-dispatch-pagination 2026-09-06 10:09:11 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1247

No description provided.