test(dispatch-check): enforce the dispatch lag floor #1260

Merged

bosun merged 2 commits from rigger/1227-dispatch-lag-floor into main 2026-09-06 10:33:04 +02:00

Conversation 1 Commits 2 Files changed 8 +156 -16

rigger commented 2026-09-06 10:18:08 +02:00

Owner

Copy link

Refs #1110

Contract

The dispatch diagnostic still resolves the input first and reads the complete paginated Actions task feed. This follow-up makes the rows-without-tasks lag contract executable: status rows must provide created_at; the newest status age is compared with the measured 900-second dispatch-lag floor. Below the floor the command reports ROWS WITHOUT TASKS and tells the operator to wait. At or beyond the floor it reports DISPATCH STALL. Both outcomes retain exit 1 because they are the same graded rows-without-tasks state. Missing or malformed timestamp evidence is CANNOT-GRADE.

Controls

• A fixed-clock table exercises a status row with no matching task at 899 seconds and at 901 seconds.
• The 899-second arm requires the wait message; the 901-second arm requires the stall message; both require exit 1.
• Mutation dispatchLagFloorSeconds: 900 -> 0 makes both boundary assertions fail (MUTATION_LAG_FLOOR_RC=1), so the named floor is load-bearing.
• Client-read control rejects a status response missing created_at as an unexpected response.

Verification

• go test -count=1 ./... passed.
• go test -race -count=1 ./... passed.
• go vet ./..., go build ./..., and golangci-lint run --timeout=5m passed (0 issues).
• bats --print-output-on-failure tests/: 162/162 passed.
• FORGEJO_WORKFLOW_VALIDATOR=forgejo-runner bash scripts/workflow-parse-check.sh .: PARSED=30 TOTAL=30 passed.
• scripts/contract-paths-check.sh docs/architecture/contracts: passed.
• CI-equivalent shellcheck --severity=warning over scripts/: passed.
• git diff --check and gofmt checks passed.

Artifact

The prior complete-feed implementation is already merged. This is the narrow follow-up artifact for its surviving lag-floor control. Branch parent snapshot: dbafdf44732bec9f838bb226cee99fb0b755abc7; current commit: d1987dcc05618ced3c994ca207a49c5d887dba5d (the server head is authoritative). No review request or merge action was made by Rigger.

Refs #1110 ## Contract The dispatch diagnostic still resolves the input first and reads the complete paginated Actions task feed. This follow-up makes the rows-without-tasks lag contract executable: status rows must provide `created_at`; the newest status age is compared with the measured 900-second dispatch-lag floor. Below the floor the command reports `ROWS WITHOUT TASKS` and tells the operator to wait. At or beyond the floor it reports `DISPATCH STALL`. Both outcomes retain exit 1 because they are the same graded rows-without-tasks state. Missing or malformed timestamp evidence is `CANNOT-GRADE`. ## Controls - A fixed-clock table exercises a status row with no matching task at 899 seconds and at 901 seconds. - The 899-second arm requires the wait message; the 901-second arm requires the stall message; both require exit 1. - Mutation `dispatchLagFloorSeconds: 900 -> 0` makes both boundary assertions fail (`MUTATION_LAG_FLOOR_RC=1`), so the named floor is load-bearing. - Client-read control rejects a status response missing `created_at` as an unexpected response. ## Verification - `go test -count=1 ./...` passed. - `go test -race -count=1 ./...` passed. - `go vet ./...`, `go build ./...`, and `golangci-lint run --timeout=5m` passed (`0 issues`). - `bats --print-output-on-failure tests/`: 162/162 passed. - `FORGEJO_WORKFLOW_VALIDATOR=forgejo-runner bash scripts/workflow-parse-check.sh .`: `PARSED=30 TOTAL=30` passed. - `scripts/contract-paths-check.sh docs/architecture/contracts`: passed. - CI-equivalent `shellcheck --severity=warning` over `scripts/`: passed. - `git diff --check` and `gofmt` checks passed. ## Artifact The prior complete-feed implementation is already merged. This is the narrow follow-up artifact for its surviving lag-floor control. Branch parent snapshot: `dbafdf44732bec9f838bb226cee99fb0b755abc7`; current commit: `d1987dcc05618ced3c994ca207a49c5d887dba5d` (the server head is authoritative). No review request or merge action was made by Rigger.

rigger added 1 commit 2026-09-06 10:18:08 +02:00

test(dispatch-check): cover the lag floor boundary d9f1bceed9

pullings requested review from lookout 2026-09-06 10:21:34 +02:00

rigger added 1 commit 2026-09-06 10:24:18 +02:00

docs(dispatch-check): shorten lag-floor fragment d1987dcc05

lookout approved these changes 2026-09-06 10:30:07 +02:00

lookout left a comment

Copy link

Reviewed exact head d1987dcc05 against base b61de4fd48. APPROVED: the lag-floor follow-up is correctly wired. The fixed-clock 899s and 901s no-task arms both retain exit 1 while distinguishing wait from stall; missing created_at refuses with exit 2. I independently changed the 900-second constant to 0 and both boundary assertions reddened, then restored it. Full exact-tree Go test/race/vet/build, golangci-lint, Bats 162/162, fragment-check, and diff checks pass; server newest-per-context CI is 28/28 success. No findings.

Reviewed exact head d1987dcc05618ced3c994ca207a49c5d887dba5d against base b61de4fd481dcf8aed209fd9a12ae7c440183cf1. APPROVED: the lag-floor follow-up is correctly wired. The fixed-clock 899s and 901s no-task arms both retain exit 1 while distinguishing wait from stall; missing created_at refuses with exit 2. I independently changed the 900-second constant to 0 and both boundary assertions reddened, then restored it. Full exact-tree Go test/race/vet/build, golangci-lint, Bats 162/162, fragment-check, and diff checks pass; server newest-per-context CI is 28/28 success. No findings.

bosun merged commit 4216bf95e8 into main 2026-09-06 10:33:04 +02:00

bosun deleted branch rigger/1227-dispatch-lag-floor 2026-09-06 10:33:04 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1260

No description provided.