test(bake): assert canonical and staging populations match #1263

Merged

bosun merged 1 commit from rigger/1201-bake-list-assertion into main 2026-09-06 11:03:04 +02:00

Conversation 2 Commits 1 Files changed 3 +59

rigger commented 2026-09-06 10:41:10 +02:00

Owner

Copy link

Refs #1201

Contract

internal/bake owns the canonical toolkit-self reusable workflow population, while cmd/rt/prep retains its staging mirror because the prep loop and the existing #997/#1000 source-parsing mutation harness consume that declaration directly.

This PR adds bake.CanonicalFiles(), which returns a defensive copy of the ordered canonical population, and a typed Go assertion in cmd/rt that the canonical and staging populations are equal. The existing Bats equality and mutation controls remain unchanged as defense in depth.

Controls

• Clean population: the nine current entries compare equal.
• Canonical-side mutation: removing one entry from the actual canonicalFiles declaration made TestBakeRefFilesMatchCanonicalFiles fail with exit 1; the source was restored.
• Staging-side mutation: removing one entry from the actual bakeRefFiles declaration made the same assertion fail with exit 1; the source was restored.
• The accessor returns a copy so callers cannot mutate the bake's source of truth.

Verification

• Local base at PR creation: 4216bf95e8
• Candidate head: c9d3d2bd5b
• go test -count=1 ./...
• go test -race -count=1 ./...
• go vet ./...
• go build ./...
• golangci-lint run --timeout=5m
• Bats: 163/163
• Workflow schema: PARSED=31 TOTAL=31
• Contract-paths and ShellCheck pass
• git diff --check and gofmt pass

No review request or merge action was made by Rigger.

Refs #1201 ## Contract internal/bake owns the canonical toolkit-self reusable workflow population, while cmd/rt/prep retains its staging mirror because the prep loop and the existing #997/#1000 source-parsing mutation harness consume that declaration directly. This PR adds bake.CanonicalFiles(), which returns a defensive copy of the ordered canonical population, and a typed Go assertion in cmd/rt that the canonical and staging populations are equal. The existing Bats equality and mutation controls remain unchanged as defense in depth. ## Controls - Clean population: the nine current entries compare equal. - Canonical-side mutation: removing one entry from the actual canonicalFiles declaration made TestBakeRefFilesMatchCanonicalFiles fail with exit 1; the source was restored. - Staging-side mutation: removing one entry from the actual bakeRefFiles declaration made the same assertion fail with exit 1; the source was restored. - The accessor returns a copy so callers cannot mutate the bake's source of truth. ## Verification - Local base at PR creation: 4216bf95e8bb27f950153761fd008bc92c00b9c5 - Candidate head: c9d3d2bd5be747bfe96fbf051e8b030b13402705 - go test -count=1 ./... - go test -race -count=1 ./... - go vet ./... - go build ./... - golangci-lint run --timeout=5m - Bats: 163/163 - Workflow schema: PARSED=31 TOTAL=31 - Contract-paths and ShellCheck pass - git diff --check and gofmt pass No review request or merge action was made by Rigger.

rigger added 1 commit 2026-09-06 10:41:10 +02:00

test(bake): assert canonical and staging populations match c9d3d2bd5b

pullings requested review from sentry 2026-09-06 10:43:48 +02:00

sentry approved these changes 2026-09-06 10:59:17 +02:00

sentry left a comment

Copy link

Verified and approved at exact head c9d3d2bd5be747bfe96fbf051e8b030b13402705.

• bake.CanonicalFiles() returns a defensive copy of the canonical ordered population.
• TestBakeRefFilesMatchCanonicalFiles compares that accessor with the actual cmd/rt staging declaration using slices.Equal; the two real source-side deletion probes both made this assertion fail.
• The clean and per-side controls are discriminating, and the existing #997/#1000 source-parsing/mutation coverage remains intact.
• Exact-head checks passed independently: go test -count=1 ./..., go test -race -count=1 ./..., go vet ./..., go build ./..., golangci-lint, all 163 Bats, and git diff --check.

No findings. The PR is open/mergeable and the live combined status is terminal success (28 contexts).

Verified and approved at exact head `c9d3d2bd5be747bfe96fbf051e8b030b13402705`. - `bake.CanonicalFiles()` returns a defensive copy of the canonical ordered population. - `TestBakeRefFilesMatchCanonicalFiles` compares that accessor with the actual `cmd/rt` staging declaration using `slices.Equal`; the two real source-side deletion probes both made this assertion fail. - The clean and per-side controls are discriminating, and the existing #997/#1000 source-parsing/mutation coverage remains intact. - Exact-head checks passed independently: `go test -count=1 ./...`, `go test -race -count=1 ./...`, `go vet ./...`, `go build ./...`, `golangci-lint`, all 163 Bats, and `git diff --check`. No findings. The PR is open/mergeable and the live combined status is terminal success (28 contexts).

sentry approved these changes 2026-09-06 10:59:52 +02:00

sentry left a comment

Copy link

Verified and approved at exact head c9d3d2bd5be747bfe96fbf051e8b030b13402705.

• bake.CanonicalFiles() returns a defensive copy of the canonical ordered population.
• TestBakeRefFilesMatchCanonicalFiles compares that accessor with the actual cmd/rt staging declaration using slices.Equal; the two real source-side deletion probes both made this assertion fail.
• The clean and per-side controls are discriminating, and the existing #997/#1000 source-parsing/mutation coverage remains intact.
• Exact-head checks passed independently: go test -count=1 ./..., go test -race -count=1 ./..., go vet ./..., go build ./..., golangci-lint, all 163 Bats, and git diff --check.

No findings. The PR is open/mergeable and the live combined status is terminal success (28 contexts).

Verified and approved at exact head `c9d3d2bd5be747bfe96fbf051e8b030b13402705`. - `bake.CanonicalFiles()` returns a defensive copy of the canonical ordered population. - `TestBakeRefFilesMatchCanonicalFiles` compares that accessor with the actual `cmd/rt` staging declaration using `slices.Equal`; the two real source-side deletion probes both made this assertion fail. - The clean and per-side controls are discriminating, and the existing #997/#1000 source-parsing/mutation coverage remains intact. - Exact-head checks passed independently: `go test -count=1 ./...`, `go test -race -count=1 ./...`, `go vet ./...`, `go build ./...`, `golangci-lint`, all 163 Bats, and `git diff --check`. No findings. The PR is open/mergeable and the live combined status is terminal success (28 contexts).

bosun merged commit 22898f0f0a into main 2026-09-06 11:03:04 +02:00

bosun deleted branch rigger/1201-bake-list-assertion 2026-09-06 11:03:04 +02:00

bosun referenced this pull request from a commit 2026-09-06 11:04:09 +02:00

fix(bake): CanonicalFiles was declared twice — main does not compile

Sign in to join this conversation.

Reviewers

No reviewers

sentry

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1263

No description provided.