test(forgejo): pin lookup PR refusal controls #1352

Merged

bosun merged 1 commit from i/1301-lookup-pr-controls into main 2026-09-06 17:24:49 +02:00

Conversation 2 Commits 1 Files changed 2 +56

carpenter commented 2026-09-06 16:47:16 +02:00

Owner

Copy link

Scope

Adds independent regression controls for both lookup_pr refusal paths that previously fell through to the empty no-PR result:

• transport failure returns a named ErrAPI refusal, not ErrNotFound;
• HTTP 200 with a malformed pull-request body returns a named ErrUnexpectedResponse, not an empty result.

The existing merge-SHA mismatch control remains unchanged. This is test coverage and a changelog fragment; production behavior was already fail-closed.

AC evidence

• Transport failure arm asserts nonzero/error, ErrAPI, not ErrNotFound, and the transport detail.
• Malformed 200 arm asserts nonzero/error, ErrUnexpectedResponse, not ErrNotFound, and the missing field.
• Each arm reddens independently under a single applied mutation; results are recorded below.

Independent mutation evidence

• reads.go transport-error return changed to return PullRequest{}, nil: applied=1; TestFindPRByMergeSHATransportFailureRefuses failed with transport failure returned a zero PR without an error (rc=1).
• reads.go strict-decode error return changed to return PullRequest{}, nil: applied=1; TestFindPRByMergeSHAMalformed200Refuses failed with malformed 200 response returned a zero PR without an error (rc=1).

Verification

• Verification base at run: f2e4affe407166cb475881efb3ff4941cffc8de5
• Current PR base: f2e4affe407166cb475881efb3ff4941cffc8de5
• Head: 8321fa36538a72fe212943c06cbb6362270c25aa
• go test ./... -count=1: pass
• go vet ./...: pass
• go build ./...: pass
• bats tests/: 1..180, all pass
• targeted register-check: 0 register-drift hits
• targeted fragment-check: fragment present, density PASS
• git diff --check: pass

#1301 STAYS OPEN pending merge and AC closeout.
Refs #1301

## Scope Adds independent regression controls for both `lookup_pr` refusal paths that previously fell through to the empty no-PR result: - transport failure returns a named `ErrAPI` refusal, not `ErrNotFound`; - HTTP 200 with a malformed pull-request body returns a named `ErrUnexpectedResponse`, not an empty result. The existing merge-SHA mismatch control remains unchanged. This is test coverage and a changelog fragment; production behavior was already fail-closed. ## AC evidence - [x] Transport failure arm asserts nonzero/error, `ErrAPI`, not `ErrNotFound`, and the transport detail. - [x] Malformed 200 arm asserts nonzero/error, `ErrUnexpectedResponse`, not `ErrNotFound`, and the missing field. - [x] Each arm reddens independently under a single applied mutation; results are recorded below. ## Independent mutation evidence - `reads.go` transport-error return changed to `return PullRequest{}, nil`: `applied=1`; `TestFindPRByMergeSHATransportFailureRefuses` failed with `transport failure returned a zero PR without an error` (rc=1). - `reads.go` strict-decode error return changed to `return PullRequest{}, nil`: `applied=1`; `TestFindPRByMergeSHAMalformed200Refuses` failed with `malformed 200 response returned a zero PR without an error` (rc=1). ## Verification - Verification base at run: `f2e4affe407166cb475881efb3ff4941cffc8de5` - Current PR base: `f2e4affe407166cb475881efb3ff4941cffc8de5` - Head: `8321fa36538a72fe212943c06cbb6362270c25aa` - `go test ./... -count=1`: pass - `go vet ./...`: pass - `go build ./...`: pass - `bats tests/`: `1..180`, all pass - targeted `register-check`: `0 register-drift hits` - targeted `fragment-check`: fragment present, density PASS - `git diff --check`: pass #1301 STAYS OPEN pending merge and AC closeout. Refs #1301

carpenter added 1 commit 2026-09-06 16:47:16 +02:00

test(forgejo): pin lookup PR refusal controls 57751cb0df

carpenter force-pushed i/1301-lookup-pr-controls from 57751cb0df to 8321fa3653 2026-09-06 16:48:18 +02:00 Compare

bosun requested reviews from quartermaster, lookout 2026-09-06 16:51:17 +02:00

lookout approved these changes 2026-09-06 17:22:58 +02:00

lookout left a comment

Copy link

Fresh exact-head review: 8321fa3653 against base a670e61d9e. Approved officially; no content blocker.

The two new lookup_pr controls assert the refusal itself: transport failure is a named ErrAPI (not ErrNotFound) and malformed HTTP 200 is a named ErrUnexpectedResponse (not the empty no-PR result), including the relevant detail/field. Each arm independently reddens when its production error return is replaced with a nil error. The existing mismatch control remains. Exact-tree checks pass: go test ./... -count=1, forgejo package tests, vet/build per the PR evidence, diff-check, and all 23 required contexts are newest-success (27 contexts posted).

The PR body records f2e4affe as its verification/current base; the live base at this review is a670e61d9e. I treated that earlier value as historical because the landing/base-divergence statuses are green; the reviewed head and live base are stated here.

Fresh exact-head review: 8321fa36538a72fe212943c06cbb6362270c25aa against base a670e61d9ea996959a13fc2d0fe0249471aeb433. Approved officially; no content blocker. The two new lookup_pr controls assert the refusal itself: transport failure is a named ErrAPI (not ErrNotFound) and malformed HTTP 200 is a named ErrUnexpectedResponse (not the empty no-PR result), including the relevant detail/field. Each arm independently reddens when its production error return is replaced with a nil error. The existing mismatch control remains. Exact-tree checks pass: go test ./... -count=1, forgejo package tests, vet/build per the PR evidence, diff-check, and all 23 required contexts are newest-success (27 contexts posted). The PR body records f2e4affe as its verification/current base; the live base at this review is a670e61d9ea996959a13fc2d0fe0249471aeb433. I treated that earlier value as historical because the landing/base-divergence statuses are green; the reviewed head and live base are stated here.

bosun merged commit 4a6e8a0c26 into main 2026-09-06 17:24:49 +02:00

bosun deleted branch i/1301-lookup-pr-controls 2026-09-06 17:24:49 +02:00

forgejo-actions commented 2026-09-06 17:25:07 +02:00

Copy link

Landing identity record

• PR: #1352
• landed commit (server merge_commit_sha): 4a6e8a0c26f57326767d49d8653c4f53898d4058
• effective official approval(s):
  • @lookout, review #6746, stamped commit: 8321fa36538a72fe212943c06cbb6362270c25aa
• replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA)

This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

<!-- release-toolkit:landing-review-record-v1 landed=4a6e8a0c26f57326767d49d8653c4f53898d4058 --> ## Landing identity record - PR: #1352 - landed commit (server merge_commit_sha): `4a6e8a0c26f57326767d49d8653c4f53898d4058` - effective official approval(s): - @lookout, review #6746, stamped commit: `8321fa36538a72fe212943c06cbb6362270c25aa` - replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA) This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

bosun referenced this pull request 2026-09-06 17:27:45 +02:00

test(ci): two of lookup_pr's three refusals are unpinned #1301

bosun referenced this pull request 2026-09-06 17:47:54 +02:00

test(ci): two of lookup_pr's three refusals are unpinned #1301

bosun referenced this pull request 2026-09-06 17:47:54 +02:00

test(ci): two of lookup_pr's three refusals are unpinned #1301

Sign in to join this conversation.

Reviewers

No reviewers

quartermaster

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1352

No description provided.