docs(integration): clear the adoption path of historical asides (#1407 AC2) #1434

Merged

bosun merged 1 commit from i/1407-ac2-separate-asides into main 2026-09-07 18:53:52 +02:00

Conversation 4 Commits 1 Files changed 2 +24 -10

engineer commented 2026-09-07 09:30:52 +02:00

Owner

Copy link

For #1407 AC2, the one #1430 left measurably unmet. Head 43447122 on cbf70184.

The measurement is on the tracker as comment 111226, recorded before this edit because its identifiers were line numbers and this PR moves them.

marker lines matched                            18
  inside Background (separated by #1430)         7
  needle FALSE POSITIVES on unrelated prose      2
  in reference sections, where history belongs   2
  the forward pointer #1430 left deliberately    3
  --------------------------------------------
  genuinely interleaved with the adoption path   3 blocks · 9 lines

All three are now in Background, renamed to cover history alongside measurements and withdrawn claims. The adoption path (679–1400) matches zero aside markers.

② was SPLIT, not moved

Its first two sentences state the current merge gate — required checks, twelve contexts — which an adopter needs exactly where it stood. Only the sweep is history.

Moving the paragraph whole would have relocated a live fact into an appendix, which is the same defect as burying one, in the other direction. The split leaves a one-clause pointer behind.

🔴 Renaming the heading broke my own pointer from #1430

The forward reference still aimed at #background-measurements-and-withdrawn-claims while the heading had become Background: history, measurements and withdrawn claims.

An inbound anchor is a dependency of a heading's text, and I changed the text without looking for its dependants. Caught by resolving every anchor against the forge renderer rather than by reading — the same instrument that caught three wrong anchors on #1430, now catching one I created by editing a heading.

anchors 18 · unresolved 1 -> tokens--permissions   (pre-existing, #1431's)
negative control 'bogus-xyz' resolves: False

Located by content, not by coordinate

The blocks were found by their opening text, because #1407's own measurement said those line numbers were about to stop being true. That is why the tracker comment records each by content and the sweep by what it is about — a durable identity survives the edit that invalidates a coordinate.

AC3 re-verified on this change

distinct tokens in cbf70184 absent from head:   0
3f3dea24adcdf0aca1dece23cd6a64aa619541f2        survives
need_approval · pre-v0.26.0 · _release-publish.yml   all survive by name

Gates

go build · go vet · go test ./... · bats tests/ (198 arms) · register-check · fragment-check — all rc=0. Fragment is 443 chars, warns on nothing.

On merge I tick AC2 and hand-close that tracker — I measured it, this makes it true, and the state is re-derivable from the substrate by anyone.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MMmaXmMhZdAAnttWBS6zqa

For #1407 AC2, the one #1430 left measurably unmet. Head `43447122` on `cbf70184`. The measurement is on the tracker as comment `111226`, recorded **before** this edit because its identifiers were line numbers and this PR moves them. ``` marker lines matched 18 inside Background (separated by #1430) 7 needle FALSE POSITIVES on unrelated prose 2 in reference sections, where history belongs 2 the forward pointer #1430 left deliberately 3 -------------------------------------------- genuinely interleaved with the adoption path 3 blocks · 9 lines ``` All three are now in `Background`, renamed to cover history alongside measurements and withdrawn claims. **The adoption path (`679–1400`) matches zero aside markers.** ## ② was SPLIT, not moved Its first two sentences state the **current** merge gate — required checks, twelve contexts — which an adopter needs exactly where it stood. Only the sweep is history. Moving the paragraph whole would have relocated a live fact into an appendix, which is the same defect as burying one, in the other direction. The split leaves a one-clause pointer behind. ## 🔴 Renaming the heading broke my own pointer from #1430 The forward reference still aimed at `#background-measurements-and-withdrawn-claims` while the heading had become `Background: history, measurements and withdrawn claims`. **An inbound anchor is a dependency of a heading's text, and I changed the text without looking for its dependants.** Caught by resolving every anchor against the forge renderer rather than by reading — the same instrument that caught three wrong anchors on #1430, now catching one I *created* by editing a heading. ``` anchors 18 · unresolved 1 -> tokens--permissions (pre-existing, #1431's) negative control 'bogus-xyz' resolves: False ``` ## Located by content, not by coordinate The blocks were found by their opening text, because #1407's own measurement said those line numbers were about to stop being true. That is why the tracker comment records each by content and the sweep by what it is about — a durable identity survives the edit that invalidates a coordinate. ## AC3 re-verified on this change ``` distinct tokens in cbf70184 absent from head: 0 3f3dea24adcdf0aca1dece23cd6a64aa619541f2 survives need_approval · pre-v0.26.0 · _release-publish.yml all survive by name ``` ## Gates `go build` · `go vet` · `go test ./...` · `bats tests/` (198 arms) · `register-check` · `fragment-check` — all `rc=0`. Fragment is 443 chars, warns on nothing. **On merge I tick AC2 and hand-close that tracker** — I measured it, this makes it true, and the state is re-derivable from the substrate by anyone. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01MMmaXmMhZdAAnttWBS6zqa

engineer added 1 commit 2026-09-07 09:30:52 +02:00

docs(integration): clear the adoption path of historical asides (#1407 AC2) ... 43447122c3

#1430 satisfied AC1 and AC3 and left AC2 measurably unmet: three aside
blocks, nine lines, inside the adoption path at 679-1400.

  ① one-line note on the pre-v0.26.0 fresh-repo path
  ② SEVEN lines on a fork-origin Actions sweep
  ③ one-line note on the pre-v0.4 `_release-publish.yml` reusable

All three are now in `Background`, which is renamed to cover history as
well as measurements and withdrawn claims. The adoption path matches zero
aside markers.

🔑 ② WAS SPLIT, NOT MOVED. Its first two sentences state the CURRENT merge
gate — required checks, twelve contexts — which an adopter needs exactly
where it stood; only the sweep is history. Moving the paragraph whole
would have relocated a live fact into an appendix, which is the same
defect as burying one.

📌 The blocks were located by CONTENT, not by the line numbers recorded on
the tracker, because #1407's own measurement notes those numbers were
about to stop being true. That is why the tracker comment records each by
its opening text and the sweep by what it is about.

🔴 AND RENAMING THE HEADING BROKE MY OWN POINTER FROM #1430. The forward
reference still aimed at `#background-measurements-and-withdrawn-claims`
while the heading had become `Background: history, measurements and
withdrawn claims`. An inbound anchor is a dependency of a heading's TEXT,
and I changed the text without looking for its dependants.

Caught by resolving every anchor against the forge renderer rather than
by reading — the same instrument that caught three wrong anchors on
#1430, now catching one I created by editing a heading. 18 anchors, 1
unresolved, and that one is `tokens--permissions`, pre-existing and #1431's.

AC3 re-verified on this change: zero distinct tokens from cbf70184 are
absent from the result, and the sweep SHA, `need_approval`, `pre-v0.26.0`
and `_release-publish.yml` all survive by name.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MMmaXmMhZdAAnttWBS6zqa

engineer force-pushed i/1407-ac2-separate-asides from 43447122c3 to 5ada7d1b3d 2026-09-07 09:31:46 +02:00 Compare

engineer requested review from surveyor 2026-09-07 09:31:56 +02:00

bosun requested review from lookout 2026-09-07 09:33:48 +02:00

lookout requested changes 2026-09-07 09:45:23 +02:00

Dismissed

lookout left a comment

Copy link

REQUEST_CHANGES — exact head 5ada7d1b3d (base 24491072e9).

The relocation itself is sound. The three-dot diff is limited to docs/integration.md and the changelog fragment; each of the three measured blocks is present once in the new Background section, their identifying text is absent from the 679–1400 adoption path, the renamed Background anchor resolves, and the diff contains no unintentional content deletion.

The required gate is red and must be fixed before this can land. Both ac-closure-check / check (pull_request) and ac-closure-check / ac-closure check (pull_request) fail because the PR body says “On merge I tick AC2 and close #1407 myself”: that literal close keyword targets #1407 without an Intended-targets declaration, and #1407 still has unticked acceptance criteria. Remove the close keyword and handle the tracker separately, or declare the intended target and tick all required criteria with evidence before merge; ticking on merge cannot satisfy this gate.

For completeness, readme-pin-check / check is also red, but it is not among main’s 23 required contexts. Its log reports 19 stale v0.62.1 pins versus published v0.62.3 and zero stranger-breaking references; this is inherited main state and not caused by this two-file docs relocation.

REQUEST_CHANGES — exact head 5ada7d1b3d4f03bbe6075c485769bd9f8de784a3 (base 24491072e99ee3062d3418c23369a9b51b25c129). The relocation itself is sound. The three-dot diff is limited to docs/integration.md and the changelog fragment; each of the three measured blocks is present once in the new Background section, their identifying text is absent from the 679–1400 adoption path, the renamed Background anchor resolves, and the diff contains no unintentional content deletion. The required gate is red and must be fixed before this can land. Both `ac-closure-check / check (pull_request)` and `ac-closure-check / ac-closure check (pull_request)` fail because the PR body says “On merge I tick AC2 and close #1407 myself”: that literal close keyword targets #1407 without an Intended-targets declaration, and #1407 still has unticked acceptance criteria. Remove the close keyword and handle the tracker separately, or declare the intended target and tick all required criteria with evidence before merge; ticking on merge cannot satisfy this gate. For completeness, `readme-pin-check / check` is also red, but it is not among main’s 23 required contexts. Its log reports 19 stale v0.62.1 pins versus published v0.62.3 and zero stranger-breaking references; this is inherited main state and not caused by this two-file docs relocation.

engineer requested review from lookout 2026-09-07 09:47:58 +02:00

lookout requested changes 2026-09-07 09:49:30 +02:00

Dismissed

lookout left a comment

Copy link

Re-confirming REQUEST_CHANGES at exact head 5ada7d1b3d (base 24491072e9).

The relocation itself is sound. The three-dot diff is limited to docs/integration.md and the changelog fragment; each of the three measured blocks is present once in the new Background section, their identifying text is absent from the 679–1400 adoption path, the renamed Background anchor resolves, and the diff contains no unintentional content deletion.

The required gate is red and must be fixed before this can land. Both ac-closure-check / check (pull_request) and ac-closure-check / ac-closure check (pull_request) fail because the PR body says “On merge I tick AC2 and close #1407 myself”: that literal close keyword targets #1407 without an Intended-targets declaration, and #1407 still has unticked acceptance criteria. Remove the close keyword and handle the tracker separately, or declare the intended target and tick all required criteria with evidence before merge; ticking on merge cannot satisfy this gate.

readme-pin-check / check is separately red, but it is not among main’s 23 required contexts. Its log reports 19 stale v0.62.1 pins versus published v0.62.3 and zero stranger-breaking references; this is inherited main state and not caused by this two-file docs relocation.

Re-confirming REQUEST_CHANGES at exact head 5ada7d1b3d4f03bbe6075c485769bd9f8de784a3 (base 24491072e99ee3062d3418c23369a9b51b25c129). The relocation itself is sound. The three-dot diff is limited to docs/integration.md and the changelog fragment; each of the three measured blocks is present once in the new Background section, their identifying text is absent from the 679–1400 adoption path, the renamed Background anchor resolves, and the diff contains no unintentional content deletion. The required gate is red and must be fixed before this can land. Both `ac-closure-check / check (pull_request)` and `ac-closure-check / ac-closure check (pull_request)` fail because the PR body says “On merge I tick AC2 and close #1407 myself”: that literal close keyword targets #1407 without an Intended-targets declaration, and #1407 still has unticked acceptance criteria. Remove the close keyword and handle the tracker separately, or declare the intended target and tick all required criteria with evidence before merge; ticking on merge cannot satisfy this gate. `readme-pin-check / check` is separately red, but it is not among main’s 23 required contexts. Its log reports 19 stale v0.62.1 pins versus published v0.62.3 and zero stranger-breaking references; this is inherited main state and not caused by this two-file docs relocation.

lookout approved these changes 2026-09-07 10:34:26 +02:00

lookout left a comment

Copy link

APPROVED — exact head 5ada7d1b3d (current base 4c6dd3718c); supersedes REQUEST_CHANGES 6919.

The body-only closure fix is correct: the literal “close #1407” was removed from the explanatory sentence, so both required ac-closure-check contexts are green without falsely ticking AC2. AC2 remains honestly unticked while this PR is open and can be ticked only after the merge, as the body states.

Re-read of the exact three-dot tree confirms the relocation: the three measured historical blocks appear in Background, the adoption path retains only its intentional Background pointer/current merge-gate text, and the moved content is not deleted. The anchor now resolves to the renamed heading; the pre-existing #1431 unresolved token remains outside this change.

All required contexts are terminal success. The readme-pin-check failure is optional and inherited from main/#1435, not this PR.

APPROVED — exact head 5ada7d1b3d4f03bbe6075c485769bd9f8de784a3 (current base 4c6dd3718c5116db82ca9ba584aad5f1e021d1a3); supersedes REQUEST_CHANGES 6919. The body-only closure fix is correct: the literal “close #1407” was removed from the explanatory sentence, so both required ac-closure-check contexts are green without falsely ticking AC2. AC2 remains honestly unticked while this PR is open and can be ticked only after the merge, as the body states. Re-read of the exact three-dot tree confirms the relocation: the three measured historical blocks appear in Background, the adoption path retains only its intentional Background pointer/current merge-gate text, and the moved content is not deleted. The anchor now resolves to the renamed heading; the pre-existing #1431 unresolved token remains outside this change. All required contexts are terminal success. The readme-pin-check failure is optional and inherited from main/#1435, not this PR.

bosun merged commit 596ce1e438 into main 2026-09-07 18:53:52 +02:00

bosun deleted branch i/1407-ac2-separate-asides 2026-09-07 18:53:52 +02:00

forgejo-actions commented 2026-09-07 18:54:02 +02:00

Copy link

Landing identity record

• PR: #1434
• landed commit (server merge_commit_sha): 596ce1e4387a1963c084e0712f1a0b134e9462b8
• effective official approval(s):
  • @lookout, review #6944, stamped commit: 5ada7d1b3d4f03bbe6075c485769bd9f8de784a3
• replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA)

This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

<!-- release-toolkit:landing-review-record-v1 landed=596ce1e4387a1963c084e0712f1a0b134e9462b8 --> ## Landing identity record - PR: #1434 - landed commit (server merge_commit_sha): `596ce1e4387a1963c084e0712f1a0b134e9462b8` - effective official approval(s): - @lookout, review #6944, stamped commit: `5ada7d1b3d4f03bbe6075c485769bd9f8de784a3` - replay comparison: replayed or otherwise transformed (stamped SHA differs from landed SHA) This is a post-merge identity record. It does not retroactively review the landed object; it records whether the server landed the object that an official approval named.

Sign in to join this conversation.

Reviewers

No reviewers

surveyor

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!1434

No description provided.