frankenbit/release-toolkit
frankenbit/release-toolkit
Watch
17
1
Fork
You've already forked release-toolkit
 0
Code Issues 39 Pull requests Projects Releases 112 Packages 1 Wiki Activity Actions

fix(recover-pending-cut): drop the stale #1173 note from the recovery PR body (#1499) #1522

Closed
claude wants to merge 1 commit from claude/1499-recover-pr-body-1173 into main
pull from: claude/1499-recover-pr-body-1173
merge into: frankenbit:main
Conversation 1 Commits 1 Files changed 4 +2 -3
claude commented 2026-10-02 21:19:00 +02:00
Member

Removes the stale "Tagged-adopter dependency" paragraph from the recovery (B) PR body, and corrects one word in docs/integration.md.

Refs #1499

What changes

  • .forgejo/workflows/reusable-recover-pending-cut.yml and its .gitea twin: delete the one printf that told the PR's reviewer #1173 had not landed. Nothing else in the body builder moves. The $REMAINING and could-not-grade disclosures after it are untouched.
  • docs/integration.md: toolkit-self's @main pin goes through the #456 floating-pin override, not a "local" invocation (that arm handles a ./.forgejo/... uses line). The sentence now says so.
  • changelog.d/1499-recover-pr-body-1173.fixed.md: a one-line ### Fixed note, because adopters' recovery PRs now read differently.

Remove or rewrite

  • Remove is right when every run that can render the new text already runs a correctly baked rt. Measured, every one does:
    • a release tag from v0.58.0 bakes its own name;
    • @main takes the #456 override;
    • a commit SHA is refused at bootstrap rt since #1514.
  • Rewrite would be right if the PR-body reader needed the v0.58.0 floor for some other adopter. They don't. The floor is in docs/integration.md (since dc9df38), the page that tells adopters what to pin. Whoever reads this PR body is already running a version past the floor.
  • Keep is never right: the claim is false for every run that can display it.

Measured

  • #1173 is closed (2026-09-05, forge read-back). The file is in canonicalFiles (internal/bake/marker.go:26) and in gates.DefaultComposeScripts.

  • Baked ref per tag, read at the forge's tag SHAs on 2026-10-02, both twins:

    v0.57.0-v0.57.4  'v0.57.0'
v0.58.0-v0.64.0  each tag's own name (13 tags, all match)

    git ls-remote matched the local tags one-for-one, and the contents API at v0.58.0 returned blob 5cb836d1, the same blob as the local tag.

  • On this head (8333455), in a golang:1.25 container on an LF clone:

    • rt gitea-twin --check: PASS — 11 twin(s) match their source.
    • go test ./...: rc=0, no failing package
    • bats --print-output-on-failure tests/: 221 tests, rc=0
    • FRAGMENT_CHECK_COVERAGE=content rt fragment-check changelog.d: rc=0, density PASS
    • rt check-self-bootstrap: floating-pin (release-toolkit#456): main matches main by construction, rc=0

  • git grep -n 1173 -- .forgejo .gitea cmd internal on this head returns only internal/bake/marker.go:151 and internal/bake/marker_test.go:102,140, all historical.

  • The workflow diff is two deletions and no additions, so the ASCII-only rule (AGENTS.md section 11) holds.

Self-bootstrap (AGENTS.md section 2)

This touches a file in gates.DefaultComposeScripts, and section 2 predicts a red check-self-bootstrap plus a re-pin. Measured instead: every toolkit-self wrapper pins @main, so the check takes the #456 floating-pin exit and passes (output above). No re-pin is needed. Section 2's text predates the @main pin; that gap is noted on #1499, not changed here.

Review request: verify at source (AGENTS.md section 6)

@bosun, you reviewed #1182, so this one is yours. Please check against the tree, not this body:

  1. The deleted printf is the only change in either twin, and the twins still match (rt gitea-twin --check).
  2. The three arms of the decision tree:
    • the bake at a recent tag (git show v0.64.0:.forgejo/workflows/reusable-recover-pending-cut.yml | grep build-ref);
    • the #456 arm in the resolve step;
    • the SHA refusal at composite/bootstrap-rt/action.yml:9-11.
  3. The new docs/integration.md sentence, against the resolve step's floating-pin-override (release-toolkit#456) arm.

Pre-submit, pin the review to head 8333455d68a3a9cb6945e594e4625a94be661b46 with rt review-submit-check (AGENTS.md section 6.2).

🤖 Generated with Claude Code

Removes the stale "Tagged-adopter dependency" paragraph from the recovery (B) PR body, and corrects one word in `docs/integration.md`. Refs #1499 ## What changes - **`.forgejo/workflows/reusable-recover-pending-cut.yml` and its `.gitea` twin**: delete the one `printf` that told the PR's reviewer #1173 had not landed. Nothing else in the body builder moves. The `$REMAINING` and could-not-grade disclosures after it are untouched. - **`docs/integration.md`**: toolkit-self's `@main` pin goes through the #456 floating-pin override, not a "local" invocation (that arm handles a `./.forgejo/...` uses line). The sentence now says so. - **`changelog.d/1499-recover-pr-body-1173.fixed.md`**: a one-line `### Fixed` note, because adopters' recovery PRs now read differently. ## Remove or rewrite - **Remove** is right when every run that can render the new text already runs a correctly baked `rt`. Measured, every one does: - a release tag from v0.58.0 bakes its own name; - `@main` takes the #456 override; - a commit SHA is refused at `bootstrap rt` since #1514. - **Rewrite** would be right if the PR-body reader needed the v0.58.0 floor for some other adopter. They don't. The floor is in `docs/integration.md` (since `dc9df38`), the page that tells adopters what to pin. Whoever reads this PR body is already running a version past the floor. - **Keep** is never right: the claim is false for every run that can display it. ## Measured - #1173 is closed (2026-09-05, forge read-back). The file is in `canonicalFiles` (`internal/bake/marker.go:26`) and in `gates.DefaultComposeScripts`. - Baked ref per tag, read at the forge's tag SHAs on 2026-10-02, both twins: ``` v0.57.0-v0.57.4 'v0.57.0' v0.58.0-v0.64.0 each tag's own name (13 tags, all match) ``` `git ls-remote` matched the local tags one-for-one, and the contents API at `v0.58.0` returned blob `5cb836d1`, the same blob as the local tag. - On this head (`8333455`), in a `golang:1.25` container on an LF clone: - `rt gitea-twin --check`: `PASS — 11 twin(s) match their source.` - `go test ./...`: rc=0, no failing package - `bats --print-output-on-failure tests/`: 221 tests, rc=0 - `FRAGMENT_CHECK_COVERAGE=content rt fragment-check changelog.d`: rc=0, density PASS - `rt check-self-bootstrap`: `floating-pin (release-toolkit#456): main matches main by construction`, rc=0 - `git grep -n 1173 -- .forgejo .gitea cmd internal` on this head returns only `internal/bake/marker.go:151` and `internal/bake/marker_test.go:102,140`, all historical. - The workflow diff is two deletions and no additions, so the ASCII-only rule (AGENTS.md section 11) holds. ## Self-bootstrap (AGENTS.md section 2) This touches a file in `gates.DefaultComposeScripts`, and section 2 predicts a red `check-self-bootstrap` plus a re-pin. Measured instead: every toolkit-self wrapper pins `@main`, so the check takes the #456 floating-pin exit and passes (output above). **No re-pin is needed.** Section 2's text predates the `@main` pin; that gap is noted on #1499, not changed here. ## Review request: verify at source (AGENTS.md section 6) @bosun, you reviewed #1182, so this one is yours. Please check against the tree, not this body: 1. The deleted `printf` is the only change in either twin, and the twins still match (`rt gitea-twin --check`). 2. The three arms of the decision tree: - the bake at a recent tag (`git show v0.64.0:.forgejo/workflows/reusable-recover-pending-cut.yml | grep build-ref`); - the #456 arm in the resolve step; - the SHA refusal at `composite/bootstrap-rt/action.yml:9-11`. 3. The new `docs/integration.md` sentence, against the resolve step's `floating-pin-override (release-toolkit#456)` arm. Pre-submit, pin the review to head `8333455d68a3a9cb6945e594e4625a94be661b46` with `rt review-submit-check` (AGENTS.md section 6.2). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(recover-pending-cut): drop the stale #1173 note from the recovery PR body (#1499)
Some checks failed
fork-pr-approval-notice / explain fork workflow approval (pull_request_target) Successful in 5s
Details
ac-closure-check / ac-closure check (pull_request) Successful in 6s
Details
ac-closure-check / check (pull_request) Successful in 0s
Details
base-divergence-check / check (pull_request) Successful in 5s
Details
changelog-body-check / changelog body Cold-Read linter (pull_request) Successful in 7s
Details
changelog-body-check / check (pull_request) Successful in 0s
Details
check-self-bootstrap / check (pull_request) Successful in 5s
Details
fragment-check / coverage (pull_request) Successful in 6s
Details
fragment-check / density (pull_request) Successful in 7s
Details
fragment-check / check (pull_request) Successful in 0s
Details
gitea-twin-check / check (pull_request) Successful in 5s
Details
go-ci / lint + build + test (pull_request) Successful in 29s
Details
go-ci / record reviewed vs landed commit (pull_request) Has been skipped
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 7s
Details
manifest-check / check (pull_request) Successful in 0s
Details
prep-order-check / check (pull_request) Successful in 5s
Details
readme-pin-check / mirror (pull_request) Failing after 7s
Details
readme-pin-check / digest (pull_request) Successful in 6s
Details
register-check / register-drift check (pull_request) Successful in 7s
Details
register-check / check (pull_request) Successful in 0s
Details
tests / workflow-schema (pull_request) Successful in 4s
Details
tests / bats (pull_request) Successful in 34s
Details
tests / dated-examples (pull_request) Successful in 4s
Details
tests / contract-paths (pull_request) Successful in 4s
Details
tests / shellcheck (pull_request) Successful in 4s
Details
toolkit-self-gates / toolkit-self gates (PR's own rt) (pull_request) Successful in 7s
Details
workflow-parse-check / toolkit-self parse guard and controls (pull_request) Successful in 4s
Details
workflow-parse-check / workflow parse and schema (pull_request) Successful in 4s
Details
workflow-parse-check / check (pull_request) Successful in 0s
Details
go-ci / page landing-tree failure (pull_request) Has been skipped
Details
8333455d68 
The recovery (B) PR body still said reusable-recover-pending-cut.yml was
not yet in internal/bake/marker.go's canonical file set "until #1173
lands". #1173 closed on 2026-09-05, and every tag from v0.58.0 bakes the
file to its own name (read at the forge's tag SHAs, 2026-10-02).

Removed rather than rewritten. The paragraph reaches a reader only
through the YAML at the ref the adopter runs, and every ref that can
render the new text already runs a correctly baked rt: a release tag by
the bake, @main by the #456 floating-pin override. The v0.58.0 floor
stays in docs/integration.md, the page that tells adopters what to pin.

docs/integration.md: toolkit-self's @main pin takes the #456
floating-pin arm, not the local-invocation arm, which handles a
./.forgejo uses line.

Refs #1499

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude requested review from bosun 2026-10-02 21:19:06 +02:00
claude commented 2026-10-02 21:21:55 +02:00
Author
Member

Withdrawn as a duplicate of #1504 (issue #1500). That PR made the same removal first (11:31), and it also leaves a comment in the run block explaining why the body carries no caveat.

This PR's one extra item, the "local @main" wording in docs/integration.md, is offered on #1504 as a suggestion. The branch claude/1499-recover-pr-body-1173 stays in place for now.

Withdrawn as a duplicate of #1504 (issue #1500). That PR made the same removal first (11:31), and it also leaves a comment in the run block explaining why the body carries no caveat. This PR's one extra item, the "local `@main`" wording in `docs/integration.md`, is offered on #1504 as a suggestion. The branch `claude/1499-recover-pr-body-1173` stays in place for now.
claude closed this pull request 2026-10-02 21:22:00 +02:00
Some checks are pending
fork-pr-approval-notice / explain fork workflow approval (pull_request_target) Successful in 5s
Details
ac-closure-check / ac-closure check (pull_request) Successful in 6s
Details
ac-closure-check / check (pull_request) Successful in 0s
Details
base-divergence-check / check (pull_request) Successful in 5s
Details
changelog-body-check / changelog body Cold-Read linter (pull_request) Successful in 7s
Details
changelog-body-check / check (pull_request) Successful in 0s
Details
check-self-bootstrap / check (pull_request) Successful in 5s
Details
fragment-check / coverage (pull_request) Successful in 6s
Details
fragment-check / density (pull_request) Successful in 7s
Details
fragment-check / check (pull_request) Successful in 0s
Details
gitea-twin-check / check (pull_request) Successful in 5s
Details
go-ci / lint + build + test (pull_request) Successful in 29s
Required
Details
go-ci / record reviewed vs landed commit (pull_request) Has been skipped
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 7s
Details
manifest-check / check (pull_request) Successful in 0s
Details
prep-order-check / check (pull_request) Successful in 5s
Details
readme-pin-check / mirror (pull_request) Failing after 7s
Details
readme-pin-check / digest (pull_request) Successful in 6s
Details
register-check / register-drift check (pull_request) Successful in 7s
Details
register-check / check (pull_request) Successful in 0s
Details
tests / workflow-schema (pull_request) Successful in 4s
Details
tests / bats (pull_request) Successful in 34s
Required
Details
tests / dated-examples (pull_request) Successful in 4s
Details
tests / contract-paths (pull_request) Successful in 4s
Details
tests / shellcheck (pull_request) Successful in 4s
Details
toolkit-self-gates / toolkit-self gates (PR's own rt) (pull_request) Successful in 7s
Required
Details
workflow-parse-check / toolkit-self parse guard and controls (pull_request) Successful in 4s
Details
workflow-parse-check / workflow parse and schema (pull_request) Successful in 4s
Details
workflow-parse-check / check (pull_request) Successful in 0s
Details
go-ci / page landing-tree failure (pull_request) Has been skipped
Details
pr / gates (pull_request)
Required
tests / checks (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
bosun
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind
bug
 Something is broken

  
kind
chore
 Maintenance, tooling, refactor

  
kind
docs
 Documentation work

  
kind
epic
 Tracker: its acceptance criteria are sub-issues; closed by hand when all are ticked

  
kind
feature
 New feature or capability

  
loop/paused
rt-bugfix-loop kill switch: while this is on the loop log issue, no round claims or merges

  
mirror-drift
Automated: a release here has no asset-bearing counterpart on the mirror. One tracker per drift episode; the check never reopens a closed one (#1586)

  
priority
critical
 Critical: must be addressed immediately

  
priority
high
 Important, should be addressed soon

  
priority
low
 Low priority, address when convenient

  
priority
medium
 Normal priority

  
size
L
 Large: significant feature, ~6-16h

  
size
M
 Medium: moderate feature, ~2-6h

  
size
S
 Small: simple change, ~1-2h

  
size
XL
 Extra large: major feature or refactor, 16h+

  
status
blocked
 Cannot start until a named dependency resolves

No labels
bump
major
bump
minor
bump
patch
kind
bug
kind
chore
kind
docs
kind
epic
kind
feature
loop/paused
mirror-drift
priority
critical
priority
high
priority
low
priority
medium
size
L
size
M
size
S
size
XL
status
blocked
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
frankenbit/release-toolkit!1522
No description provided.