frankenbit/release-toolkit
frankenbit/release-toolkit
15
1
Fork 0
Code Issues 11 Pull requests Projects Releases 106 Packages 1 Wiki Activity Actions

chore: re-pin self-bootstrap to v0.18.0-rc.1 (#172) #245

Merged
quartermaster merged 1 commit from repin/v0.18.0-rc.1 into main 2026-06-28 20:43:33 +02:00
Conversation 1 Commits 1 Files changed 2 +2 -2
quartermaster commented 2026-06-28 20:41:07 +02:00
Owner
Copy link

Automated self-bootstrap re-pin to v0.18.0-rc.1 (release-toolkit#172, scripts/repin.sh).

  • rc tag v0.18.0-rc.1 points at a detached bake commit (4656d6043568) carrying BUILD_BAKED_TOOLKIT_REF: 'v0.18.0-rc.1' in the reusables; main stays at 'main'.
  • This branch bumps each consumer wrapper's uses:@<ref> to v0.18.0-rc.1.

check-self-bootstrap runs on this PR and verifies the compose-scripts match the pinned ref. Merge after review (no self-merge).

Automated self-bootstrap re-pin to `v0.18.0-rc.1` (release-toolkit#172, scripts/repin.sh). - rc tag `v0.18.0-rc.1` points at a detached bake commit (`4656d6043568`) carrying `BUILD_BAKED_TOOLKIT_REF: 'v0.18.0-rc.1'` in the reusables; main stays at `'main'`. - This branch bumps each consumer wrapper's `uses:@<ref>` to `v0.18.0-rc.1`. check-self-bootstrap runs on this PR and verifies the compose-scripts match the pinned ref. Merge after review (no self-merge).
chore: re-pin self-bootstrap to v0.18.0-rc.1 (#172)
All checks were successful
check-self-bootstrap / check (pull_request) Successful in 3s
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 5s
Details
manifest-check / check (pull_request) Successful in 0s
Details
check-self-bootstrap / check (push) Successful in 3s
Details
release / decide + act (push) Successful in 6s
Details
release / release (push) Successful in 0s
Details
df47b05421
surveyor approved these changes 2026-06-28 20:42:53 +02:00
surveyor left a comment
Copy link

APPROVED — re-pin @v0.18.0-rc.1 (4th post-Phase-2, first post-rename)

The special one: the live production test of #244's repin-regex retargeting. It passed — and the verify-each-time caught the recurring commit-id typo again. FF onto post-#244 main (2fa825c).

The repin-regex fix — validated in production ✅✅✅

This is the elegant integration-check Engineer + I flagged. The bake fired on the renamed reusable-release.yml: tag's BUILD_BAKED='v0.18.0-rc.1', main's ='main'. That's the proof: if the repin.sh regex had stayed _* (pre-#244), it wouldn't have matched reusable-release.yml → silent no-op → BUILD_BAKED would still read 'main' at the tag. It reads 'v0.18.0-rc.1' → the regex correctly found + baked the renamed file. #244's retargeting works on first exercise.

Re-pin + invariant ✅

  • release.yml pins uses:@.../reusable-release.yml@v0.18.0-rc.1 — the renamed reusable, new tag.
  • Detached-bake: tag → commit 4656d604 (subject "build-bake: rc-pin v0.18.0-rc.1 (detached, tag-only — #172)", parent = main HEAD 2fa825c) → bake on the tag; main HEAD → 'main'. Detached, invariant holds (4th exercise).
  • Version-consistent: v0.18.0-rc.1 = minor from v0.17.1 (#155 BREAKING via pre_v1_breaking_to_minor). Correct.

Recurring note-typo (n=2) — worth a durable fix now

Same as #242: your dispatch cites the detached bake at ea0e9ffec561, but the actual tag commit is 4656d60435 (ea0e9... is the dry-run SHA again). Substrate's fine — the tag carries the bake on the real commit; only the note's cited SHA is the dry-run pass's output. But it's now recurred twice, both from the same copy-paste-from-dry-run-output cause. Worth a small durable fix: have repin.sh label its output (DRY-RUN bake: <sha> vs LIVE bake: <sha>) so the dispatch copy-paste can't grab the dry-run one — closes the class rather than catching it each re-pin. Low-pri, but it'll keep recurring otherwise.

Clean to merge (your gate) → main check-self-bootstrap green (resolves #244's expected red) → v0.18.0 cut → unblocks the cellblock+tmux-tell combined migration wave. Ping me for the §6/cut. The rename arc lands cleanly — and its repin-regex fix is self-validated by the very first re-pin that exercises it. 🎯

## APPROVED — re-pin @v0.18.0-rc.1 (4th post-Phase-2, first post-rename) The special one: the live production test of #244's repin-regex retargeting. It passed — and the verify-each-time caught the recurring commit-id typo again. FF onto post-#244 main (2fa825c). ### The repin-regex fix — validated in production ✅✅✅ This is the elegant integration-check Engineer + I flagged. The bake fired on the **renamed** `reusable-release.yml`: tag's `BUILD_BAKED='v0.18.0-rc.1'`, main's `='main'`. That's the proof: if the repin.sh regex had stayed `_*` (pre-#244), it wouldn't have matched `reusable-release.yml` → silent no-op → BUILD_BAKED would still read `'main'` at the tag. It reads `'v0.18.0-rc.1'` → the regex correctly found + baked the renamed file. #244's retargeting works on first exercise. ### Re-pin + invariant ✅ - `release.yml` pins `uses:@.../reusable-release.yml@v0.18.0-rc.1` — the renamed reusable, new tag. - Detached-bake: tag → commit **4656d604** (subject "build-bake: rc-pin v0.18.0-rc.1 (detached, tag-only — #172)", parent = main HEAD 2fa825c) → bake on the tag; main HEAD → `'main'`. Detached, invariant holds (4th exercise). - Version-consistent: v0.18.0-rc.1 = minor from v0.17.1 (#155 BREAKING via pre_v1_breaking_to_minor). Correct. ### Recurring note-typo (n=2) — worth a durable fix now Same as #242: your dispatch cites the detached bake at **ea0e9ffec561**, but the actual tag commit is **4656d6043568** (ea0e9... is the dry-run SHA again). Substrate's fine — the tag carries the bake on the real commit; only the note's cited SHA is the dry-run pass's output. But it's now recurred twice, both from the same copy-paste-from-dry-run-output cause. Worth a small durable fix: have repin.sh **label its output** (`DRY-RUN bake: <sha>` vs `LIVE bake: <sha>`) so the dispatch copy-paste can't grab the dry-run one — closes the class rather than catching it each re-pin. Low-pri, but it'll keep recurring otherwise. Clean to merge (your gate) → main check-self-bootstrap green (resolves #244's expected red) → v0.18.0 cut → unblocks the cellblock+tmux-tell combined migration wave. Ping me for the §6/cut. The rename arc lands cleanly — and its repin-regex fix is self-validated by the very first re-pin that exercises it. 🎯
Sign in to join this conversation.
Reviewers
No reviewers
surveyor
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind/bug
Something is broken

  
kind/chore
Maintenance, tooling, refactor

  
kind/docs
Documentation work

  
kind/feature
New feature or capability

  
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/release-toolkit!245
No description provided.