chore(release): v0.40.2 #748
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit!748
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "release-prep/rolling"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Added
None.
Changed
None.
Fixed
The FETCH arm adopters use is now exercised by this repo's CI. A tag-triggered
job runs the composite bootstrap against the tag just published, executes the
fetched binary, and measures the cache-hit path.
The toolkit's own wrappers pin
@main, so the#456override sent every reusabledown the BUILD arm. The FETCH arm was therefore unexercised here by construction,
and it broke for every adopter at v0.34.0 with CI green throughout.
Sentence splitting now decides where sentences end instead of pattern-matching
punctuation. The old splitter broke on any
.,!or?followed bywhitespace, wherever it sat.
That was wrong in two directions. Punctuation inside a code span or after an
abbreviation split one over-long sentence into two short ones, so the density
check passed prose it should have refused. Punctuation followed by a closing
marker, as in the house
**Lead.** Proseshape, suppressed the split and madethe check refuse prose that was fine.
The new predicate asks whether each occurrence is sentence-final. It splits at
indices rather than rewriting text, so a sentence's words are never lost or
double-counted by the fix itself.
Removed
None.
Deprecated
None.
Upgrade
None.
c39547c14641fea23c99Reviewed at
41fea23c99after the re-cut from current main. Real git reports behind=0 with one prepare commit. Both source fragments are consumed; v0.40.2 is propagated across VERSION, README and adopter workflow surfaces; the composed changelog carries both fixes. All eight required contexts are green, and fragment-check is green now that #746 is on main.Reviewed at
41fea23c99after the re-cut from current main. Real git reports behind=0 with one prepare commit. Both source fragments are consumed; v0.40.2 is propagated across VERSION, README and adopter workflow surfaces; the composed changelog carries both fixes. All eight required contexts are green, and fragment-check is green now that #746 is on main.APPROVED @
41fea23c,behind=0, verified at submit time.⚠️ Note the head this reviews. The cut was announced at
c39547c1; that head was force-pushedaway at 12:17:30, about a minute before I began reading. My first status pass was against the
superseded SHA and is discarded — this review is against
41fea23conly.The cut is well-formed
Fragment composition verified rather than assumed:
648.fixed.md's 71 words appear verbatimas a contiguous run inside the composed
[v0.40.2]section. The cut did not reword what it composed.CI — all 13 contexts green, all 8 required green
The two failures on the superseded head did NOT survive the force-push, and I checked each by
name rather than reading an aggregate:
✅ And the known-false
fragment-checkred is gone, which is#746landing as designed — allthree contexts including
toolkit-selfare green, where an ordinary PR showed three reds thismorning. The published signature can be retired.
⛔ This is approved but NOT mergeable yet, and the reason is not a stamp
@lookout holds a live
REQUEST_REVIEWrow, requested at the superseded head. Per our own measuredbehaviour that returns
405 "There are official review requests"on merge, independently of anyapproval — and my stamp does not consume his row; only a review submitted by him after the
request does, or his removal as a requested reviewer.
Scope: this reviews the cut's mechanical correctness — version consistency, fragment consumption,
composition fidelity, CI. It does not re-review the substance of the changes being released; those
landed under their own reviews.
⚠️ Correcting my own review body — the block I named cleared before I posted it
My stamp above says "NOT mergeable yet — @lookout holds a live
REQUEST_REVIEWrow." That wastrue when I measured it and false when I published it.
Both reviewers are now approved and bound to
41fea23c, all 8 required contexts are green, andbehind=0. Nothing is holding this PR —requested_reviewersstill lists him, which is thedocumented non-signal (who was asked at some point, not who has not answered).
🔑 Worth naming because it is the shape we spent this morning on: I read the gate, wrote a paragraph
about it, and submitted — and the state moved inside that window. A state claim needs an anchor, and
mine had one (
@ 41fea23c), which is why this correction is one comment rather than a puzzle: theanchor tells you exactly which reading it describes, so it degrades into a dated record instead of
impersonating the present.
Everything else in that review stands, and none of it was time-sensitive: the version bump,
fragment consumption, verbatim composition, and the CI comparison across both heads.