test(register): pin allow-list glob semantics (#682) #859
No reviewers
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit!859
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "i/682-allowlist-glob-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
Refs #682. The old tests/register-check.bats was retired by #607, so the surviving Go allow-list implementation now has explicit positive and negative coverage for the documented wildcard semantics: .md crosses slashes, docs/ is recursive without **, ? crosses one slash, and a trailing-slash directory prefix remains distinct from a lookalike path.
Verification
PATH=/usr/local/go/bin:$PATH go test ./internal/register -run TestAllowlist -count=1: package ok.PATH=/usr/local/go/bin:$PATH go test ./internal/register -count=1: package ok.PATH=/usr/local/go/bin:$PATH go vet ./internal/register: exit 0, no output.PATH=/usr/local/go/bin:$PATH go test ./internal/register -run TestAllowlistGlobSemantics -count=1exited 1 and red three cross-slash positive arms.Each positive arm has a negative control, so a clean result cannot come from a pattern that matches nothing.
APPROVED at
e9e8396315. I ran go test ./... -count=1 and go vet ./..., both clean. Independently mutating bashGlobToRegexp: changing * to [^/]* reddened the cross-slash matcher/allowlist arms, and changing ? to [^/] reddened the cross-slash ? arm; the unmutated baseline and negative controls pass. The new table exercises .md, docs/, ?, and trailing-slash directory prefixes with explicit rejecting controls. git diff --check is clean. The exact head and required contexts were re-read; all 9 required contexts report success.APPROVED at
e9e8396315. I ran go test ./... -count=1 and go vet ./..., both clean. Independently mutating bashGlobToRegexp: changing * to [^/]* reddened the cross-slash matcher/allowlist arms, and changing ? to [^/] reddened the cross-slash ? arm; the unmutated baseline and negative controls pass. The new table exercises .md, docs/, ?, and trailing-slash directory prefixes with explicit rejecting controls. git diff --check is clean. The exact head and required contexts were re-read; all 9 required contexts report success.e9e8396315a377cf1120RE-STAMP at
a377cf1120. This is a mechanical re-bind, not a substantive re-review: the old and rebased ranges have identical patch-id 161949e47ff5e70a6ab81a133b91b6aae8a62c3a, byte hash 7b700353561b3b49a0194117bf139f9b9481d5089bfb04134f444f5688201637, and own-commit count 1. The previously verified glob-semantics tests and mutations therefore cover this unchanged contribution. Required contexts are re-running on the new base.RE-STAMP at
a377cf1120. This is a mechanical re-bind, not a substantive re-review: the old and rebased ranges have identical patch-id 161949e47ff5e70a6ab81a133b91b6aae8a62c3a, byte hash 7b700353561b3b49a0194117bf139f9b9481d5089bfb04134f444f5688201637, and own-commit count 1. The previously verified glob-semantics tests and mutations therefore cover this unchanged contribution. Required contexts are re-running on the new base.