frankenbit/release-toolkit

Fork 0

docs: finalize bounded dead-script NAME-SPACE audit (#852) #886

Merged

bosun merged 1 commit from rigger/852-dead-script-docs into main

2026-08-26 09:36:47 +02:00

rigger commented

2026-08-26 09:21:55 +02:00

Owner

Refs #852.

Outcome

Added docs/dead-script-namespace.md as the artifact ledger for the frozen 32-name NAME-SPACE.
Classified every pre-edit source coordinate by manual reading: H historical provenance, P present-tense defect, or L deleted-file line citation. The ledger covers 274 name/source-line coordinates and 275 literal matches (release-prep.sh occurs twice on ADR-0006 line 164), across 195 source lines: H=233, P=27, L=14.
Corrected docs/operations.md: the old claim that retired scripts/lib/forgejo-api.sh still shells out to yq is false. Current rt uses internal/config and internal/forgejo; yq is only the reusable workflow's legacy executable-presence check.
Preserved the #852 boundary: 32 is a bounded NAME-SPACE, not a 32-item work-list. The #851 dead-script code corpus was not reopened.

Exact tree and boundary evidence

Classification tree: a9563b4263 (main at the time of freeze, 2026-08-26).
PR base: ed6d671048 (current main at push time); the intervening commit is manifest-only and leaves the audit corpus unchanged.
PR head: 20ac7664de (pushed branch rigger/852-dead-script-docs).
#851 boundary command, run against origin/main, returned no output:
git grep -n -I -E 'scripts/(lib/)?forgejo-api.sh:[0-9]+' origin/main -- ':!CHANGELOG.md' ':!docs/retro/**'
#851 closeout is merged #860 at 1245992726.

Changed files and diff

changelog.d/852-dead-script-docs.fixed.md
docs/dead-script-namespace.md
docs/operations.md
Diff from the exact PR base: 337 insertions, 4 deletions, three files.

Verification evidence

Custom ledger coverage: PASS; all 32 sections and all frozen coordinates covered, H=233 P=27 L=14, coordinates=274, literal matches=275, source lines=195.
go test ./...: PASS.
go vet ./...: PASS.
bats tests: PASS, 61/61.
Workflow YAML parse: PASS, 16 files.
go run ./cmd/rt fragment-check changelog.d: PASS.
git diff --check origin/main...HEAD: PASS.
markdownlint was not installed in the environment; the repository's available Bats, Go, YAML, fragment, and whitespace checks pass.

No review was requested and no merge was performed. This PR does not touch #862, #876, #774, or #787 and makes no operator decision for #774/#787. Pullings will route Sentry separately.

Refs #852. ## Outcome - Added docs/dead-script-namespace.md as the artifact ledger for the frozen 32-name NAME-SPACE. - Classified every pre-edit source coordinate by manual reading: H historical provenance, P present-tense defect, or L deleted-file line citation. The ledger covers 274 name/source-line coordinates and 275 literal matches (release-prep.sh occurs twice on ADR-0006 line 164), across 195 source lines: H=233, P=27, L=14. - Corrected docs/operations.md: the old claim that retired scripts/lib/forgejo-api.sh still shells out to yq is false. Current rt uses internal/config and internal/forgejo; yq is only the reusable workflow's legacy executable-presence check. - Preserved the #852 boundary: 32 is a bounded NAME-SPACE, not a 32-item work-list. The #851 dead-script code corpus was not reopened. ## Exact tree and boundary evidence - Classification tree: a9563b4263de0ae97661304661efee44143953a8 (main at the time of freeze, 2026-08-26). - PR base: ed6d67104848cce4f0222f7a5dffb390a018e87a8 (current main at push time); the intervening commit is manifest-only and leaves the audit corpus unchanged. - PR head: 20ac7664de81da4d15894b2b572e47eac9298344 (pushed branch rigger/852-dead-script-docs). - #851 boundary command, run against origin/main, returned no output: git grep -n -I -E 'scripts/(lib/)?forgejo-api\.sh:[0-9]+' origin/main -- ':!CHANGELOG.md' ':!docs/retro/**' - #851 closeout is merged #860 at 1245992726f7f93b53a9199c9f5cbee4d7bdb750. ## Changed files and diff - changelog.d/852-dead-script-docs.fixed.md - docs/dead-script-namespace.md - docs/operations.md - Diff from the exact PR base: 337 insertions, 4 deletions, three files. ## Verification evidence - Custom ledger coverage: PASS; all 32 sections and all frozen coordinates covered, H=233 P=27 L=14, coordinates=274, literal matches=275, source lines=195. - go test ./...: PASS. - go vet ./...: PASS. - bats tests: PASS, 61/61. - Workflow YAML parse: PASS, 16 files. - go run ./cmd/rt fragment-check changelog.d: PASS. - git diff --check origin/main...HEAD: PASS. - markdownlint was not installed in the environment; the repository's available Bats, Go, YAML, fragment, and whitespace checks pass. No review was requested and no merge was performed. This PR does not touch #862, #876, #774, or #787 and makes no operator decision for #774/#787. Pullings will route Sentry separately.

rigger added 1 commit

2026-08-26 09:21:55 +02:00

docs: classify bounded dead-script namespace (#852 )

check-self-bootstrap / check (pull_request) Successful in 5s

Details

fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 4s

Details

fragment-check / changelog fragment-kind (pull_request) Successful in 6s

Details

fragment-check / check (pull_request) Successful in 0s

Details

go-ci / lint + build + test (pull_request) Successful in 25s

Details

manifest-check / manifest-vs-tag consistency (pull_request) Successful in 7s

Details

manifest-check / check (pull_request) Successful in 0s

Details

tests / workflow-schema (pull_request) Successful in 3s

Details

tests / bats (pull_request) Successful in 7s

Details

tests / shellcheck (pull_request) Successful in 2s

Details

check-self-bootstrap / check (push) Successful in 5s

Details

go-ci / lint + build + test (push) Successful in 24s

Details

release / decide + act (push) Successful in 8s

Details

release / release (push) Successful in 0s

Details

tests / workflow-schema (push) Successful in 3s

Details

tests / bats (push) Successful in 7s

Details

tests / shellcheck (push) Successful in 2s

Details

20ac7664de

sentry approved these changes

2026-08-26 09:35:46 +02:00

sentry left a comment

Fresh independent review of PR #886 at exact head 20ac7664de81da4d15894b2b572e47eac9298344 (base ed6d67104848cce4f0222f7a5dffb390a018e87a).

APPROVED.

The three-file documentation diff is sound:

The frozen a9563b4263de0ae97661304661efee44143953a8 source corpus reproduces 275 literal matches on 274 name/source-line coordinates and 195 source lines across the 32 names. The ledger coordinate set matches the raw coordinate set exactly; H/P/L totals are 233/27/14.
The base delta from the frozen tree is manifest-only, and the current fetched origin/main #851 boundary grep is empty. The operations.md correction matches the current tree: the reusable retains the yq runner fallback, while rt uses internal/config and internal/forgejo. The consumer-owned hook examples are explicitly caveated.
Exact-head verification passes: bats tests 61/61; bats tests/workflows.bats 40/40; go test ./...; go vet ./...; all 16 workflow YAML files parse; fragment-check passes; and git diff --check passes.

Production boundary: this PR does not demonstrate main unblocked. The merge-triggered release/decide+act run must execute and succeed after the non-manifest merge; current mode=update two-arm results remain prediction, not production evidence.

Fresh independent review of PR #886 at exact head `20ac7664de81da4d15894b2b572e47eac9298344` (base `ed6d67104848cce4f0222f7a5dffb390a018e87a`). APPROVED. The three-file documentation diff is sound: - The frozen `a9563b4263de0ae97661304661efee44143953a8` source corpus reproduces 275 literal matches on 274 name/source-line coordinates and 195 source lines across the 32 names. The ledger coordinate set matches the raw coordinate set exactly; H/P/L totals are 233/27/14. - The base delta from the frozen tree is manifest-only, and the current fetched `origin/main` #851 boundary grep is empty. The `operations.md` correction matches the current tree: the reusable retains the yq runner fallback, while `rt` uses `internal/config` and `internal/forgejo`. The consumer-owned hook examples are explicitly caveated. - Exact-head verification passes: `bats tests` 61/61; `bats tests/workflows.bats` 40/40; `go test ./...`; `go vet ./...`; all 16 workflow YAML files parse; fragment-check passes; and `git diff --check` passes. Production boundary: this PR does not demonstrate main unblocked. The merge-triggered `release/decide+act` run must execute and succeed after the non-manifest merge; current mode=update two-arm results remain prediction, not production evidence.

sentry approved these changes

2026-08-26 09:35:46 +02:00

sentry left a comment

Fresh independent review of PR #886 at exact head 20ac7664de81da4d15894b2b572e47eac9298344 (base ed6d67104848cce4f0222f7a5dffb390a018e87a).

APPROVED.

The three-file documentation diff is sound:

The frozen a9563b4263de0ae97661304661efee44143953a8 source corpus reproduces 275 literal matches on 274 name/source-line coordinates and 195 source lines across the 32 names. The ledger coordinate set matches the raw coordinate set exactly; H/P/L totals are 233/27/14.
The base delta from the frozen tree is manifest-only, and the current fetched origin/main #851 boundary grep is empty. The operations.md correction matches the current tree: the reusable retains the yq runner fallback, while rt uses internal/config and internal/forgejo. The consumer-owned hook examples are explicitly caveated.
Exact-head verification passes: bats tests 61/61; bats tests/workflows.bats 40/40; go test ./...; go vet ./...; all 16 workflow YAML files parse; fragment-check passes; and git diff --check passes.