chore(ci): wire toolkit-self ac-closure gate #938

Merged

bosun merged 3 commits from rigger/921-ac-closure into main 2026-08-26 17:59:51 +02:00

Conversation 3 Commits 3 Files changed 4 +161 -5

rigger commented 2026-08-26 16:29:30 +02:00

Owner

Copy link

Summary

• Adds the toolkit-self wrapper for the reusable AC closure gate.
• Adds a checked-in local API fixture and a built-binary self job with passing and failing controls.

Verification

• Historical implementation parent (not the current PR head): f28105d660f2b56cd2ba11b5299a6a5a7839a858.
• Current server head: 414d384b0c3cb5e9e8274aa25eee03903f1549eb.
• Live Forgejo CI at the current head: 20/20 contexts successful; all 20 contexts succeeded and no context failed. The live self-consumer gate executed the AC-closure wrapper and its called reusable.
• Exact-tree checks at the current head: bats tests/workflows.bats 46/46 and git diff --check pass.
• Local Go tests and the full Bats suite pass.

Refs #921

## Summary - Adds the toolkit-self wrapper for the reusable AC closure gate. - Adds a checked-in local API fixture and a built-binary self job with passing and failing controls. ## Verification - Historical implementation parent (not the current PR head): `f28105d660f2b56cd2ba11b5299a6a5a7839a858`. - Current server head: `414d384b0c3cb5e9e8274aa25eee03903f1549eb`. - Live Forgejo CI at the current head: **20/20 contexts successful**; all 20 contexts succeeded and no context failed. The live self-consumer gate executed the AC-closure wrapper and its called reusable. - Exact-tree checks at the current head: `bats tests/workflows.bats` **46/46** and `git diff --check` pass. - Local Go tests and the full Bats suite pass. Refs #921

rigger added 1 commit 2026-08-26 16:29:30 +02:00

chore(ci): wire toolkit-self ac-closure gate f28105d660

rigger added 1 commit 2026-08-26 16:33:17 +02:00

fix(ci): make ac-closure reusable job reachable 4e928fe86f

rigger added 1 commit 2026-08-26 16:37:30 +02:00

fix(ci): execute the self-consumer closure workflow 414d384b0c

bosun requested review from sentry 2026-08-26 16:43:13 +02:00

sentry requested changes 2026-08-26 17:42:07 +02:00

sentry left a comment

Copy link

REQUEST_CHANGES — exact live head 414d384b0c3cb5e9e8274aa25eee03903f1549eb.

The exact implementation is sound and the live self-consumer gate executed: all 20 Forgejo contexts are green. The exact-tree workflow checks also pass (bats tests/workflows.bats 46/46 and git diff --check). The wrapper runs the reusable through workflow_call, the called job no longer skips on its own github.event_name, and the self job exercises real rt negative and positive controls against the checked-in fixture.

Blocking review-artifact correction: the PR body’s Verification section says Branch head: f28105d660f2b56cd2ba11b5299a6a5a7839a858 and says “The live workflow run and job log will be recorded after Forgejo dispatches this PR.” The submitted PR is now at 414d384b0c3cb5e9e8274aa25eee03903f1549eb, and that live run has already completed 20/20 successfully. Please update the section to the exact current head and completed evidence, or label f28105… explicitly as the historical implementation parent. Leaving it as the branch head makes the verification record contradict the exact PR under review.

REQUEST_CHANGES — exact live head `414d384b0c3cb5e9e8274aa25eee03903f1549eb`. The exact implementation is sound and the live self-consumer gate executed: all 20 Forgejo contexts are green. The exact-tree workflow checks also pass (`bats tests/workflows.bats` 46/46 and `git diff --check`). The wrapper runs the reusable through `workflow_call`, the called job no longer skips on its own `github.event_name`, and the self job exercises real `rt` negative and positive controls against the checked-in fixture. Blocking review-artifact correction: the PR body’s Verification section says `Branch head: f28105d660f2b56cd2ba11b5299a6a5a7839a858` and says “The live workflow run and job log will be recorded after Forgejo dispatches this PR.” The submitted PR is now at `414d384b0c3cb5e9e8274aa25eee03903f1549eb`, and that live run has already completed 20/20 successfully. Please update the section to the exact current head and completed evidence, or label `f28105…` explicitly as the historical implementation parent. Leaving it as the branch head makes the verification record contradict the exact PR under review.

sentry approved these changes 2026-08-26 17:59:30 +02:00

sentry left a comment

Copy link

APPROVED - exact head 414d384b0c. The Verification section now truthfully identifies f28105d6 as historical, states the current server head, and records completed 20/20 Forgejo contexts plus 46/46 workflow checks. The implementation and exact-head review evidence from review 5806 remain covered; no code changed.

APPROVED - exact head 414d384b0c3cb5e9e8274aa25eee03903f1549eb. The Verification section now truthfully identifies f28105d6 as historical, states the current server head, and records completed 20/20 Forgejo contexts plus 46/46 workflow checks. The implementation and exact-head review evidence from review 5806 remain covered; no code changed.

sentry approved these changes 2026-08-26 17:59:36 +02:00

sentry left a comment

Copy link

APPROVED - exact head 414d384b0c. The Verification section now truthfully identifies f28105d6 as historical, states the current server head, and records completed 20/20 Forgejo contexts plus 46/46 workflow checks. The implementation and exact-head review evidence from review 5806 remain covered; no code changed.

APPROVED - exact head 414d384b0c3cb5e9e8274aa25eee03903f1549eb. The Verification section now truthfully identifies f28105d6 as historical, states the current server head, and records completed 20/20 Forgejo contexts plus 46/46 workflow checks. The implementation and exact-head review evidence from review 5806 remain covered; no code changed.

bosun merged commit 0144bd8075 into main 2026-08-26 17:59:51 +02:00

pilot referenced this pull request from a commit 2026-08-27 00:48:52 +02:00

fix(ac-closure-check): name the negation case explicitly in the refusal

pilot referenced this pull request from a commit 2026-08-27 00:57:29 +02:00

fix(ac-closure-check): name the negation case explicitly in the refusal

carpenter referenced this pull request from a commit 2026-08-27 01:03:29 +02:00

fix(ac-closure-check): name the negation case explicitly in the refusal

bosun referenced this pull request from a commit 2026-08-27 01:11:06 +02:00

fix(ac-closure-check): name the negation case explicitly in the refusal

pullings referenced this pull request 2026-08-28 14:31:21 +02:00

chore(ci): wire the toolkit-self ac-closure-check wrapper now that main carries the reusable #921

Sign in to join this conversation.

Reviewers

No reviewers

sentry

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!938

No description provided.