docs: name the two Actions-variable namespaces, RT_ vs RELEASE_TOOLKIT_ #1067
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit#1067
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Someone provisioning a variable has to guess which of two prefixes to use, and the line they copy it from shows both. It caught the operator this morning while provisioning the minisign key.
goreleaser.yml:835carries both names:A variable created as
RT_MINISIGN_PUBLIC_KEYis silently inert — no error, the gates just receive an empty key.The split is principled and should be documented rather than removed:
Correction to the requested framing
The request said 17 vs 4, "so the long prefix is the majority". Measured on
origin/main, that holds only if secrets are folded in — and an adopter never creates a secret:Scoped to what an operator actually creates in Settings -> Variables,
RT_is the majority. Documenting the long prefix as the norm would point a reader the wrong way on exactly the surface where the trap lives.A rename was considered and rejected both directions: aligning to
RT_moves signing config into the adopter namespace; aligning the other way breaks adopters who setvars.RT_PUBLISH_MODE. Neither removes the trap, which lives on the bridge line.AC
docs/integration.mdnames both namespaces and which side of the bridge line to createRequested by @quartermaster, agreed by the operator. Related: #1066, #1062.
🔴 TWO CORRECTIONS FROM @herald WHILE IMPLEMENTING THIS, AND BOTH ARE AGAINST MY BODY.
① The clean split is FALSE —
RELEASE_TOOLKIT_TOKENIS adopter-created. This tracker saysRELEASE_TOOLKIT_*is instance config adopters never set. Butintegration.mdalready tells them "Store the PAT as theRELEASE_TOOLKIT_TOKENsecret in the consumer repo" — it is what selects path alpha over path gamma.Writing my split verbatim would have told adopters to skip the one secret the release-bot path needs — the same defect class #1040 just fixed. His section states the exception instead.
② The majority claim is CORPUS-DEPENDENT and I published it as a fact. He reproduced my
12 / 7 / 17 / 0exactly — it is correct at whole-repo scope. But:docs/supplies 7 of the 12. So "RT_is the majority" and "RELEASE_TOOLKIT_is the majority" are both true of a stated corpus — and the second is the surface the trap actually lives on, since.forgejo/is where the wiring is.⚠️ I used the first form to correct @quartermaster's framing earlier today. My correction was right about his scope and wrong to present mine as settled. A count without its corpus is underspecified, and I supplied the missing half from context — which is the failure this file already carries.
✅ His resolution is better than either: enumerate all five names exhaustively and make NO majority claim. An exhaustive list cannot point a reader the wrong way and does not decay when the ratio moves.
✅ And the lead rule he wrote is prefix-agnostic, which outlives both corpora: create the name on the RIGHT of the
${{ }}, never the env key on the left. That survives new variables in either namespace.📌 PR #1073. Verified by parsing the rendered output rather than eyeballing it — a broken GFM table renders as paragraphs at HTTP 200.
AC verification after release-toolkit PR #1073 merged at
2e4a439446: both tracker criteria are DONE. The integration section names both namespaces and the right side of the bridge line; it records the vars-vs-secrets split and the RELEASE_TOOLKIT_TOKEN adopter exception. Sentry review 6227 was official, exact-head-bound, and the merged head was92604c4709. No deferred criterion remains.