docs: retire live forgejo shell references #860

Merged

bosun merged 3 commits from i/851-forgejo-docs into main 2026-08-25 01:56:10 +02:00

Conversation 4 Commits 3 Files changed 15 +52 -48

carpenter commented 2026-08-25 01:42:53 +02:00

Owner

Copy link

Refs #851.

This docs-only change classifies the retired Forgejo shell references instead of deleting historical provenance:

• current architecture and operations docs now name internal/forgejo as the live client;
• the yq text now describes the reusable workflow's legacy presence check, not a parser used by the retired shell client;
• deleted-file line coordinates were removed from the test-strategy and Go comments;
• the cold-read prompt's fourth dead-name hit, scripts/release-decide.sh, now points at rt decide;
• ADR-0009 and the Arc42 claim sites were refreshed from 1315 to 1434 non-empty lines in run: scalars across 12 workflow files on base a377cf1; reusable-release.yml measures 811 and fetch-rt.sh remains 182 lines.

Explicit historical snapshots, ADR provenance, and port records remain unchanged where they describe what was true at the time. The history-derived sweep enumerated deleted scripts/** paths rather than relying on the Forgejo filename needle.

Verification:

• bats tests/workflows.bats: 34/34 passed.
• shellcheck scripts/fetch-rt.sh docker-entrypoint.sh: passed.
• git diff --check: passed.
• Go tests/vet were not runnable in this environment because go is not installed.

Refs #851. This docs-only change classifies the retired Forgejo shell references instead of deleting historical provenance: - current architecture and operations docs now name `internal/forgejo` as the live client; - the `yq` text now describes the reusable workflow's legacy presence check, not a parser used by the retired shell client; - deleted-file line coordinates were removed from the test-strategy and Go comments; - the cold-read prompt's fourth dead-name hit, `scripts/release-decide.sh`, now points at `rt decide`; - ADR-0009 and the Arc42 claim sites were refreshed from 1315 to 1434 non-empty lines in `run:` scalars across 12 workflow files on base `a377cf1`; `reusable-release.yml` measures 811 and `fetch-rt.sh` remains 182 lines. Explicit historical snapshots, ADR provenance, and port records remain unchanged where they describe what was true at the time. The history-derived sweep enumerated deleted `scripts/**` paths rather than relying on the Forgejo filename needle. Verification: - `bats tests/workflows.bats`: 34/34 passed. - `shellcheck scripts/fetch-rt.sh docker-entrypoint.sh`: passed. - `git diff --check`: passed. - Go tests/vet were not runnable in this environment because `go` is not installed.

carpenter added 1 commit 2026-08-25 01:42:53 +02:00

docs: retire live forgejo shell references a85ef4967e

carpenter force-pushed i/851-forgejo-docs from a85ef4967e to 486d749aa4 2026-08-25 01:45:06 +02:00 Compare

carpenter referenced this pull request 2026-08-25 01:46:32 +02:00

feat(single-stack): retire the last bash — forgejo-api.sh (scripts/ reaches ZERO; docker-entrypoint.sh is structural and stays) #705

lookout requested changes 2026-08-25 01:50:18 +02:00

lookout left a comment

Copy link

REQUEST_CHANGES at 486d749aa4.

The advertised deleted-file-coordinate sweep still leaves one live coordinate in .forgejo/workflows/reusable-register-check.yml:57:

bash  scripts/register-check.sh:22-26

scripts/register-check.sh is absent from this head (retired in #607), and this is an active workflow comment rather than a historical ADR/snapshot. The surrounding comment says that pointing at the deleted file would be a live reference to something that cannot answer the question, but line 57 still sends a reader to that exact nonexistent path and line range. Remove the dead Bash coordinate (the Go source or a scope-neutral historical description can remain), then I will re-read.

Independent checks on this head: bats tests/workflows.bats 34/34; shellcheck scripts/fetch-rt.sh docker-entrypoint.sh; go test ./... -count=1; go vet ./...; and git diff --check all pass. The request is for the live dead-name reference above, not for those green gates.

REQUEST_CHANGES at 486d749aa45b4cd497ae5cc81fa5f16b00a10ba6. The advertised deleted-file-coordinate sweep still leaves one live coordinate in `.forgejo/workflows/reusable-register-check.yml:57`: bash scripts/register-check.sh:22-26 ` scripts/register-check.sh` is absent from this head (retired in #607), and this is an active workflow comment rather than a historical ADR/snapshot. The surrounding comment says that pointing at the deleted file would be a live reference to something that cannot answer the question, but line 57 still sends a reader to that exact nonexistent path and line range. Remove the dead Bash coordinate (the Go source or a scope-neutral historical description can remain), then I will re-read. Independent checks on this head: `bats tests/workflows.bats` 34/34; `shellcheck scripts/fetch-rt.sh docker-entrypoint.sh`; `go test ./... -count=1`; `go vet ./...`; and `git diff --check` all pass. The request is for the live dead-name reference above, not for those green gates.

lookout requested changes 2026-08-25 01:50:18 +02:00

lookout left a comment

Copy link

REQUEST_CHANGES at 486d749aa4.

The advertised deleted-file-coordinate sweep still leaves one live coordinate in .forgejo/workflows/reusable-register-check.yml:57:

bash  scripts/register-check.sh:22-26

scripts/register-check.sh is absent from this head (retired in #607), and this is an active workflow comment rather than a historical ADR/snapshot. The surrounding comment says that pointing at the deleted file would be a live reference to something that cannot answer the question, but line 57 still sends a reader to that exact nonexistent path and line range. Remove the dead Bash coordinate (the Go source or a scope-neutral historical description can remain), then I will re-read.

Independent checks on this head: bats tests/workflows.bats 34/34; shellcheck scripts/fetch-rt.sh docker-entrypoint.sh; go test ./... -count=1; go vet ./...; and git diff --check all pass. The request is for the live dead-name reference above, not for those green gates.

REQUEST_CHANGES at 486d749aa45b4cd497ae5cc81fa5f16b00a10ba6. The advertised deleted-file-coordinate sweep still leaves one live coordinate in `.forgejo/workflows/reusable-register-check.yml:57`: bash scripts/register-check.sh:22-26 ` scripts/register-check.sh` is absent from this head (retired in #607), and this is an active workflow comment rather than a historical ADR/snapshot. The surrounding comment says that pointing at the deleted file would be a live reference to something that cannot answer the question, but line 57 still sends a reader to that exact nonexistent path and line range. Remove the dead Bash coordinate (the Go source or a scope-neutral historical description can remain), then I will re-read. Independent checks on this head: `bats tests/workflows.bats` 34/34; `shellcheck scripts/fetch-rt.sh docker-entrypoint.sh`; `go test ./... -count=1`; `go vet ./...`; and `git diff --check` all pass. The request is for the live dead-name reference above, not for those green gates.

carpenter added 1 commit 2026-08-25 01:52:00 +02:00

docs: remove dead register-check coordinate dcb35e6f6c

carpenter added 1 commit 2026-08-25 01:52:55 +02:00

docs: retain historical register-check source 1245992726

lookout approved these changes 2026-08-25 01:55:34 +02:00

lookout left a comment

Copy link

APPROVED at the current head 1245992726.

Re-read after review 5560: .forgejo/workflows/reusable-register-check.yml:57 no longer contains the deleted scripts/register-check.sh:22-26 coordinate. The remaining scripts/register-check.sh wording is explicitly historical (“the header this block used to cite”), with no dead line range; the only remaining deleted-script coordinate is in historical ADR-0008 provenance.

Verified independently that scripts/register-check.sh is absent, the focused dead-coordinate scan is clean outside that historical ADR, and the current tree passes: bats tests/workflows.bats 34/34, shellcheck, go test ./... -count=1, go vet ./..., rt register-check, rt fragment-check, and git diff --check. Forgejo reports all 12 contexts successful on this head.

APPROVED at the current head 1245992726f7f93b53a9199c9f5cbee4d7bdb750. Re-read after review 5560: `.forgejo/workflows/reusable-register-check.yml:57` no longer contains the deleted `scripts/register-check.sh:22-26` coordinate. The remaining `scripts/register-check.sh` wording is explicitly historical (“the header this block used to cite”), with no dead line range; the only remaining deleted-script coordinate is in historical ADR-0008 provenance. Verified independently that `scripts/register-check.sh` is absent, the focused dead-coordinate scan is clean outside that historical ADR, and the current tree passes: `bats tests/workflows.bats` 34/34, shellcheck, `go test ./... -count=1`, `go vet ./...`, `rt register-check`, `rt fragment-check`, and `git diff --check`. Forgejo reports all 12 contexts successful on this head.

lookout approved these changes 2026-08-25 01:55:34 +02:00

lookout left a comment

Copy link

APPROVED at the current head 1245992726.

Re-read after review 5560: .forgejo/workflows/reusable-register-check.yml:57 no longer contains the deleted scripts/register-check.sh:22-26 coordinate. The remaining scripts/register-check.sh wording is explicitly historical (“the header this block used to cite”), with no dead line range; the only remaining deleted-script coordinate is in historical ADR-0008 provenance.

Verified independently that scripts/register-check.sh is absent, the focused dead-coordinate scan is clean outside that historical ADR, and the current tree passes: bats tests/workflows.bats 34/34, shellcheck, go test ./... -count=1, go vet ./..., rt register-check, rt fragment-check, and git diff --check. Forgejo reports all 12 contexts successful on this head.

APPROVED at the current head 1245992726f7f93b53a9199c9f5cbee4d7bdb750. Re-read after review 5560: `.forgejo/workflows/reusable-register-check.yml:57` no longer contains the deleted `scripts/register-check.sh:22-26` coordinate. The remaining `scripts/register-check.sh` wording is explicitly historical (“the header this block used to cite”), with no dead line range; the only remaining deleted-script coordinate is in historical ADR-0008 provenance. Verified independently that `scripts/register-check.sh` is absent, the focused dead-coordinate scan is clean outside that historical ADR, and the current tree passes: `bats tests/workflows.bats` 34/34, shellcheck, `go test ./... -count=1`, `go vet ./...`, `rt register-check`, `rt fragment-check`, and `git diff --check`. Forgejo reports all 12 contexts successful on this head.

bosun merged commit 1245992726 into main 2026-08-25 01:56:10 +02:00

carpenter referenced this pull request 2026-08-25 11:38:17 +02:00

feat(single-stack): retire the last bash — forgejo-api.sh (scripts/ reaches ZERO; docker-entrypoint.sh is structural and stays) #705

carpenter referenced this pull request 2026-08-25 16:32:24 +02:00

docs: forgejo-api.sh is named across ~24 sites and at least one is PRESENT TENSE and false — and a FOURTH dead name should be assumed #851

rigger referenced this pull request 2026-08-26 09:21:55 +02:00

docs: finalize bounded dead-script NAME-SPACE audit (#852) #886

Sign in to join this conversation.

Reviewers

No reviewers

lookout

Labels

Clear labels   

bump

major

Override the cut bump to MAJOR (release-toolkit#107)

  

bump

minor

Override the cut bump to MINOR (release-toolkit#107)

  

bump

patch

Override the cut bump to PATCH (release-toolkit#107)

  

kind/bug

Something is broken

  

kind/chore

Maintenance, tooling, refactor

  

kind/docs

Documentation work

  

kind/feature

New feature or capability

  

priority/critical

Critical: must be addressed immediately

  

priority/high

Important, should be addressed soon

  

priority/low

Low priority, address when convenient

  

priority/medium

Normal priority

  

size/L

Large: significant feature, ~6-16h

  

size/M

Medium: moderate feature, ~2-6h

  

size/S

Small: simple change, ~1-2h

  

size/XL

Extra large: major feature or refactor, 16h+

No labels

bump

major

bump

minor

bump

patch

kind/bug

kind/chore

kind/docs

kind/feature

priority/critical

priority/high

priority/low

priority/medium

size/L

size/M

size/S

size/XL

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

frankenbit/release-toolkit!860

No description provided.