frankenbit/release-toolkit
frankenbit/release-toolkit
15
1
Fork 0
Code Issues 11 Pull requests Projects Releases 106 Packages 1 Wiki Activity Actions

fix(manifest-pr): honor configured bot identity (#722) #868

Merged
pullings merged 1 commit from i/722-configured-bot-identity into main 2026-08-25 17:04:51 +02:00
Conversation 2 Commits 1 Files changed 4 +46 -31
carpenter commented 2026-08-25 17:00:38 +02:00
Owner
Copy link

Summary

  • add --bot-identity to rt manifest-pr, retaining release-bot as the direct-command fallback
  • thread RELEASE_TOOLKIT_GIT_NAME from the reusable workflow into the self-assignment guard
  • replace the defect-pinning custom-bot expectation with default and custom identity regression controls

Verification

  • focused manifest-pr tests pass
  • go test ./... -count=1 passes
  • go vet ./... and go build ./... pass
  • cleaned-cache golangci-lint run --timeout=5m: 0 issues
  • rt fragment-check changelog.d passes
  • workflow YAML parses with yq
  • git diff --check passes

Refs #722

## Summary - add `--bot-identity` to `rt manifest-pr`, retaining `release-bot` as the direct-command fallback - thread `RELEASE_TOOLKIT_GIT_NAME` from the reusable workflow into the self-assignment guard - replace the defect-pinning custom-bot expectation with default and custom identity regression controls ## Verification - focused manifest-pr tests pass - `go test ./... -count=1` passes - `go vet ./...` and `go build ./...` pass - cleaned-cache `golangci-lint run --timeout=5m`: `0 issues` - `rt fragment-check changelog.d` passes - workflow YAML parses with `yq` - `git diff --check` passes Refs #722
fix(manifest-pr): honor configured bot identity (#722)
All checks were successful
check-self-bootstrap / check (pull_request) Successful in 5s
Details
fragment-check / toolkit-self gate (PR's own rt) (pull_request) Successful in 4s
Details
fragment-check / changelog fragment-kind (pull_request) Successful in 6s
Details
fragment-check / check (pull_request) Successful in 0s
Details
go-ci / lint + build + test (pull_request) Successful in 23s
Details
manifest-check / manifest-vs-tag consistency (pull_request) Successful in 6s
Details
manifest-check / check (pull_request) Successful in 0s
Details
register-check / register-drift check (pull_request) Successful in 6s
Details
register-check / check (pull_request) Successful in 0s
Details
tests / workflow-schema (pull_request) Successful in 3s
Details
tests / bats (pull_request) Successful in 7s
Details
tests / shellcheck (pull_request) Successful in 3s
Details
check-self-bootstrap / check (push) Successful in 5s
Details
go-ci / lint + build + test (push) Successful in 23s
Details
release / decide + act (push) Successful in 7s
Details
release / release (push) Successful in 0s
Details
tests / workflow-schema (push) Successful in 3s
Details
tests / bats (push) Successful in 7s
Details
tests / shellcheck (push) Successful in 3s
Details
b38c61c049
lookout approved these changes 2026-08-25 17:04:19 +02:00
lookout left a comment
Copy link

Reviewed the exact head b38c61c049 and APPROVED.

The #722 fix correctly carries the configured RELEASE_TOOLKIT_GIT_NAME into the manifest-pr self-assignment guard, with release-bot as the direct-command fallback. The focused regression controls cover both default and custom identities in both directions: the configured bot is skipped, while a different merger is assigned. The workflow passes --bot-identity with the same fallback.

Independent checks passed: focused manifest-pr tests, go test ./... -count=1, go vet ./..., go build ./..., bats tests, workflow YAML validation, manifest-pr --help, and git diff --check. Forgejo reports all 12 required contexts successful.

Reviewed the exact head b38c61c049b4bce445bc72f31eb0b58f03b81c55 and APPROVED. The #722 fix correctly carries the configured RELEASE_TOOLKIT_GIT_NAME into the manifest-pr self-assignment guard, with release-bot as the direct-command fallback. The focused regression controls cover both default and custom identities in both directions: the configured bot is skipped, while a different merger is assigned. The workflow passes --bot-identity with the same fallback. Independent checks passed: focused manifest-pr tests, go test ./... -count=1, go vet ./..., go build ./..., bats tests, workflow YAML validation, manifest-pr --help, and git diff --check. Forgejo reports all 12 required contexts successful.
lookout approved these changes 2026-08-25 17:04:19 +02:00
lookout left a comment
Copy link

Reviewed the exact head b38c61c049 and APPROVED.

The #722 fix correctly carries the configured RELEASE_TOOLKIT_GIT_NAME into the manifest-pr self-assignment guard, with release-bot as the direct-command fallback. The focused regression controls cover both default and custom identities in both directions: the configured bot is skipped, while a different merger is assigned. The workflow passes --bot-identity with the same fallback.

Independent checks passed: focused manifest-pr tests, go test ./... -count=1, go vet ./..., go build ./..., bats tests, workflow YAML validation, manifest-pr --help, and git diff --check. Forgejo reports all 12 required contexts successful.

Reviewed the exact head b38c61c049b4bce445bc72f31eb0b58f03b81c55 and APPROVED. The #722 fix correctly carries the configured RELEASE_TOOLKIT_GIT_NAME into the manifest-pr self-assignment guard, with release-bot as the direct-command fallback. The focused regression controls cover both default and custom identities in both directions: the configured bot is skipped, while a different merger is assigned. The workflow passes --bot-identity with the same fallback. Independent checks passed: focused manifest-pr tests, go test ./... -count=1, go vet ./..., go build ./..., bats tests, workflow YAML validation, manifest-pr --help, and git diff --check. Forgejo reports all 12 required contexts successful.
Sign in to join this conversation.
Reviewers
No reviewers
lookout
Labels
Clear labels   
bump
major
 Override the cut bump to MAJOR (release-toolkit#107)

  
bump
minor
 Override the cut bump to MINOR (release-toolkit#107)

  
bump
patch
 Override the cut bump to PATCH (release-toolkit#107)

  
kind/bug
Something is broken

  
kind/chore
Maintenance, tooling, refactor

  
kind/docs
Documentation work

  
kind/feature
New feature or capability

  
priority/critical
Critical: must be addressed immediately

  
priority/high
Important, should be addressed soon

  
priority/low
Low priority, address when convenient

  
priority/medium
Normal priority

  
size/L
Large: significant feature, ~6-16h

  
size/M
Medium: moderate feature, ~2-6h

  
size/S
Small: simple change, ~1-2h

  
size/XL
Extra large: major feature or refactor, 16h+

No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
frankenbit/release-toolkit!868
No description provided.