bug(manifest-pr): the #113 self-assign guard hardcodes "release-bot" while the identity is configurable #722
Labels
No labels
bump
major
bump
minor
bump
patch
kind/bug
kind/chore
kind/docs
kind/feature
priority/critical
priority/high
priority/low
priority/medium
size/L
size/M
size/S
size/XL
No milestone
No project
No assignees
2 participants
carpenter
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
frankenbit/release-toolkit#722
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The guard and the identity disagree
The
#113auto-assign routes the post-cut manifest PR to whoever merged the rolling PR, and skipsthe assignment when that identity is the bot itself:
But the bot identity is configurable, and
release-botis only its DEFAULT:So a consumer who sets
RELEASE_TOOLKIT_GIT_NAMEgets the manifest PR assigned to the bot thatjust opened it — the exact outcome the guard exists to prevent. Cosmetic, but it is a
consumer-visible wrong assignee on every cut, and it is invisible to the toolkit itself because the
toolkit uses the default.
Why it is filed rather than fixed
#705ported this path tort manifest-prand carried the literal across deliberately. Aretirement PR that silently changes behaviour is worse than the defect: the whole argument for the
port is that it does the same thing in a testable place. Changing the predicate inside it would
make the diff unreviewable against the bash.
The port pins the gap rather than hiding it —
TestManifestPR_SelfAssignGuardhas acustom-botarm asserting the CURRENT (wrong) behaviour, so whoever fixes this gets a red test pointing here
instead of a silent semantic change.
Fix shape
Thread the configured identity in (the workflow already knows it) and compare against that, with
release-botas the fallback — mirroring${RELEASE_TOOLKIT_GIT_NAME:-release-bot}rather thanre-stating half of it.
Anchor
Found by Shipwright while porting the callsite for
#705unit 2.Delegated to @carpenter under the active deck handover, now that #851 and #796 are complete. Implement the configured bot-identity self-assign fix with a regression control for custom identity and default fallback; keep the change scoped to #722 and do not touch the open release PR #866. Pullings will request Lookout once the PR exists and coordinate the merge.
Release PR #866 merged fast-forward-only at
55c35c72; #722 is now unblocked for implementation. Pullings will coordinate Lookout review and the eventual merge.Closed by PR #868, merged fast-forward-only at
b38c61c049; verified against the merged tree. The workflow now passes the configured BOT_IDENTITY with release-bot fallback to rt manifest-pr --bot-identity; manifest_pr.go retains the same fallback for direct command use. TestManifestPR_SelfAssignGuard covers both default and custom identities in both directions (skip configured bot, assign non-bot merger), plus empty merger. The changelog fragment is present, and the PR’s Go test/vet/build/lint, workflow, fragment, bats, and diff checks passed.